SDKv2 ImportState and ExpectError Test Failures

[bflad]

Community Note

• Please vote on this issue by adding a 👍 reaction to the original issue to help the community and maintainers prioritize this request
• Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for issue followers and do not help prioritize the request
• If you are interested in working on this issue or have submitted a pull request, please leave a comment

Description

There are currently issues with Terraform Plugin SDK version 2 when an acceptance testing step includes both ImportState and ExpectError, where the newer version does not honor the check against the expected error. This has historically been used for verify that incorrect import identifiers trigger an appropriate error.

Some examples include:

=== CONT  TestAccAWSAutoscalingSchedule_basic
TestAccAWSAutoscalingSchedule_basic: testing_new_import_state.go:74: failed to import: terraform failed: exit status 1
stderr:
Error: Cannot import non-existent remote object
While attempting to import an existing object to
aws_autoscaling_schedule.foobar, the provider detected that no object exists
with the given id. Only pre-existing objects can be imported; check that the
id is correct and that it is associated with the provider's configured region
or endpoint, or use "terraform apply" to create a new remote object for this
resource.
--- FAIL: TestAccAWSAutoscalingSchedule_basic (193.36s)

=== CONT  TestAccAWSEcsService_basicImport
TestAccAWSEcsService_basicImport: testing_new_import_state.go:74: failed to import: terraform failed: exit status 1
stderr:
Error: Cannot import non-existent remote object
While attempting to import an existing object to aws_ecs_service.jenkins, the
provider detected that no object exists with the given id. Only pre-existing
objects can be imported; check that the id is correct and that it is
associated with the provider's configured region or endpoint, or use
"terraform apply" to create a new remote object for this resource.
--- FAIL: TestAccAWSEcsService_basicImport (95.53s)

=== CONT  TestAccAWSKinesisFirehoseDeliveryStream_basic
    TestAccAWSKinesisFirehoseDeliveryStream_basic: testing_new_import_state.go:74: failed to import: terraform failed: exit status 1

        stderr:

        Error: Expected ID in format of arn:PARTITION:firehose:REGION:ACCOUNTID:deliverystream/NAME and provided: just-a-name



--- FAIL: TestAccAWSKinesisFirehoseDeliveryStream_basic (101.43s)

Affected Tests

• TestAccAWSAutoscalingSchedule_basic
• TestAccAWSEcsService_basicImport
• TestAccAWSKinesisFirehoseDeliveryStream_basic

References

• V2 ImportState Testing Ignoring ExpectError terraform-plugin-sdk#532

[bflad]

Fixed with Terraform Plugin SDK v2.0.4. 👍

[ghost]

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. Thanks!