Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

service/directconnect: EqSe2 location is now EqSe2-EQ or EqSe2-WBE #15151

Closed
bflad opened this issue Sep 15, 2020 · 2 comments · Fixed by #15152
Closed

service/directconnect: EqSe2 location is now EqSe2-EQ or EqSe2-WBE #15151

bflad opened this issue Sep 15, 2020 · 2 comments · Fixed by #15152
Assignees
Labels
documentation Introduces or discusses updates to documentation. service/directconnect Issues and PRs that pertain to the directconnect service. technical-debt Addresses areas of the codebase that need refactoring or redesign. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure.
Milestone

Comments

@bflad
Copy link
Contributor

bflad commented Sep 15, 2020

Community Note

  • Please vote on this issue by adding a 👍 reaction to the original issue to help the community and maintainers prioritize this request
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for issue followers and do not help prioritize the request
  • If you are interested in working on this issue or have submitted a pull request, please leave a comment

Description

We have begun seeing consistent test failures such as:

=== CONT  TestAccAWSDxConnectionAssociation_basic
TestAccAWSDxConnectionAssociation_basic: resource_aws_dx_connection_association_test.go:15: After applying this test step, the plan was not empty.
stdout:
An execution plan has been generated and is shown below.
Resource actions are indicated with the following symbols:
-/+ destroy and then create replacement
Terraform will perform the following actions:
# aws_dx_connection_association.test must be replaced
-/+ resource "aws_dx_connection_association" "test" {
connection_id = "dxcon-fh4ovyb8"
~ id            = "dxcon-fh4ovyb8" -> (known after apply)
~ lag_id        = "dxlag-fgz5o5wi" -> (known after apply)
}
# aws_dx_lag.test must be replaced
-/+ resource "aws_dx_lag" "test" {
~ arn                    = "arn:aws:directconnect:us-west-2:*******:dxlag/dxlag-fgz5o5wi" -> (known after apply)
connections_bandwidth  = "1Gbps"
force_destroy          = true
~ has_logical_redundancy = "no" -> (known after apply)
~ id                     = "dxlag-fgz5o5wi" -> (known after apply)
~ jumbo_frame_capable    = true -> (known after apply)
~ location               = "EqSe2-EQ" -> "EqSe2"
name                   = "tf-dx-a6joi"
}
Plan: 2 to add, 0 to change, 2 to destroy.
--- FAIL: TestAccAWSDxConnectionAssociation_basic (22.62s)

=== CONT  TestAccAWSDxConnectionAssociation_multiConns
TestAccAWSDxConnectionAssociation_multiConns: resource_aws_dx_connection_association_test.go:31: After applying this test step, the plan was not empty.
stdout:
An execution plan has been generated and is shown below.
Resource actions are indicated with the following symbols:
-/+ destroy and then create replacement
Terraform will perform the following actions:
# aws_dx_connection_association.test1 must be replaced
-/+ resource "aws_dx_connection_association" "test1" {
connection_id = "dxcon-fhahsuz5"
~ id            = "dxcon-fhahsuz5" -> (known after apply)
~ lag_id        = "dxlag-fg2qk24n" -> (known after apply)
}
# aws_dx_connection_association.test2 must be replaced
-/+ resource "aws_dx_connection_association" "test2" {
connection_id = "dxcon-ffo721s8"
~ id            = "dxcon-ffo721s8" -> (known after apply)
~ lag_id        = "dxlag-fg2qk24n" -> (known after apply)
}
# aws_dx_lag.test must be replaced
-/+ resource "aws_dx_lag" "test" {
~ arn                    = "arn:aws:directconnect:us-west-2:*******:dxlag/dxlag-fg2qk24n" -> (known after apply)
connections_bandwidth  = "1Gbps"
force_destroy          = true
~ has_logical_redundancy = "no" -> (known after apply)
~ id                     = "dxlag-fg2qk24n" -> (known after apply)
~ jumbo_frame_capable    = true -> (known after apply)
~ location               = "EqSe2-EQ" -> "EqSe2"
name                   = "tf-dx-zg9b2"
}
Plan: 3 to add, 0 to change, 3 to destroy.
--- FAIL: TestAccAWSDxConnectionAssociation_multiConns (23.47s)

=== CONT  TestAccAWSDxLag_basic
TestAccAWSDxLag_basic: resource_aws_dx_lag_test.go:19: Check 4/5 error: aws_dx_lag.test: Attribute 'location' expected "EqSe2", got "EqSe2-WBE"
--- FAIL: TestAccAWSDxLag_basic (16.92s)

=== CONT  TestAccAWSDxLag_tags
TestAccAWSDxLag_tags: resource_aws_dx_lag_test.go:58: After applying this test step, the plan was not empty.
stdout:
An execution plan has been generated and is shown below.
Resource actions are indicated with the following symbols:
-/+ destroy and then create replacement
Terraform will perform the following actions:
# aws_dx_lag.test must be replaced
-/+ resource "aws_dx_lag" "test" {
~ arn                    = "arn:aws:directconnect:us-west-2:*******:dxlag/dxlag-fgp7fkdz" -> (known after apply)
connections_bandwidth  = "1Gbps"
force_destroy          = true
~ has_logical_redundancy = "no" -> (known after apply)
~ id                     = "dxlag-fgp7fkdz" -> (known after apply)
~ jumbo_frame_capable    = true -> (known after apply)
~ location               = "EqSe2-WBE" -> "EqSe2"
name                   = "tf-dx-lag-ujibm"
tags                   = {
"Environment" = "production"
"Usage"       = "original"
}
}
Plan: 1 to add, 0 to change, 1 to destroy.
--- FAIL: TestAccAWSDxLag_tags (17.54s)

Which seems to suggest that the Equinix Seattle location has been split and can be verified in the Direct Connect API:

$ aws directconnect describe-locations
{
    "locations": [
        {
            "locationCode": "EqSe2-WBE",
            "locationName": "Westin Building Exchange, Seattle, WA | Westin Building Exchange - SEA10 - Main FMMR, Seattle, WA",
            "region": "us-west-2",
            "availablePortSpeeds": [
                "10G"
            ],
            "availableProviders": [
                "Pureport",
                "Beanfield Metroconnect",
                "ePLDT",
                "Datapipe",
                "Telstra",
                "Colt",
                "Verizon",
                "Console Connect",
                "Internet2",
                "Transtelco",
                "Megaport",
                "GTT",
                "Layer42",
                "Equinix, Inc.",
                "Zayo Group",
                "Masergy",
                "QTS",
                "CenturyLink",
                "AT&T",
                "IX Reach",
                "Comcast",
                "Sprint",
                "XO Communications",
                "Telia Carrier",
                "HopOne",
                "PacketFabric",
                "Telus",
                "China Mobile International",
                "Epsilon"
            ]
        },
        {
            "locationCode": "EqSe2-EQ",
            "locationName": "Westin Building Exchange, Seattle, WA | Equinix, SE2, Seattle, WA",
            "region": "us-west-2",
            "availablePortSpeeds": [
                "1G",
                "10G"
            ],
            "availableProviders": [
                "Pureport",
                "Beanfield Metroconnect",
                "ePLDT",
                "Datapipe",
                "Telstra",
                "Colt",
                "Verizon",
                "Console Connect",
                "Internet2",
                "Transtelco",
                "Megaport",
                "GTT",
                "Layer42",
                "Equinix, Inc.",
                "Zayo Group",
                "Masergy",
                "QTS",
                "CenturyLink",
                "AT&T",
                "IX Reach",
                "Comcast",
                "Sprint",
                "XO Communications",
                "Telia Carrier",
                "HopOne",
                "PacketFabric",
                "Telus",
                "China Mobile International",
                "Epsilon"
            ]
        },

The testing and documentation needs to be updated to utilize one of the new location codes for consistency. Longer term, should be handled via data source (e.g. #9735) if possible.

Affected Resource(s)

  • aws_dx_connection
  • aws_dx_connection_association
  • aws_dx_lag

References

@bflad bflad added documentation Introduces or discusses updates to documentation. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure. service/directconnect Issues and PRs that pertain to the directconnect service. technical-debt Addresses areas of the codebase that need refactoring or redesign. labels Sep 15, 2020
@bflad bflad self-assigned this Sep 15, 2020
@bflad bflad added this to the Roadmap milestone Sep 15, 2020
bflad added a commit that referenced this issue Sep 15, 2020
Reference: #15151

Output from acceptance testing:

```
--- PASS: TestAccAWSDxConnection_basic (24.77s)
--- PASS: TestAccAWSDxConnectionAssociation_basic (25.44s)
--- PASS: TestAccAWSDxConnectionAssociation_multiConns (25.67s)
--- PASS: TestAccAWSDxConnection_tags (34.96s)
--- PASS: TestAccAWSDxLag_basic (36.35s)
--- PASS: TestAccAWSDxLag_tags (47.70s)
```
bflad added a commit that referenced this issue Sep 15, 2020
Reference: #15151

Output from acceptance testing:

```
--- PASS: TestAccAWSDxConnection_basic (24.77s)
--- PASS: TestAccAWSDxConnectionAssociation_basic (25.44s)
--- PASS: TestAccAWSDxConnectionAssociation_multiConns (25.67s)
--- PASS: TestAccAWSDxConnection_tags (34.96s)
--- PASS: TestAccAWSDxLag_basic (36.35s)
--- PASS: TestAccAWSDxLag_tags (47.70s)
```
@bflad bflad modified the milestones: Roadmap, v3.7.0 Sep 15, 2020
@ghost
Copy link

ghost commented Sep 17, 2020

This has been released in version 3.7.0 of the Terraform AWS provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template for triage. Thanks!

@ghost
Copy link

ghost commented Oct 16, 2020

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. Thanks!

@ghost ghost locked as resolved and limited conversation to collaborators Oct 16, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
documentation Introduces or discusses updates to documentation. service/directconnect Issues and PRs that pertain to the directconnect service. technical-debt Addresses areas of the codebase that need refactoring or redesign. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant