Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

resource/aws_glue_workflow: Ensure max_concurrent_runs attribute is saved during import #15538

Merged
merged 1 commit into from
Oct 8, 2020

Conversation

bflad
Copy link
Contributor

@bflad bflad commented Oct 7, 2020

Community Note

  • Please vote on this pull request by adding a 👍 reaction to the original pull request comment to help the community and maintainers prioritize this request
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for pull request followers and do not help prioritize the request

Release note for CHANGELOG:

* resource/aws_glue_workflow: Ensure `max_concurrent_runs` attribute is properly saved during import

The Terraform Plugin SDK version 2.0.4 upgrade fixed something with ImportStateVerify testing, which now catches these arguments were not properly being set during Read.

Previously:

=== CONT  TestAccAWSGlueWorkflow_maxConcurrentRuns
TestAccAWSGlueWorkflow_maxConcurrentRuns: resource_aws_glue_workflow_test.go:82: ImportStateVerify attributes not equivalent. Difference is shown below. Top is actual, bottom is expected.
(map[string]string) {
}
(map[string]string) (len=1) {
(string) (len=19) "max_concurrent_runs": (string) (len=1) "1"
}
--- FAIL: TestAccAWSGlueWorkflow_maxConcurrentRuns (53.75s)

Output from acceptance testing:

--- PASS: TestAccAWSGlueWorkflow_basic (18.54s)
--- PASS: TestAccAWSGlueWorkflow_DefaultRunProperties (18.56s)
--- PASS: TestAccAWSGlueWorkflow_Description (33.03s)
--- PASS: TestAccAWSGlueWorkflow_disappears (14.56s)
--- PASS: TestAccAWSGlueWorkflow_maxConcurrentRuns (50.47s)
--- PASS: TestAccAWSGlueWorkflow_Tags (48.23s)

…aved during import

The Terraform Plugin SDK version 2.0.4 upgrade fixed something with `ImportStateVerify` testing, which now catches these arguments were not properly being set during `Read`.

Previously:

```
=== CONT  TestAccAWSGlueWorkflow_maxConcurrentRuns
TestAccAWSGlueWorkflow_maxConcurrentRuns: resource_aws_glue_workflow_test.go:82: ImportStateVerify attributes not equivalent. Difference is shown below. Top is actual, bottom is expected.
(map[string]string) {
}
(map[string]string) (len=1) {
(string) (len=19) "max_concurrent_runs": (string) (len=1) "1"
}
--- FAIL: TestAccAWSGlueWorkflow_maxConcurrentRuns (53.75s)
```

Output from acceptance testing:

```
--- PASS: TestAccAWSGlueWorkflow_basic (18.54s)
--- PASS: TestAccAWSGlueWorkflow_DefaultRunProperties (18.56s)
--- PASS: TestAccAWSGlueWorkflow_Description (33.03s)
--- PASS: TestAccAWSGlueWorkflow_disappears (14.56s)
--- PASS: TestAccAWSGlueWorkflow_maxConcurrentRuns (50.47s)
--- PASS: TestAccAWSGlueWorkflow_Tags (48.23s)
```
@bflad bflad added the bug Addresses a defect in current functionality. label Oct 7, 2020
@bflad bflad requested a review from a team October 7, 2020 15:23
@ghost ghost added size/XS Managed by automation to categorize the size of a PR. service/glue Issues and PRs that pertain to the glue service. labels Oct 7, 2020
@gdavison gdavison self-assigned this Oct 7, 2020
Copy link
Contributor

@gdavison gdavison left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀

--- PASS: TestAccAWSGlueWorkflow_disappears (17.78s)
--- PASS: TestAccAWSGlueWorkflow_basic (23.70s)
--- PASS: TestAccAWSGlueWorkflow_DefaultRunProperties (24.00s)
--- PASS: TestAccAWSGlueWorkflow_Description (42.73s)
--- PASS: TestAccAWSGlueWorkflow_Tags (44.46s)
--- PASS: TestAccAWSGlueWorkflow_maxConcurrentRuns (46.71s)

@gdavison gdavison merged commit 5a276c3 into master Oct 8, 2020
@gdavison gdavison deleted the b-aws_glue_workflow-import branch October 8, 2020 17:52
gdavison added a commit that referenced this pull request Oct 8, 2020
@gdavison gdavison added this to the v3.10.0 milestone Oct 8, 2020
@ghost
Copy link

ghost commented Oct 9, 2020

This has been released in version 3.10.0 of the Terraform AWS provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template for triage. Thanks!

@ghost
Copy link

ghost commented Nov 8, 2020

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. Thanks!

@ghost ghost locked as resolved and limited conversation to collaborators Nov 8, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Addresses a defect in current functionality. service/glue Issues and PRs that pertain to the glue service. size/XS Managed by automation to categorize the size of a PR.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants