Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

resource/aws_glue_workflow: Ensure max_concurrent_runs attribute is saved during import #15538

Merged
merged 1 commit into from
Oct 8, 2020

Commits on Oct 7, 2020

  1. resource/aws_glue_workflow: Ensure max_concurrent_runs attribute is s…

    …aved during import
    
    The Terraform Plugin SDK version 2.0.4 upgrade fixed something with `ImportStateVerify` testing, which now catches these arguments were not properly being set during `Read`.
    
    Previously:
    
    ```
    === CONT  TestAccAWSGlueWorkflow_maxConcurrentRuns
    TestAccAWSGlueWorkflow_maxConcurrentRuns: resource_aws_glue_workflow_test.go:82: ImportStateVerify attributes not equivalent. Difference is shown below. Top is actual, bottom is expected.
    (map[string]string) {
    }
    (map[string]string) (len=1) {
    (string) (len=19) "max_concurrent_runs": (string) (len=1) "1"
    }
    --- FAIL: TestAccAWSGlueWorkflow_maxConcurrentRuns (53.75s)
    ```
    
    Output from acceptance testing:
    
    ```
    --- PASS: TestAccAWSGlueWorkflow_basic (18.54s)
    --- PASS: TestAccAWSGlueWorkflow_DefaultRunProperties (18.56s)
    --- PASS: TestAccAWSGlueWorkflow_Description (33.03s)
    --- PASS: TestAccAWSGlueWorkflow_disappears (14.56s)
    --- PASS: TestAccAWSGlueWorkflow_maxConcurrentRuns (50.47s)
    --- PASS: TestAccAWSGlueWorkflow_Tags (48.23s)
    ```
    bflad committed Oct 7, 2020
    Configuration menu
    Copy the full SHA
    488c667 View commit details
    Browse the repository at this point in the history