Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Consider Workspace State Fully Terminated Only After Directory Metadata Cleanup #15705

Merged
merged 1 commit into from
Oct 22, 2020
Merged

Consider Workspace State Fully Terminated Only After Directory Metadata Cleanup #15705

merged 1 commit into from
Oct 22, 2020

Conversation

Tensho
Copy link
Contributor

@Tensho Tensho commented Oct 18, 2020 •
edited
Loading

Community Note

  • Please vote on this pull request by adding a 👍 reaction to the original pull request comment to help the community and maintainers prioritize this request
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for pull request followers and do not help prioritize the request

Closes #15190
Closes #14517
Relates #14135
Relates #14950

Release note for CHANGELOG:

aws_workspaces_workspace: Fix the terminated state resolution

Acceptance Tests

$ make testacc TEST=./aws TESTARGS='-run=TestAccAwsWorkspacesWorkspace_recreate'
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./aws -v -count 1 -parallel 1 -run=TestAccAwsWorkspacesWorkspace_recreate -timeout 120m
=== RUN   TestAccAwsWorkspacesWorkspace_recreate
=== PAUSE TestAccAwsWorkspacesWorkspace_recreate
=== CONT  TestAccAwsWorkspacesWorkspace_recreate
--- PASS: TestAccAwsWorkspacesWorkspace_recreate (952.45s)
PASS
ok  	github.com/terraform-providers/terraform-provider-aws/aws	955.269s

References

@Tensho Tensho requested a review from a team October 18, 2020 18:58
@ghost ghost added size/S Managed by automation to categorize the size of a PR. service/workspaces Issues and PRs that pertain to the workspaces service. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure. labels Oct 18, 2020
@github-actions github-actions bot added the needs-triage Waiting for first response or review from a maintainer. label Oct 18, 2020
@Tensho Tensho changed the title Consider Workspace State Fully Terminated Only After Directory Metadata Cleanup [WIP] Consider Workspace State Fully Terminated Only After Directory Metadata Cleanup Oct 18, 2020
@Tensho Tensho force-pushed the fix-workspace-termintation branch from a83373b to d64a811 Compare October 19, 2020 07:37
@Tensho Tensho changed the title [WIP] Consider Workspace State Fully Terminated Only After Directory Metadata Cleanup Consider Workspace State Fully Terminated Only After Directory Metadata Cleanup Oct 19, 2020
@breathingdust
Copy link
Member

LGTM 🚀 Thanks @Tensho

Verified Acceptance Tests in Commercial (us-west-2)

make testacc TEST=./aws TESTARGS='-run=TestAccAwsWorkspacesWorkspace_recreate'
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./aws -v -count 1 -parallel 20 -run=TestAccAwsWorkspacesWorkspace_recreate -timeout 120m
=== RUN   TestAccAwsWorkspacesWorkspace_recreate
=== PAUSE TestAccAwsWorkspacesWorkspace_recreate
=== CONT  TestAccAwsWorkspacesWorkspace_recreate
--- PASS: TestAccAwsWorkspacesWorkspace_recreate (1840.47s)
PASS
ok  	github.com/terraform-providers/terraform-provider-aws/aws	1842.426s

@breathingdust breathingdust added this to the v3.12.0 milestone Oct 22, 2020
@breathingdust breathingdust merged commit ff209be into hashicorp:master Oct 22, 2020
breathingdust added a commit that referenced this pull request Oct 22, 2020
@breathingdust
Update CHANGELOG.md for #15705
7bfe0b8
@breathingdust breathingdust removed the needs-triage Waiting for first response or review from a maintainer. label Oct 22, 2020
@ghost
Copy link

ghost commented Oct 22, 2020

This has been released in version 3.12.0 of the Terraform AWS provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template for triage. Thanks!

@Tensho Tensho deleted the fix-workspace-termintation branch October 23, 2020 13:01
@ghost
Copy link

ghost commented Nov 21, 2020

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. Thanks!

@ghost ghost locked as resolved and limited conversation to collaborators Nov 21, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
No reviews
Assignees
No one assigned
Labels
service/workspaces Issues and PRs that pertain to the workspaces service. size/S Managed by automation to categorize the size of a PR. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure.
Projects
None yet
Milestone
v3.12.0
2 participants
@Tensho @breathingdust