Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

New Data Source: aws_rds_certificate #15789

Merged
merged 1 commit into from
Oct 22, 2020
Merged

New Data Source: aws_rds_certificate #15789

merged 1 commit into from
Oct 22, 2020

Conversation

bflad
Copy link
Contributor

@bflad bflad commented Oct 22, 2020

Community Note

  • Please vote on this pull request by adding a 👍 reaction to the original pull request comment to help the community and maintainers prioritize this request
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for pull request followers and do not help prioritize the request

Closes #15221

Release note for CHANGELOG:

* **New Data Source**: `aws_rds_certificate`

Output from acceptance testing in AWS Commercial:

--- PASS: TestAccAWSRDSCertificateDataSource_LatestValidTill (10.41s)
--- PASS: TestAccAWSRDSCertificateDataSource_Id (11.03s)

Output from acceptance testing in AWS GovCloud (US):

--- PASS: TestAccAWSRDSCertificateDataSource_LatestValidTill (15.02s)
--- PASS: TestAccAWSRDSCertificateDataSource_Id (16.86s)

@bflad
New Data Source: aws_rds_certificate
55f64c8 
Reference: #15221

Output from acceptance testing in AWS Commercial:

```
--- PASS: TestAccAWSRDSCertificateDataSource_LatestValidTill (10.41s)
--- PASS: TestAccAWSRDSCertificateDataSource_Id (11.03s)
```

Output from acceptance testing in AWS GovCloud (US):

```
--- PASS: TestAccAWSRDSCertificateDataSource_LatestValidTill (15.02s)
--- PASS: TestAccAWSRDSCertificateDataSource_Id (16.86s)
```
@bflad bflad added the new-data-source Introduces a new data source. label Oct 22, 2020
@bflad bflad requested a review from a team October 22, 2020 15:24
@ghost ghost added size/L Managed by automation to categorize the size of a PR. provider Pertains to the provider itself, rather than any interaction with AWS. service/rds Issues and PRs that pertain to the rds service. documentation Introduces or discusses updates to documentation. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure. labels Oct 22, 2020
@bflad bflad mentioned this pull request Oct 22, 2020
Merged
YakDriver
YakDriver approved these changes Oct 22, 2020
View reviewed changes
Copy link
Member

@YakDriver YakDriver left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fantastic! Once you merge, I'll update #15733.

@bflad bflad added this to the v3.12.0 milestone Oct 22, 2020
@bflad bflad merged commit 45651d3 into master Oct 22, 2020
@bflad bflad deleted the f-aws_rds_certificate branch October 22, 2020 17:22
bflad added a commit that referenced this pull request Oct 22, 2020
@bflad
Update CHANGELOG for #15789
8a6036e
@ghost
Copy link

ghost commented Oct 22, 2020

This has been released in version 3.12.0 of the Terraform AWS provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template for triage. Thanks!

@ghost
Copy link

ghost commented Nov 22, 2020

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. Thanks!

@ghost ghost locked as resolved and limited conversation to collaborators Nov 22, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@YakDriver YakDriver YakDriver approved these changes

Assignees
No one assigned
Labels
documentation Introduces or discusses updates to documentation. new-data-source Introduces a new data source. provider Pertains to the provider itself, rather than any interaction with AWS. service/rds Issues and PRs that pertain to the rds service. size/L Managed by automation to categorize the size of a PR. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure.
Projects
None yet
Milestone
v3.12.0
Development

Successfully merging this pull request may close these issues.

New Data Source: aws_rds_certificate
2 participants
@bflad @YakDriver