Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

tests/provider: Fix hardcoded ARN (DB*) #15733

Merged
merged 1 commit into from
Oct 28, 2020
Merged

tests/provider: Fix hardcoded ARN (DB*) #15733

merged 1 commit into from
Oct 28, 2020

Conversation

YakDriver
Copy link
Member

@YakDriver YakDriver commented Oct 20, 2020 •
edited
Loading

Community Note

  • Please vote on this pull request by adding a 👍 reaction to the original pull request comment to help the community and maintainers prioritize this request
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for pull request followers and do not help prioritize the request

Relates #15662, #15737, #15775
Fixes #15770
Fixes #15772
Fixes #15775

Release note for CHANGELOG:

NONE

Output from acceptance testing (GovCloud) (no regressions, 13 preexisting fails):

--- FAIL: TestAccAWSDbInstanceDataSource_ec2Classic (0.00s)                             (************** See 8.)
--- PASS: TestProvider_impl (0.48s)
--- PASS: TestProvider (1.26s)
--- PASS: TestAccAWSProvider_Region_AwsGovCloudUs (34.77s)
--- PASS: TestAccAWSProvider_Region_AwsCommercial (36.27s)
--- PASS: TestAccAWSProvider_Region_AwsChina (38.03s)
--- PASS: TestAccAWSProvider_IgnoreTags_Keys_Multiple (44.48s)
--- PASS: TestAccAWSProvider_IgnoreTags_KeyPrefixes_Multiple (45.18s)
--- PASS: TestAccAWSProvider_IgnoreTags_KeyPrefixes_One (45.61s)
--- PASS: TestAccAWSProvider_IgnoreTags_Keys_One (46.12s)
--- PASS: TestAccAWSProvider_IgnoreTags_KeyPrefixes_None (46.18s)
--- PASS: TestAccAWSProvider_AssumeRole_Empty (46.05s)
--- PASS: TestAccAWSProvider_IgnoreTags_EmptyConfigurationBlock (46.55s)
--- PASS: TestAccAWSProvider_Endpoints (47.59s)
--- PASS: TestAccAWSProvider_IgnoreTags_Keys_None (47.71s)
--- FAIL: TestAccAWSDBInstance_DbSubnetGroupName_RamShared (2.06s)                      (************** See 4.)
--- PASS: TestAccAWSDBInstance_optionGroup (404.18s)
--- PASS: TestAccAWSDBInstance_basic (451.06s)
--- PASS: TestAccAWSDBInstance_namePrefix (469.27s)
--- PASS: TestAccAWSDBInstance_generatedName (455.57s)
--- PASS: TestAccAWSDBInstance_DbSubnetGroupName (466.11s)
--- PASS: TestAccAWSDbInstanceDataSource_basic (524.74s)
--- PASS: TestAccAWSDBInstance_iamAuth (484.25s)
--- PASS: TestAccAWSDBInstance_AllowMajorVersionUpgrade (501.75s)
--- PASS: TestAccAWSDBInstance_IsAlreadyBeingDeleted (506.06s)
--- PASS: TestAccAWSDBInstance_DbSubnetGroupName_VpcSecurityGroupIds (546.38s)
--- PASS: TestAccAWSDBInstance_kmsKey (556.99s)
--- FAIL: TestAccAWSDBInstance_ReplicateSourceDb_DbSubnetGroupName_RamShared (0.39s)    (************** See 4.)
--- FAIL: TestAccAWSDBInstance_ReplicateSourceDb_DbSubnetGroupName (11.71s)             (*********** See 6, 7.)
--- SKIP: TestAccAWSDBInstance_ReplicateSourceDb_DeletionProtection (0.00s)
--- FAIL: TestAccAWSDBInstance_ReplicateSourceDb_DbSubnetGroupName_VpcSecurityGroupIds (11.76s) (*** See 6, 7.)
--- PASS: TestAccAWSDBInstance_DeletionProtection (561.04s)
--- PASS: TestAccAWSDBInstance_FinalSnapshotIdentifier_SkipFinalSnapshot (583.75s)
--- PASS: TestAccAWSDBInstance_FinalSnapshotIdentifier (845.96s)
--- PASS: TestAccAWSDBInstance_Password (487.25s)
--- PASS: TestAccAWSDBInstance_MaxAllocatedStorage (583.25s)
--- PASS: TestAccAWSDBInstance_subnetGroup (1024.31s)
--- PASS: TestAccAWSDBInstance_ReplicateSourceDb (1332.78s)
--- PASS: TestAccAWSDBInstance_ReplicateSourceDb_AvailabilityZone (1312.25s)
--- PASS: TestAccAWSDBInstance_ReplicateSourceDb_AutoMinorVersionUpgrade (1362.72s)
--- PASS: TestAccAWSDBInstance_ReplicateSourceDb_BackupWindow (1352.11s)
--- PASS: TestAccAWSDBInstance_ReplicateSourceDb_MaintenanceWindow (1322.71s)
--- PASS: TestAccAWSDBInstance_ReplicateSourceDb_AllowMajorVersionUpgrade (1473.76s)
--- PASS: TestAccAWSDBInstance_ReplicateSourceDb_IamDatabaseAuthenticationEnabled (1443.12s)
--- PASS: TestAccAWSDBInstance_ReplicateSourceDb_MaxAllocatedStorage (1463.76s)
--- PASS: TestAccAWSDBInstance_ReplicateSourceDb_BackupRetentionPeriod (1625.18s)
--- PASS: TestAccAWSDBInstance_ReplicateSourceDb_Monitoring (1585.15s)
--- PASS: TestAccAWSDBInstance_ReplicateSourceDb_AllocatedStorage (1767.03s)
--- PASS: TestAccAWSDBInstance_ReplicateSourceDb_ParameterGroupName (1402.62s)
--- PASS: TestAccAWSDBInstance_ReplicateSourceDb_VpcSecurityGroupIds (1332.38s)
--- FAIL: TestAccAWSDBInstance_SnapshotIdentifier_DbSubnetGroupName_RamShared (0.55s)   (************** See 4.)
--- PASS: TestAccAWSDBInstance_ReplicateSourceDb_Port (1453.40s)
--- FAIL: TestAccAWSDBInstance_S3Import (660.38s)                                       (************** See 5.)
--- FAIL: TestAccAWSDBInstance_ReplicateSourceDb_CACertificateIdentifier (711.06s)      (************** See 2.)
--- PASS: TestAccAWSDBInstance_SnapshotIdentifier (1078.66s)
--- PASS: TestAccAWSDBInstance_SnapshotIdentifier_AvailabilityZone (998.15s)
--- PASS: TestAccAWSDBInstance_SnapshotIdentifier_AutoMinorVersionUpgrade (1119.72s)
--- PASS: TestAccAWSDBInstance_ReplicateSourceDb_MultiAZ (2362.14s)
--- PASS: TestAccAWSDBInstance_SnapshotIdentifier_AllocatedStorage (1422.48s)
--- PASS: TestAccAWSDBInstance_SnapshotIdentifier_BackupWindow (1109.44s)
--- PASS: TestAccAWSDBInstance_SnapshotIdentifier_DbSubnetGroupName (1109.73s)
--- PASS: TestAccAWSDBInstance_SnapshotIdentifier_Io1Storage (1613.88s)
--- SKIP: TestAccAWSDBInstance_SnapshotIdentifier_Tags_Unset (0.00s)
--- PASS: TestAccAWSDBInstance_SnapshotIdentifier_BackupRetentionPeriod (1382.55s)
--- PASS: TestAccAWSDBInstance_SnapshotIdentifier_IamDatabaseAuthenticationEnabled (1090.92s)
--- PASS: TestAccAWSDBInstance_SnapshotIdentifier_DbSubnetGroupName_VpcSecurityGroupIds (1201.07s)
--- PASS: TestAccAWSDBInstance_SnapshotIdentifier_DeletionProtection (1169.32s)
--- PASS: TestAccAWSDBInstance_SnapshotIdentifier_MaintenanceWindow (1211.20s)
--- PASS: TestAccAWSDBInstance_SnapshotIdentifier_BackupRetentionPeriod_Unset (1624.23s)
--- PASS: TestAccAWSDBInstance_SnapshotIdentifier_AllowMajorVersionUpgrade (1957.95s)
--- PASS: TestAccAWSDBInstance_SnapshotIdentifier_MaxAllocatedStorage (1160.40s)
--- PASS: TestAccAWSDBInstance_SnapshotIdentifier_Monitoring (1260.76s)
--- PASS: TestAccAWSDBInstance_MonitoringRoleArn_EnabledToDisabled (772.61s)
--- PASS: TestAccAWSDBInstance_MonitoringRoleArn_EnabledToRemoved (813.71s)
--- PASS: TestAccAWSDBInstance_portUpdate (530.06s)
--- PASS: TestAccAWSDBInstance_SnapshotIdentifier_Port (1119.84s)
--- FAIL: TestAccAWSDBInstance_ec2Classic (0.00s)                                       (************** See 8.)
--- PASS: TestAccAWSDBInstance_MonitoringRoleArn_RemovedToEnabled (762.64s)
--- PASS: TestAccAWSDBInstance_SnapshotIdentifier_Tags (1060.32s)
--- PASS: TestAccAWSDBInstance_separateIopsUpdate (794.05s)
--- PASS: TestAccAWSDBInstance_SnapshotIdentifier_ParameterGroupName (1322.79s)
--- PASS: TestAccAWSDBInstance_SnapshotIdentifier_VpcSecurityGroupIds (1110.02s)
--- PASS: TestAccAWSDBInstance_SnapshotIdentifier_VpcSecurityGroupIds_Tags (1099.81s)
--- SKIP: TestAccAWSDBInstance_PerformanceInsightsEnabled_DisabledToEnabled (0.00s)
--- SKIP: TestAccAWSDBInstance_PerformanceInsightsEnabled_EnabledToDisabled (0.00s)
--- SKIP: TestAccAWSDBInstance_PerformanceInsightsKmsKeyId (0.00s)
--- SKIP: TestAccAWSDBInstance_PerformanceInsightsRetentionPeriod (0.00s)
--- SKIP: TestAccAWSDBInstance_ReplicateSourceDb_PerformanceInsightsEnabled (0.00s)
--- SKIP: TestAccAWSDBInstance_SnapshotIdentifier_PerformanceInsightsEnabled (0.00s)
--- PASS: TestAccAWSDBInstance_MonitoringInterval (1181.10s)
--- PASS: TestAccAWSDBOptionGroup_basic (7.81s)
--- PASS: TestAccAWSDBOptionGroup_timeoutBlock (7.75s)
--- PASS: TestAccAWSDBOptionGroup_namePrefix (8.03s)
--- PASS: TestAccAWSDBOptionGroup_generatedName (7.81s)
--- PASS: TestAccAWSDBOptionGroupConfig_OptionGroupDescription (7.54s)
--- PASS: TestAccAWSDBInstance_cloudwatchLogsExportConfiguration (355.58s)
--- PASS: TestAccAWSDBOptionGroup_Option_OptionSettings (14.99s)
--- PASS: TestAccAWSDBOptionGroup_Option_OptionSettings_IAMRole (16.93s)
--- PASS: TestAccAWSDBOptionGroup_sqlServerOptionsUpdate (13.67s)
--- PASS: TestAccAWSDBOptionGroup_OracleOptionsUpdate (40.64s)                          (************** See 3.)
--- PASS: TestAccAWSDBInstance_MinorVersion (422.23s)
--- PASS: TestAccAWSDBOptionGroup_multipleOptions (9.65s)
--- PASS: TestAccAWSDBOptionGroup_Option_OptionSettings_MultipleNonDefault (16.99s)
--- PASS: TestAccAWSDBOptionGroup_Tags (23.14s)
--- PASS: TestAccAWSDBOptionGroup_Tags_WithOptions (23.05s)
--- PASS: TestAccAWSDBInstance_SnapshotIdentifier_MultiAZ (1787.18s)
--- PASS: TestAccAWSDBInstance_CACertificateIdentifier (554.03s)                        (************** See 2.)
--- PASS: TestAccAWSDBInstance_EnabledCloudwatchLogsExports_Postgresql (495.88s)
--- PASS: TestAccAWSDBInstance_EnabledCloudwatchLogsExports_MSSQL (656.02s)
--- PASS: TestAccAWSDBInstance_NoDeleteAutomatedBackups (594.71s)
--- PASS: TestAccAWSDBInstance_EnabledCloudwatchLogsExports_MySQL (770.88s)
--- PASS: TestAccAWSDBInstance_EnabledCloudwatchLogsExports_Oracle (706.67s)
--- PASS: TestAccAWSDBOptionGroup_basicDestroyWithInstance (533.70s)
--- PASS: TestAccAWSDBInstance_MSSQL_TZ (1615.04s)
--- PASS: TestAccAWSDBInstance_MySQL_SnapshotRestoreWithEngineVersion (1766.50s)
--- PASS: TestAccAWSDBInstance_SnapshotIdentifier_MultiAZ_SQLServer (3738.62s)
--- FAIL: TestAccAWSDBInstance_MSSQL_DomainSnapshotRestore (4770.82s)                   (************** See 1.)
--- FAIL: TestAccAWSDBInstance_MSSQL_Domain (4980.84s)                                  (************** See 1.)

Output from acceptance testing (commercial) (no regressions, 1 flaky fail, 4 preexisting conditions):

--- PASS: TestProvider_impl (0.89s)
--- PASS: TestProvider (1.73s)
--- SKIP: TestAccAWSDbInstanceDataSource_ec2Classic (0.00s)
--- PASS: TestAccAWSProvider_Region_AwsChina (40.77s)
--- PASS: TestAccAWSProvider_Region_AwsGovCloudUs (41.77s)
--- PASS: TestAccAWSProvider_Region_AwsCommercial (41.85s)
--- FAIL: TestAccAWSDBInstance_DbSubnetGroupName_RamShared (2.34s)                      (************** See 4.)
--- PASS: TestAccAWSProvider_IgnoreTags_KeyPrefixes_One (49.12s)
--- PASS: TestAccAWSProvider_IgnoreTags_Keys_Multiple (51.61s)
--- PASS: TestAccAWSProvider_IgnoreTags_Keys_One (52.16s)
--- PASS: TestAccAWSProvider_Endpoints (52.32s)
--- PASS: TestAccAWSProvider_IgnoreTags_KeyPrefixes_None (52.52s)
--- PASS: TestAccAWSProvider_IgnoreTags_EmptyConfigurationBlock (52.75s)
--- PASS: TestAccAWSProvider_IgnoreTags_KeyPrefixes_Multiple (53.16s)
--- PASS: TestAccAWSProvider_IgnoreTags_Keys_None (54.12s)
--- PASS: TestAccAWSProvider_AssumeRole_Empty (57.21s)
--- PASS: TestAccAWSDBInstance_optionGroup (399.17s)
--- PASS: TestAccAWSDBInstance_kmsKey (402.14s)
--- PASS: TestAccAWSDBInstance_iamAuth (450.05s)
--- PASS: TestAccAWSDBInstance_generatedName (460.28s)
--- PASS: TestAccAWSDBInstance_DeletionProtection (431.92s)
--- PASS: TestAccAWSDBInstance_DbSubnetGroupName (454.49s)
--- FAIL: TestAccAWSDBInstance_ReplicateSourceDb_DbSubnetGroupName_RamShared (1.15s)    (************** See 4.)
--- PASS: TestAccAWSDBInstance_namePrefix (498.91s)
--- SKIP: TestAccAWSDBInstance_ReplicateSourceDb_DeletionProtection (0.00s)
--- PASS: TestAccAWSDBInstance_basic (501.81s)
--- PASS: TestAccAWSDBInstance_Password (463.42s)
--- PASS: TestAccAWSDBInstance_FinalSnapshotIdentifier_SkipFinalSnapshot (478.09s)
--- PASS: TestAccAWSDBInstance_DbSubnetGroupName_VpcSecurityGroupIds (502.43s)
--- PASS: TestAccAWSDBInstance_IsAlreadyBeingDeleted (557.76s)
--- PASS: TestAccAWSDBInstance_AllowMajorVersionUpgrade (622.69s)
--- PASS: TestAccAWSDBInstance_MaxAllocatedStorage (643.86s)
--- PASS: TestAccAWSDBInstance_subnetGroup (830.50s)
--- PASS: TestAccAWSDbInstanceDataSource_basic (853.77s)
--- PASS: TestAccAWSDBInstance_FinalSnapshotIdentifier (802.83s)
--- PASS: TestAccAWSDBInstance_ReplicateSourceDb (1408.33s)
--- PASS: TestAccAWSDBInstance_ReplicateSourceDb_AllowMajorVersionUpgrade (1464.04s)
--- FAIL: TestAccAWSDBInstance_S3Import (724.00s)                                       (************** See 5.)
--- PASS: TestAccAWSDBInstance_ReplicateSourceDb_AvailabilityZone (1227.38s)
--- PASS: TestAccAWSDBInstance_ReplicateSourceDb_AutoMinorVersionUpgrade (1445.40s)
--- PASS: TestAccAWSDBInstance_ReplicateSourceDb_BackupRetentionPeriod (1449.45s)
--- PASS: TestAccAWSDBInstance_ReplicateSourceDb_MaxAllocatedStorage (1387.07s)
--- PASS: TestAccAWSDBInstance_ReplicateSourceDb_IamDatabaseAuthenticationEnabled (1409.56s)
--- PASS: TestAccAWSDBInstance_ReplicateSourceDb_Monitoring (1418.95s)
--- PASS: TestAccAWSDBInstance_ReplicateSourceDb_Port (1293.02s)
--- FAIL: TestAccAWSDBInstance_SnapshotIdentifier_DbSubnetGroupName_RamShared (1.20s)   (************** See 4.)
--- PASS: TestAccAWSDBInstance_ReplicateSourceDb_AllocatedStorage (1910.96s)
--- PASS: TestAccAWSDBInstance_SnapshotIdentifier (1116.56s)
--- PASS: TestAccAWSDBInstance_ReplicateSourceDb_BackupWindow (1529.86s)
--- PASS: TestAccAWSDBInstance_ReplicateSourceDb_VpcSecurityGroupIds (1338.58s)
--- PASS: TestAccAWSDBInstance_ReplicateSourceDb_MaintenanceWindow (1550.73s)
--- PASS: TestAccAWSDBInstance_ReplicateSourceDb_CACertificateIdentifier (1369.73s)
--- PASS: TestAccAWSDBInstance_ReplicateSourceDb_ParameterGroupName (1762.40s)
--- PASS: TestAccAWSDBInstance_ReplicateSourceDb_MultiAZ (1954.61s)
--- PASS: TestAccAWSDBInstance_ReplicateSourceDb_DbSubnetGroupName_VpcSecurityGroupIds (2140.26s)
--- PASS: TestAccAWSDBInstance_ReplicateSourceDb_DbSubnetGroupName (2218.38s)
--- PASS: TestAccAWSDBInstance_SnapshotIdentifier_AutoMinorVersionUpgrade (1176.02s)
--- SKIP: TestAccAWSDBInstance_SnapshotIdentifier_Tags_Unset (0.00s)
--- PASS: TestAccAWSDBInstance_SnapshotIdentifier_AllocatedStorage (1479.96s)
--- PASS: TestAccAWSDBInstance_SnapshotIdentifier_IamDatabaseAuthenticationEnabled (1034.34s)
--- PASS: TestAccAWSDBInstance_SnapshotIdentifier_BackupWindow (1135.84s)
--- PASS: TestAccAWSDBInstance_SnapshotIdentifier_DbSubnetGroupName_VpcSecurityGroupIds (1105.74s)
--- PASS: TestAccAWSDBInstance_SnapshotIdentifier_DbSubnetGroupName (1115.88s)
--- PASS: TestAccAWSDBInstance_SnapshotIdentifier_Io1Storage (1559.96s)
--- PASS: TestAccAWSDBInstance_SnapshotIdentifier_BackupRetentionPeriod (1186.15s)
--- PASS: TestAccAWSDBInstance_SnapshotIdentifier_AvailabilityZone (1287.17s)
--- PASS: TestAccAWSDBInstance_SnapshotIdentifier_MaxAllocatedStorage (1144.67s)
--- PASS: TestAccAWSDBInstance_SnapshotIdentifier_Monitoring (1146.83s)
--- PASS: TestAccAWSDBInstance_SnapshotIdentifier_MaintenanceWindow (1226.45s)
--- PASS: TestAccAWSDBInstance_SnapshotIdentifier_DeletionProtection (1267.59s)
--- PASS: TestAccAWSDBInstance_SnapshotIdentifier_BackupRetentionPeriod_Unset (1528.81s)
--- SKIP: TestAccAWSDBInstance_ec2Classic (0.00s)
--- PASS: TestAccAWSDBInstance_portUpdate (549.77s)
--- PASS: TestAccAWSDBInstance_MonitoringRoleArn_RemovedToEnabled (613.25s)
--- PASS: TestAccAWSDBInstance_MinorVersion (488.76s)
--- PASS: TestAccAWSDBInstance_SnapshotIdentifier_ParameterGroupName (1255.18s)
--- PASS: TestAccAWSDBInstance_SnapshotIdentifier_Port (1144.84s)
--- PASS: TestAccAWSDBInstance_SnapshotIdentifier_AllowMajorVersionUpgrade (2224.43s)
--- PASS: TestAccAWSDBInstance_MonitoringRoleArn_EnabledToRemoved (757.82s)
--- PASS: TestAccAWSDBInstance_MonitoringRoleArn_EnabledToDisabled (777.77s)
--- PASS: TestAccAWSDBInstance_separateIopsUpdate (782.19s)
--- PASS: TestAccAWSDBInstance_MonitoringInterval (933.13s)
--- PASS: TestAccAWSDBInstance_SnapshotIdentifier_Tags (1266.21s)
--- PASS: TestAccAWSDBInstance_cloudwatchLogsExportConfiguration (575.42s)
--- PASS: TestAccAWSDBInstance_SnapshotIdentifier_VpcSecurityGroupIds (1247.73s)
--- PASS: TestAccAWSDBOptionGroup_basic (12.72s)
--- PASS: TestAccAWSDBOptionGroup_timeoutBlock (12.42s)
--- PASS: TestAccAWSDBOptionGroup_namePrefix (12.62s)
--- PASS: TestAccAWSDBOptionGroup_generatedName (13.86s)
--- PASS: TestAccAWSDBOptionGroupConfig_OptionGroupDescription (12.45s)
--- FAIL: TestAccAWSDBInstance_EnabledCloudwatchLogsExports_MySQL (543.23s)             (************** See 7.)
--- PASS: TestAccAWSDBOptionGroup_Option_OptionSettings (24.40s)
--- PASS: TestAccAWSDBInstance_SnapshotIdentifier_MultiAZ (2023.39s)
--- PASS: TestAccAWSDBOptionGroup_Option_OptionSettings_IAMRole (33.44s)
--- PASS: TestAccAWSDBInstance_SnapshotIdentifier_VpcSecurityGroupIds_Tags (1306.24s)
--- PASS: TestAccAWSDBOptionGroup_sqlServerOptionsUpdate (23.31s)
--- PASS: TestAccAWSDBOptionGroup_multipleOptions (15.62s)
--- PASS: TestAccAWSDBOptionGroup_OracleOptionsUpdate (32.48s)                          (************** See 3.)
--- PASS: TestAccAWSDBOptionGroup_Option_OptionSettings_MultipleNonDefault (28.42s)
--- PASS: TestAccAWSDBOptionGroup_Tags (41.22s)
--- PASS: TestAccAWSDBOptionGroup_Tags_WithOptions (41.48s)
--- PASS: TestAccAWSDBInstance_EnabledCloudwatchLogsExports_Postgresql (572.35s)
--- PASS: TestAccAWSDBInstance_CACertificateIdentifier (497.61s)                        (************** See 2.)
--- PASS: TestAccAWSDBInstance_NoDeleteAutomatedBackups (620.06s)
--- PASS: TestAccAWSDBInstance_EnabledCloudwatchLogsExports_MSSQL (813.21s)
--- PASS: TestAccAWSDBInstance_PerformanceInsightsEnabled_DisabledToEnabled (721.34s)
--- PASS: TestAccAWSDBInstance_EnabledCloudwatchLogsExports_Oracle (826.52s)
--- PASS: TestAccAWSDBOptionGroup_basicDestroyWithInstance (558.31s)
--- PASS: TestAccAWSDBInstance_PerformanceInsightsEnabled_EnabledToDisabled (900.09s)
--- PASS: TestAccAWSDBInstance_PerformanceInsightsRetentionPeriod (897.75s)
--- PASS: TestAccAWSDBInstance_MSSQL_TZ (1664.03s)
--- PASS: TestAccAWSDBInstance_PerformanceInsightsKmsKeyId (1091.60s)
--- PASS: TestAccAWSDBInstance_MySQL_SnapshotRestoreWithEngineVersion (1902.27s)
--- PASS: TestAccAWSDBInstance_SnapshotIdentifier_PerformanceInsightsEnabled (1488.92s)
--- PASS: TestAccAWSDBInstance_ReplicateSourceDb_PerformanceInsightsEnabled (1893.37s)
--- PASS: TestAccAWSDBInstance_SnapshotIdentifier_MultiAZ_SQLServer (3831.45s)
--- PASS: TestAccAWSDBInstance_MSSQL_DomainSnapshotRestore (3136.66s)
--- PASS: TestAccAWSDBInstance_MSSQL_Domain (3693.04s)
  1. (GovCloud only) Preexisting & unrelated, tracked in tests/provider: DB Instance Delete Timeout (GovCloud) #15775
  2. (GovCloud only) This PR partially fixes (fixed after TC run) (issue tests/provider: DB Instance CAC failure (GovCloud) #15772) (TestAccAWSDBInstance_ReplicateSourceDb_CACertificateIdentifier has new, unrelated issue on GovCloud; no regression in commercial)
  3. (GovCloud only) This PR fixes (fixed after TC run) (issue tests/provider: DB Instance InvalidParameterValue (GovCloud) #15770) (no regression in commercial)
  4. Preexisting & unrelated, tracked in tests/provider: DB Instance RAM share errors #15767
  5. Preexisting & unrelated, tracked in service/rds: S3 Import acctest failure #13391
  6. (GovCloud only) Preexisting & unrelated, tracked in tests/provider: DB Instance Max VPCs reached (GovCloud) #15777
  7. Appears flaky
  8. Preexisting & unrelated, tracked in Fix Hardcoded Region GovCloud Test Failures #15737 (see also Tech Debt: Replace Hardcoded Testing us-east-1 Provider Configurations With Aliased Provider Configuration #8316)

@YakDriver YakDriver requested a review from a team October 20, 2020 13:02
@ghost ghost added size/S Managed by automation to categorize the size of a PR. service/rds Issues and PRs that pertain to the rds service. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure. labels Oct 20, 2020
@YakDriver YakDriver added the partition/aws-us-gov Pertains to the aws-us-gov partition. label Oct 20, 2020
@YakDriver YakDriver mentioned this pull request Oct 20, 2020
Closed
69 tasks
@ghost ghost added size/M Managed by automation to categorize the size of a PR. and removed size/S Managed by automation to categorize the size of a PR. labels Oct 20, 2020
@YakDriver YakDriver mentioned this pull request Oct 20, 2020
Closed
48 tasks
This was referenced Oct 21, 2020
Closed
Closed
Closed
@YakDriver YakDriver mentioned this pull request Oct 21, 2020
Closed
@YakDriver YakDriver force-pushed the t-gov-hardarn-db branch 3 times, most recently from 2eb14b7 to b649300 Compare October 21, 2020 18:33
@YakDriver YakDriver mentioned this pull request Oct 21, 2020
Closed
bflad
bflad reviewed Oct 22, 2020
View reviewed changes
aws/provider_test.go Outdated Show resolved Hide resolved
@YakDriver YakDriver force-pushed the t-gov-hardarn-db branch 2 times, most recently from ab621fc to 821453e Compare October 22, 2020 19:28
@YakDriver
Copy link
Member Author

Commercial:

--- PASS: TestAccAWSDBInstance_CACertificateIdentifier (441.12s)
--- PASS: TestAccAWSRDSClusterInstance_CACertificateIdentifier (483.88s)
--- PASS: TestAccAWSDBInstance_ReplicateSourceDb_CACertificateIdentifier (1533.86s)

@YakDriver YakDriver mentioned this pull request Oct 27, 2020
Closed
@bflad bflad self-assigned this Oct 28, 2020
@ghost ghost added the documentation Introduces or discusses updates to documentation. label Oct 28, 2020
bflad
bflad approved these changes Oct 28, 2020
View reviewed changes
Copy link
Contributor

@bflad bflad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good 🚀

Output from acceptance testing in AWS Commercial:

--- PASS: TestAccAWSDBInstance_CACertificateIdentifier (459.03s)
--- PASS: TestAccAWSDBInstance_MonitoringInterval (1075.27s)
--- PASS: TestAccAWSDBInstance_MonitoringRoleArn_EnabledToDisabled (775.98s)
--- PASS: TestAccAWSDBInstance_MonitoringRoleArn_EnabledToRemoved (787.71s)
--- PASS: TestAccAWSDBInstance_MonitoringRoleArn_RemovedToEnabled (513.43s)
--- PASS: TestAccAWSDBInstance_ReplicateSourceDb_CACertificateIdentifier (1451.98s)
--- PASS: TestAccAWSDBInstance_ReplicateSourceDb_Monitoring (1461.24s)
--- PASS: TestAccAWSDBInstance_SnapshotIdentifier_Monitoring (1398.57s)

--- PASS: TestAccAWSDBOptionGroup_basic (50.56s)
--- PASS: TestAccAWSDBOptionGroup_basicDestroyWithInstance (586.37s)
--- PASS: TestAccAWSDBOptionGroup_generatedName (48.22s)
--- PASS: TestAccAWSDBOptionGroup_multipleOptions (47.64s)
--- PASS: TestAccAWSDBOptionGroup_namePrefix (50.90s)
--- PASS: TestAccAWSDBOptionGroup_Option_OptionSettings (73.19s)
--- PASS: TestAccAWSDBOptionGroup_Option_OptionSettings_IAMRole (65.71s)
--- PASS: TestAccAWSDBOptionGroup_Option_OptionSettings_MultipleNonDefault (72.71s)
--- PASS: TestAccAWSDBOptionGroup_OracleOptionsUpdate (72.68s)
--- PASS: TestAccAWSDBOptionGroup_sqlServerOptionsUpdate (70.31s)
--- PASS: TestAccAWSDBOptionGroup_Tags (45.41s)
--- PASS: TestAccAWSDBOptionGroup_Tags_WithOptions (45.18s)
--- PASS: TestAccAWSDBOptionGroup_timeoutBlock (49.17s)

--- PASS: TestAccAWSRDSClusterInstance_CACertificateIdentifier (617.30s)

Output from acceptance testing in AWS GovCloud (US):

--- PASS: TestAccAWSDBInstance_CACertificateIdentifier (534.04s)
--- PASS: TestAccAWSDBInstance_MonitoringInterval (1208.86s)
--- PASS: TestAccAWSDBInstance_MonitoringRoleArn_EnabledToDisabled (807.63s)
--- PASS: TestAccAWSDBInstance_MonitoringRoleArn_EnabledToRemoved (808.37s)
--- PASS: TestAccAWSDBInstance_MonitoringRoleArn_RemovedToEnabled (711.45s)
--- PASS: TestAccAWSDBInstance_ReplicateSourceDb_CACertificateIdentifier (1517.33s)
--- PASS: TestAccAWSDBInstance_ReplicateSourceDb_Monitoring (1579.70s)
--- PASS: TestAccAWSDBInstance_SnapshotIdentifier_Monitoring (1331.32s)

--- PASS: TestAccAWSDBOptionGroup_basic (26.82s)
--- PASS: TestAccAWSDBOptionGroup_basicDestroyWithInstance (536.04s)
--- PASS: TestAccAWSDBOptionGroup_generatedName (26.55s)
--- PASS: TestAccAWSDBOptionGroup_multipleOptions (23.07s)
--- PASS: TestAccAWSDBOptionGroup_namePrefix (26.60s)
--- PASS: TestAccAWSDBOptionGroup_Option_OptionSettings (47.33s)
--- PASS: TestAccAWSDBOptionGroup_Option_OptionSettings_IAMRole (38.00s)
--- PASS: TestAccAWSDBOptionGroup_Option_OptionSettings_MultipleNonDefault (44.27s)
--- PASS: TestAccAWSDBOptionGroup_OracleOptionsUpdate (48.95s)
--- PASS: TestAccAWSDBOptionGroup_sqlServerOptionsUpdate (43.52s)
--- PASS: TestAccAWSDBOptionGroup_Tags (59.45s)
--- PASS: TestAccAWSDBOptionGroup_Tags_WithOptions (59.94s)
--- PASS: TestAccAWSDBOptionGroup_timeoutBlock (26.70s)

--- PASS: TestAccAWSRDSClusterInstance_CACertificateIdentifier (727.13s)

@YakDriver YakDriver added this to the v3.13.0 milestone Oct 28, 2020
@YakDriver YakDriver merged commit 6df9963 into master Oct 28, 2020
@YakDriver YakDriver deleted the t-gov-hardarn-db branch October 28, 2020 14:11
@ghost
Copy link

ghost commented Oct 29, 2020

This has been released in version 3.13.0 of the Terraform AWS provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template for triage. Thanks!

@YakDriver YakDriver mentioned this pull request Nov 5, 2020
Closed
@ghost
Copy link

ghost commented Nov 27, 2020

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. Thanks!

@ghost ghost locked as resolved and limited conversation to collaborators Nov 27, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@bflad bflad bflad approved these changes

@gdavison gdavison Awaiting requested review from gdavison

Assignees

@bflad bflad

Labels
documentation Introduces or discusses updates to documentation. partition/aws-us-gov Pertains to the aws-us-gov partition. service/rds Issues and PRs that pertain to the rds service. size/M Managed by automation to categorize the size of a PR. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure.
Projects
None yet
Milestone
v3.13.0
4 participants
@YakDriver @bflad @gdavison @anGie44