resource/aws_datasync_task: Allow UNAVAILABLE as pending status during creation #15949
+107
−83
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bflad
added
tests
…g creation Reference: #15947 Especially for new EFS Mount Targets, the task can temporarily transition from CREATING to UNAVAILABLE (mount failures) then eventually it can transition to AVAILABLE. This also simplifies and updates the base testing configuration based on the current DataSync user guide. Previously: ``` === CONT TestAccAWSDataSyncTask_basic TestAccAWSDataSyncTask_basic: resource_aws_datasync_task_test.go:85: Step 1/2 error: Error running apply: Error: error waiting for DataSync Task (arn:aws:datasync:us-west-2:*******:task/task-0e819038fac1ebf6e) creation: waiting for DataSync Task (arn:aws:datasync:us-west-2:*******:task/task-0e819038fac1ebf6e) creation: last status (UNAVAILABLE), error code (MountFailure), error detail: Failed to connect to an NFS server on host fs-7c85ce79.efs.us-west-2.amazonaws.com. Ensure that your DataSync agent has a route to your NFS server and can make a TCP connection to port 2049. Please also ensure that the NFS service is running and listening on port 2049. After resolving any networking issues, retry your task. --- FAIL: TestAccAWSDataSyncTask_basic (252.60s) ``` Output from acceptance testing in AWS Commercial: ``` --- PASS: TestAccAWSDataSyncTask_basic (229.43s) --- PASS: TestAccAWSDataSyncTask_CloudWatchLogGroupARN (227.57s) --- PASS: TestAccAWSDataSyncTask_DefaultSyncOptions_AtimeMtime (348.45s) --- PASS: TestAccAWSDataSyncTask_DefaultSyncOptions_BytesPerSecond (266.03s) --- PASS: TestAccAWSDataSyncTask_DefaultSyncOptions_Gid (240.71s) --- PASS: TestAccAWSDataSyncTask_DefaultSyncOptions_PosixPermissions (287.10s) --- PASS: TestAccAWSDataSyncTask_DefaultSyncOptions_PreserveDeletedFiles (240.21s) --- PASS: TestAccAWSDataSyncTask_DefaultSyncOptions_PreserveDevices (349.08s) --- PASS: TestAccAWSDataSyncTask_DefaultSyncOptions_Uid (365.25s) --- PASS: TestAccAWSDataSyncTask_DefaultSyncOptions_VerifyMode (356.74s) --- PASS: TestAccAWSDataSyncTask_disappears (227.63s) ``` Output from acceptance testing in AWS GovCloud (US): ``` --- PASS: TestAccAWSDataSyncTask_basic (240.55s) --- PASS: TestAccAWSDataSyncTask_CloudWatchLogGroupARN (272.05s) --- PASS: TestAccAWSDataSyncTask_DefaultSyncOptions_AtimeMtime (276.25s) --- PASS: TestAccAWSDataSyncTask_DefaultSyncOptions_BytesPerSecond (289.87s) --- PASS: TestAccAWSDataSyncTask_DefaultSyncOptions_Gid (301.43s) --- PASS: TestAccAWSDataSyncTask_DefaultSyncOptions_PosixPermissions (286.56s) --- PASS: TestAccAWSDataSyncTask_DefaultSyncOptions_PreserveDeletedFiles (299.53s) --- PASS: TestAccAWSDataSyncTask_DefaultSyncOptions_PreserveDevices (300.01s) --- PASS: TestAccAWSDataSyncTask_DefaultSyncOptions_Uid (312.04s) --- PASS: TestAccAWSDataSyncTask_DefaultSyncOptions_VerifyMode (344.80s) --- PASS: TestAccAWSDataSyncTask_disappears (246.44s) ```
bflad
force-pushed
the
t-aws_datasync_task-creation-failures
branch
from
36875e4
to
ed60831
Compare
YakDriver
approved these changes
Nov 5, 2020
There was a problem hiding this comment.
Excellent! 💯
GovCloud:
--- PASS: TestAccAWSDataSyncTask_CloudWatchLogGroupARN (226.56s)
--- PASS: TestAccAWSDataSyncTask_basic (242.73s)
--- PASS: TestAccAWSDataSyncTask_disappears (246.49s)
--- PASS: TestAccAWSDataSyncTask_DefaultSyncOptions_PosixPermissions (282.88s)
--- PASS: TestAccAWSDataSyncTask_DefaultSyncOptions_PreserveDevices (289.45s)
--- PASS: TestAccAWSDataSyncTask_DefaultSyncOptions_Uid (293.89s)
--- PASS: TestAccAWSDataSyncTask_DefaultSyncOptions_BytesPerSecond (295.81s)
--- PASS: TestAccAWSDataSyncTask_DefaultSyncOptions_PreserveDeletedFiles (304.18s)
--- PASS: TestAccAWSDataSyncTask_DefaultSyncOptions_VerifyMode (326.30s)
--- PASS: TestAccAWSDataSyncTask_DefaultSyncOptions_AtimeMtime (332.50s)
--- PASS: TestAccAWSDataSyncTask_DefaultSyncOptions_Gid (338.98s)
Commercial:
--- PASS: TestAccAWSDataSyncTask_CloudWatchLogGroupARN (214.39s)
--- PASS: TestAccAWSDataSyncTask_disappears (237.83s)
--- PASS: TestAccAWSDataSyncTask_DefaultSyncOptions_AtimeMtime (262.28s)
--- PASS: TestAccAWSDataSyncTask_basic (278.96s)
--- PASS: TestAccAWSDataSyncTask_DefaultSyncOptions_PreserveDevices (284.82s)
--- PASS: TestAccAWSDataSyncTask_DefaultSyncOptions_Uid (294.30s)
--- PASS: TestAccAWSDataSyncTask_DefaultSyncOptions_Gid (301.17s)
--- PASS: TestAccAWSDataSyncTask_DefaultSyncOptions_PreserveDeletedFiles (304.21s)
--- PASS: TestAccAWSDataSyncTask_DefaultSyncOptions_VerifyMode (310.87s)
--- PASS: TestAccAWSDataSyncTask_DefaultSyncOptions_BytesPerSecond (319.39s)
--- PASS: TestAccAWSDataSyncTask_DefaultSyncOptions_PosixPermissions (329.10s)
|
This has been released in version 3.14.0 of the Terraform AWS provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading. For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template for triage. Thanks! |
|
I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. Thanks! |
ghost
locked as resolved and limited conversation to collaborators
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Community Note
Closes #15947
Release note for CHANGELOG:
Especially for new EFS Mount Targets, the task can temporarily transition from CREATING to UNAVAILABLE (mount failures) then eventually it can transition to AVAILABLE. This also simplifies and updates the base testing configuration based on the current DataSync user guide.
Previously:
Output from acceptance testing in AWS Commercial:
Output from acceptance testing in AWS GovCloud (US):