Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

tests/resource/aws_datasync_location_smb: Regular HTTP failures #15950

Closed
bflad opened this issue Oct 31, 2020 · 2 comments · Fixed by #15951
Closed

tests/resource/aws_datasync_location_smb: Regular HTTP failures #15950

bflad opened this issue Oct 31, 2020 · 2 comments · Fixed by #15951
Assignees
@bflad
Labels
service/datasync Issues and PRs that pertain to the datasync service. technical-debt Addresses areas of the codebase that need refactoring or redesign. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure.
Milestone
v3.15.0

Comments

@bflad
Copy link
Contributor

bflad commented Oct 31, 2020

Community Note

  • Please vote on this issue by adding a 👍 reaction to the original issue to help the community and maintainers prioritize this request
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for issue followers and do not help prioritize the request
  • If you are interested in working on this issue or have submitted a pull request, please leave a comment

Description

The TestAccAWSDataSyncLocationSmb_ tests are regularly failing with errors like these:

=== CONT  TestAccAWSDataSyncLocationSmb_basic
TestAccAWSDataSyncLocationSmb_basic: resource_aws_datasync_location_smb_test.go:87: Step 1/2 error: Error running apply: 2020/10/30 21:12:22 [DEBUG] Using modified User-Agent: Terraform/0.12.29 HashiCorp-terraform-exec/0.10.0
Error: error retrieving activation key from IP Address (52.43.34.79): error making HTTP request: Get "http://52.43.34.79/?activationRegion=us-west-2": context deadline exceeded (Client.Timeout exceeded while awaiting headers)
--- FAIL: TestAccAWSDataSyncLocationSmb_basic (698.97s)

=== CONT  TestAccAWSDataSyncLocationSmb_disappears
TestAccAWSDataSyncLocationSmb_disappears: resource_aws_datasync_location_smb_test.go:120: Step 1/1 error: Error running apply: 2020/10/30 21:13:15 [DEBUG] Using modified User-Agent: Terraform/0.12.29 HashiCorp-terraform-exec/0.10.0
Error: error retrieving activation key from IP Address (52.12.135.60): error making HTTP request: Get "http://52.12.135.60/?activationRegion=us-west-2": context deadline exceeded (Client.Timeout exceeded while awaiting headers)
--- FAIL: TestAccAWSDataSyncLocationSmb_disappears (696.98s)

=== CONT  TestAccAWSDataSyncLocationSmb_Tags
TestAccAWSDataSyncLocationSmb_Tags: resource_aws_datasync_location_smb_test.go:141: Step 1/4 error: Error running apply: 2020/10/30 21:13:23 [DEBUG] Using modified User-Agent: Terraform/0.12.29 HashiCorp-terraform-exec/0.10.0
Error: error retrieving activation key from IP Address (52.41.144.141): error making HTTP request: Get "http://52.41.144.141/?activationRegion=us-west-2": context deadline exceeded (Client.Timeout exceeded while awaiting headers)
--- FAIL: TestAccAWSDataSyncLocationSmb_Tags (697.96s)

=== CONT  TestAccAWSDataSyncLocationSmb_Tags
TestAccAWSDataSyncLocationSmb_Tags: resource_aws_datasync_location_smb_test.go:141: Step 1/4 error: Error running apply:
Error: expected HTTP status code 302, received: 500
--- FAIL: TestAccAWSDataSyncLocationSmb_Tags (330.19s)

=== CONT  TestAccAWSDataSyncLocationSmb_basic
TestAccAWSDataSyncLocationSmb_basic: resource_aws_datasync_location_smb_test.go:87: Step 1/2 error: Error running apply:
Error: expected HTTP status code 302, received: 500
--- FAIL: TestAccAWSDataSyncLocationSmb_basic (522.60s)

=== CONT  TestAccAWSDataSyncLocationSmb_disappears
TestAccAWSDataSyncLocationSmb_disappears: resource_aws_datasync_location_smb_test.go:120: Step 1/1 error: Error running apply:
Error: expected HTTP status code 302, received: 500
--- FAIL: TestAccAWSDataSyncLocationSmb_disappears (513.09s)

For the 500 HTTP status, I believe we added retries for the similar mechanism built into Storage Gateway. For the timeouts, there's likely some potential updates we can do to the test configurations, similar to #15949.

Affected Resource(s)

  • aws_datasync_location_smb
@bflad bflad added tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure. technical-debt Addresses areas of the codebase that need refactoring or redesign. service/datasync Issues and PRs that pertain to the datasync service. labels Oct 31, 2020
@bflad bflad self-assigned this Oct 31, 2020
bflad added a commit that referenced this issue Oct 31, 2020
@bflad
tests/resource/aws_datasync_location_smb: Simplify and update base co…
796244c 
…nfiguration

Reference: #15950

DataSync SMB Locations do not need a valid SMB endpoint to be created, so we remove the extra configuration which was problematic due to Storage Gateway.

Previously:

```
=== CONT  TestAccAWSDataSyncLocationSmb_basic
TestAccAWSDataSyncLocationSmb_basic: resource_aws_datasync_location_smb_test.go:87: Step 1/2 error: Error running apply: 2020/10/30 21:12:22 [DEBUG] Using modified User-Agent: Terraform/0.12.29 HashiCorp-terraform-exec/0.10.0
Error: error retrieving activation key from IP Address (52.43.34.79): error making HTTP request: Get "http://52.43.34.79/?activationRegion=us-west-2": context deadline exceeded (Client.Timeout exceeded while awaiting headers)
--- FAIL: TestAccAWSDataSyncLocationSmb_basic (698.97s)

=== CONT  TestAccAWSDataSyncLocationSmb_disappears
TestAccAWSDataSyncLocationSmb_disappears: resource_aws_datasync_location_smb_test.go:120: Step 1/1 error: Error running apply: 2020/10/30 21:13:15 [DEBUG] Using modified User-Agent: Terraform/0.12.29 HashiCorp-terraform-exec/0.10.0
Error: error retrieving activation key from IP Address (52.12.135.60): error making HTTP request: Get "http://52.12.135.60/?activationRegion=us-west-2": context deadline exceeded (Client.Timeout exceeded while awaiting headers)
--- FAIL: TestAccAWSDataSyncLocationSmb_disappears (696.98s)

=== CONT  TestAccAWSDataSyncLocationSmb_Tags
TestAccAWSDataSyncLocationSmb_Tags: resource_aws_datasync_location_smb_test.go:141: Step 1/4 error: Error running apply: 2020/10/30 21:13:23 [DEBUG] Using modified User-Agent: Terraform/0.12.29 HashiCorp-terraform-exec/0.10.0
Error: error retrieving activation key from IP Address (52.41.144.141): error making HTTP request: Get "http://52.41.144.141/?activationRegion=us-west-2": context deadline exceeded (Client.Timeout exceeded while awaiting headers)
--- FAIL: TestAccAWSDataSyncLocationSmb_Tags (697.96s)

=== CONT  TestAccAWSDataSyncLocationSmb_Tags
TestAccAWSDataSyncLocationSmb_Tags: resource_aws_datasync_location_smb_test.go:141: Step 1/4 error: Error running apply:
Error: expected HTTP status code 302, received: 500
--- FAIL: TestAccAWSDataSyncLocationSmb_Tags (330.19s)

=== CONT  TestAccAWSDataSyncLocationSmb_basic
TestAccAWSDataSyncLocationSmb_basic: resource_aws_datasync_location_smb_test.go:87: Step 1/2 error: Error running apply:
Error: expected HTTP status code 302, received: 500
--- FAIL: TestAccAWSDataSyncLocationSmb_basic (522.60s)

=== CONT  TestAccAWSDataSyncLocationSmb_disappears
TestAccAWSDataSyncLocationSmb_disappears: resource_aws_datasync_location_smb_test.go:120: Step 1/1 error: Error running apply:
Error: expected HTTP status code 302, received: 500
--- FAIL: TestAccAWSDataSyncLocationSmb_disappears (513.09s)
```

Output from acceptance testing in AWS Commercial:

```
--- PASS: TestAccAWSDataSyncLocationSmb_basic (166.60s)
--- PASS: TestAccAWSDataSyncLocationSmb_disappears (187.80s)
--- PASS: TestAccAWSDataSyncLocationSmb_Tags (211.25s)
```

Output from acceptance testing in AWS GovCloud (US):

```
--- PASS: TestAccAWSDataSyncLocationSmb_disappears (162.12s)
--- PASS: TestAccAWSDataSyncLocationSmb_basic (184.29s)
--- PASS: TestAccAWSDataSyncLocationSmb_Tags (235.60s)
```
@bflad bflad mentioned this issue Oct 31, 2020
Merged
bflad added a commit that referenced this issue Nov 10, 2020
@bflad
tests/resource/aws_datasync_location_smb: Simplify and update base co…
6fbb86e 
…nfiguration

Reference: #15950

DataSync SMB Locations do not need a valid SMB endpoint to be created, so we remove the extra configuration which was problematic due to Storage Gateway.

Previously:

```
=== CONT  TestAccAWSDataSyncLocationSmb_basic
TestAccAWSDataSyncLocationSmb_basic: resource_aws_datasync_location_smb_test.go:87: Step 1/2 error: Error running apply: 2020/10/30 21:12:22 [DEBUG] Using modified User-Agent: Terraform/0.12.29 HashiCorp-terraform-exec/0.10.0
Error: error retrieving activation key from IP Address (52.43.34.79): error making HTTP request: Get "http://52.43.34.79/?activationRegion=us-west-2": context deadline exceeded (Client.Timeout exceeded while awaiting headers)
--- FAIL: TestAccAWSDataSyncLocationSmb_basic (698.97s)

=== CONT  TestAccAWSDataSyncLocationSmb_disappears
TestAccAWSDataSyncLocationSmb_disappears: resource_aws_datasync_location_smb_test.go:120: Step 1/1 error: Error running apply: 2020/10/30 21:13:15 [DEBUG] Using modified User-Agent: Terraform/0.12.29 HashiCorp-terraform-exec/0.10.0
Error: error retrieving activation key from IP Address (52.12.135.60): error making HTTP request: Get "http://52.12.135.60/?activationRegion=us-west-2": context deadline exceeded (Client.Timeout exceeded while awaiting headers)
--- FAIL: TestAccAWSDataSyncLocationSmb_disappears (696.98s)

=== CONT  TestAccAWSDataSyncLocationSmb_Tags
TestAccAWSDataSyncLocationSmb_Tags: resource_aws_datasync_location_smb_test.go:141: Step 1/4 error: Error running apply: 2020/10/30 21:13:23 [DEBUG] Using modified User-Agent: Terraform/0.12.29 HashiCorp-terraform-exec/0.10.0
Error: error retrieving activation key from IP Address (52.41.144.141): error making HTTP request: Get "http://52.41.144.141/?activationRegion=us-west-2": context deadline exceeded (Client.Timeout exceeded while awaiting headers)
--- FAIL: TestAccAWSDataSyncLocationSmb_Tags (697.96s)

=== CONT  TestAccAWSDataSyncLocationSmb_Tags
TestAccAWSDataSyncLocationSmb_Tags: resource_aws_datasync_location_smb_test.go:141: Step 1/4 error: Error running apply:
Error: expected HTTP status code 302, received: 500
--- FAIL: TestAccAWSDataSyncLocationSmb_Tags (330.19s)

=== CONT  TestAccAWSDataSyncLocationSmb_basic
TestAccAWSDataSyncLocationSmb_basic: resource_aws_datasync_location_smb_test.go:87: Step 1/2 error: Error running apply:
Error: expected HTTP status code 302, received: 500
--- FAIL: TestAccAWSDataSyncLocationSmb_basic (522.60s)

=== CONT  TestAccAWSDataSyncLocationSmb_disappears
TestAccAWSDataSyncLocationSmb_disappears: resource_aws_datasync_location_smb_test.go:120: Step 1/1 error: Error running apply:
Error: expected HTTP status code 302, received: 500
--- FAIL: TestAccAWSDataSyncLocationSmb_disappears (513.09s)
```

Output from acceptance testing in AWS Commercial:

```
--- PASS: TestAccAWSDataSyncLocationSmb_basic (166.60s)
--- PASS: TestAccAWSDataSyncLocationSmb_disappears (187.80s)
--- PASS: TestAccAWSDataSyncLocationSmb_Tags (211.25s)
```

Output from acceptance testing in AWS GovCloud (US):

```
--- PASS: TestAccAWSDataSyncLocationSmb_disappears (162.12s)
--- PASS: TestAccAWSDataSyncLocationSmb_basic (184.29s)
--- PASS: TestAccAWSDataSyncLocationSmb_Tags (235.60s)
```
bflad added a commit that referenced this issue Nov 11, 2020
@bflad
tests/resource/aws_datasync_location_smb: Simplify and update base co…
e8806c7 
…nfiguration (#15951)

Reference: #15950

DataSync SMB Locations do not need a valid SMB endpoint to be created, so we remove the extra configuration which was problematic due to Storage Gateway.

Previously:

```
=== CONT  TestAccAWSDataSyncLocationSmb_basic
TestAccAWSDataSyncLocationSmb_basic: resource_aws_datasync_location_smb_test.go:87: Step 1/2 error: Error running apply: 2020/10/30 21:12:22 [DEBUG] Using modified User-Agent: Terraform/0.12.29 HashiCorp-terraform-exec/0.10.0
Error: error retrieving activation key from IP Address (52.43.34.79): error making HTTP request: Get "http://52.43.34.79/?activationRegion=us-west-2": context deadline exceeded (Client.Timeout exceeded while awaiting headers)
--- FAIL: TestAccAWSDataSyncLocationSmb_basic (698.97s)

=== CONT  TestAccAWSDataSyncLocationSmb_disappears
TestAccAWSDataSyncLocationSmb_disappears: resource_aws_datasync_location_smb_test.go:120: Step 1/1 error: Error running apply: 2020/10/30 21:13:15 [DEBUG] Using modified User-Agent: Terraform/0.12.29 HashiCorp-terraform-exec/0.10.0
Error: error retrieving activation key from IP Address (52.12.135.60): error making HTTP request: Get "http://52.12.135.60/?activationRegion=us-west-2": context deadline exceeded (Client.Timeout exceeded while awaiting headers)
--- FAIL: TestAccAWSDataSyncLocationSmb_disappears (696.98s)

=== CONT  TestAccAWSDataSyncLocationSmb_Tags
TestAccAWSDataSyncLocationSmb_Tags: resource_aws_datasync_location_smb_test.go:141: Step 1/4 error: Error running apply: 2020/10/30 21:13:23 [DEBUG] Using modified User-Agent: Terraform/0.12.29 HashiCorp-terraform-exec/0.10.0
Error: error retrieving activation key from IP Address (52.41.144.141): error making HTTP request: Get "http://52.41.144.141/?activationRegion=us-west-2": context deadline exceeded (Client.Timeout exceeded while awaiting headers)
--- FAIL: TestAccAWSDataSyncLocationSmb_Tags (697.96s)

=== CONT  TestAccAWSDataSyncLocationSmb_Tags
TestAccAWSDataSyncLocationSmb_Tags: resource_aws_datasync_location_smb_test.go:141: Step 1/4 error: Error running apply:
Error: expected HTTP status code 302, received: 500
--- FAIL: TestAccAWSDataSyncLocationSmb_Tags (330.19s)

=== CONT  TestAccAWSDataSyncLocationSmb_basic
TestAccAWSDataSyncLocationSmb_basic: resource_aws_datasync_location_smb_test.go:87: Step 1/2 error: Error running apply:
Error: expected HTTP status code 302, received: 500
--- FAIL: TestAccAWSDataSyncLocationSmb_basic (522.60s)

=== CONT  TestAccAWSDataSyncLocationSmb_disappears
TestAccAWSDataSyncLocationSmb_disappears: resource_aws_datasync_location_smb_test.go:120: Step 1/1 error: Error running apply:
Error: expected HTTP status code 302, received: 500
--- FAIL: TestAccAWSDataSyncLocationSmb_disappears (513.09s)
```

Output from acceptance testing in AWS Commercial:

```
--- PASS: TestAccAWSDataSyncLocationSmb_basic (166.60s)
--- PASS: TestAccAWSDataSyncLocationSmb_disappears (187.80s)
--- PASS: TestAccAWSDataSyncLocationSmb_Tags (211.25s)
```

Output from acceptance testing in AWS GovCloud (US):

```
--- PASS: TestAccAWSDataSyncLocationSmb_disappears (162.12s)
--- PASS: TestAccAWSDataSyncLocationSmb_basic (184.29s)
--- PASS: TestAccAWSDataSyncLocationSmb_Tags (235.60s)
```
@bflad bflad added this to the v3.15.0 milestone Nov 11, 2020
@ghost
Copy link

ghost commented Nov 12, 2020

This has been released in version 3.15.0 of the Terraform AWS provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template for triage. Thanks!

@ghost
Copy link

ghost commented Dec 11, 2020

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. Thanks!

@ghost ghost locked as resolved and limited conversation to collaborators Dec 11, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@bflad bflad

Labels
service/datasync Issues and PRs that pertain to the datasync service. technical-debt Addresses areas of the codebase that need refactoring or redesign. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure.
Projects
None yet
Milestone
v3.15.0
1 participant
@bflad