-
Notifications
You must be signed in to change notification settings - Fork 9.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support for network load balancer #1618
Comments
👍 |
+1 |
The ability to build a load-balancer from a number of EIP's is particularly interesting for services where moving to another IP-address causes huge operational headaches. |
I had a feeling this was going to be requested right away. NLB is amazing for supporting a static IP load balanced layer. Definitely looking forward to terraform support. |
Reading over the docs looks like pretty much all the ALB stuff can be copied over and just renamed. Only need to add support for EIP and change the protocol options to TCP only on the target group. I will try to take a stab at this over the weekend but I have no idea how far I will make it. |
I wondered whether this might be the case. I also wondered whether it might be an idea to support both types with one code base, ie. have a |
I thought about that as well, but I think if we go that route would have to rename all the alb resources to something more generic and I'm not sure on the policy of breaking changes. I am in favor of just creating new resource type for nlb just in case they diverge more in the future but thats just my thoughts. |
BTW @stack72 recently tweeted that he was looking at this. |
+1 |
Fixes: hashicorp#1618 In terraform, we had the idea of an alb. In AWS this doesn't exist. ALBs are actually Load balancers of type `application` Therefore, the first part of this PR adds a new parameter to ALBs called `load_balancer_type`. We default this to `application` to follow the same idea as the current behaviour The next part of the PR will then change the idea of an alb -> lb In order to preserve backwards compatibility, we have added another resource name to the same schema type. This means we effectively have an alias of aws_alb and aws_lb. This includes updating *all* of the tests to make sure and remove the idea of ALB and rename to LB and then we will add a check to make sure we can still check that an ALB can be created in the old resource
Excited to see this merged! Do we have an estimate of when a new release will be cut? |
+++1 Looking to leverage nlb for multiple service offerings and this issue is blocking the adoption of terraform. |
@ben-ms But it's not blocking anymore, it's merged and released. |
@ben-ms It was released in v1.1.0 of the aws provider: https://github.com/terraform-providers/terraform-provider-aws/blob/master/CHANGELOG.md#110-october-16-2017 |
The online documentation doesn't mention it anywhere as far as I could find. It would also be nice if the documentation showed what version a new feature like this was added so that we can determine whether or not we need to upgrade. |
It will be really useful to have something like |
@robomon1 It's here: https://www.terraform.io/docs/providers/aws/r/lb.html With "load_balancer_type" = "network" or "application". I was able to get this working. The listeners must support HTTP(s). |
A basic example of a working tcp NLB, in case someone stumbles upon this thread:
|
I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. Thanks! |
AWS recently announced a new load balancer: the network load balancer
https://aws.amazon.com/blogs/aws/new-network-load-balancer-effortless-scaling-to-millions-of-requests-per-second/
Would be good to get support for this into this provider
The text was updated successfully, but these errors were encountered: