resource/aws_spot_instance_request: incorrectly reuses resource definition of aws_instance

[gdavison]

The implementation of aws_spot_instance_request copies and modifies the resource definition of aws_instance. This results in a number of unsupported arguments existing on the resource but having no effect, including metadata_options.

The documentation also states that

Spot Instance Requests support all the same arguments as aws_instance, with the addition of…

which is not correct.

aws_spot_instance_request should be a stand-alone resource.

Affected Resource

• aws_spot_instance_request

[bflad]

Related in a good way to #16145

[github-actions]

Marking this issue as stale due to inactivity. This helps our maintainers find and focus on the active issues. If this issue receives no comments in the next 30 days it will automatically be closed. Maintainers can also remove the stale label.

If this issue was automatically closed and you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. Thank you!

[github-actions]

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems similar to this, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.