Add Linter to Avoid Cross Resource Function References

[bflad]

Community Note

• Please vote on this issue by adding a 👍 reaction to the original issue to help the community and maintainers prioritize this request
• Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for issue followers and do not help prioritize the request
• If you are interested in working on this issue or have submitted a pull request, please leave a comment

Description

Similar to how we prefer each resource to self-contain its schema, each resource should have self-contained Create, Read, Update, and Delete functions. This is to prevent regressions and other unexpected bugs introduced by cross-referencing these functions. For example, the aws_default_route_table currently has the following cross-references:

• Create -> resourceAwsDefaultRouteTableCreate -> resourceAwsRouteTableUpdate (see also awsproviderlint: New Check: Avoid resource.*Update$ calls #12998)
• Read -> resourceAwsDefaultRouteTableRead -> resourceAwsRouteTableRead
• Update -> resourceAwsRouteTableUpdate

Introducing new attributes in the aws_route_table resource can break aws_default_route_table resource functionality and the potential code duplication is preferred in these cases.

Affected Resource(s)

• aws_default_route_table
• aws_spot_instance_request (resource/aws_spot_instance_request: incorrectly reuses resource definition of aws_instance #16189)
• TBD

References

• New Check: Avoid resource.*Update$ calls

[github-actions]

Marking this issue as stale due to inactivity. This helps our maintainers find and focus on the active issues. If this issue receives no comments in the next 30 days it will automatically be closed. Maintainers can also remove the stale label.

If this issue was automatically closed and you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. Thank you!

[github-actions]

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems similar to this, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.