Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Linter to Avoid Resource Function References in Data Sources #18819

Closed
6 tasks done
anGie44 opened this issue Apr 13, 2021 · 2 comments · Fixed by #18821
Closed
6 tasks done

Add Linter to Avoid Resource Function References in Data Sources #18819

anGie44 opened this issue Apr 13, 2021 · 2 comments · Fixed by #18821
Assignees
Labels
enhancement Requests to existing resources that expand the functionality or scope. linter Pertains to changes to or issues with the various linters. service/dynamodb Issues and PRs that pertain to the dynamodb service. service/elb Issues and PRs that pertain to the elb service. service/iam Issues and PRs that pertain to the iam service. service/mq Issues and PRs that pertain to the mq service.
Milestone

Comments

@anGie44
Copy link
Contributor

anGie44 commented Apr 13, 2021

Community Note

  • Please vote on this issue by adding a 👍 reaction to the original issue to help the community and maintainers prioritize this request
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for issue followers and do not help prioritize the request
  • If you are interested in working on this issue or have submitted a pull request, please leave a comment

New or Existing Data Source(s)

  • aws_(a)lb*
  • aws_cur_report_definition
  • aws_dynamodb_table
  • aws_elb
  • aws_iam_policy
  • aws_mq_broker

Description

Similar to #16145, we prefer to keep resource Read functions self-contained such that data sources implement their own Read functionality to prevent regressions e.g. when new attributes are not present in the data source schema. In addition, separate Read in data sources enables support for #7926 as we're introducing new behavior to tags* that is only meant for managed resources.

References

Definition of Done

  • enable new linter check/rule once warning reports are managed
@anGie44 anGie44 added enhancement Requests to existing resources that expand the functionality or scope. linter Pertains to changes to or issues with the various linters. labels Apr 13, 2021
@ghost ghost added service/iam Issues and PRs that pertain to the iam service. service/mq Issues and PRs that pertain to the mq service. labels Apr 13, 2021
@ghost ghost added the service/elb Issues and PRs that pertain to the elb service. label Apr 13, 2021
@ghost ghost added the service/dynamodb Issues and PRs that pertain to the dynamodb service. label Apr 13, 2021
@anGie44 anGie44 self-assigned this Apr 13, 2021
@anGie44 anGie44 added this to the v3.37.0 milestone Apr 15, 2021
@ghost
Copy link

ghost commented Apr 16, 2021

This has been released in version 3.37.0 of the Terraform AWS provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template for triage. Thanks!

@ghost
Copy link

ghost commented May 16, 2021

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. Thanks!

@ghost ghost locked as resolved and limited conversation to collaborators May 16, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
enhancement Requests to existing resources that expand the functionality or scope. linter Pertains to changes to or issues with the various linters. service/dynamodb Issues and PRs that pertain to the dynamodb service. service/elb Issues and PRs that pertain to the elb service. service/iam Issues and PRs that pertain to the iam service. service/mq Issues and PRs that pertain to the mq service.
Projects
None yet
1 participant