Add Linter to Avoid Resource Function References in Data Sources

[anGie44]

Community Note

• Please vote on this issue by adding a 👍 reaction to the original issue to help the community and maintainers prioritize this request
• Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for issue followers and do not help prioritize the request
• If you are interested in working on this issue or have submitted a pull request, please leave a comment

New or Existing Data Source(s)

• aws_(a)lb*
• aws_cur_report_definition
• aws_dynamodb_table
• aws_elb
• aws_iam_policy
• aws_mq_broker

Description

Similar to #16145, we prefer to keep resource Read functions self-contained such that data sources implement their own Read functionality to prevent regressions e.g. when new attributes are not present in the data source schema. In addition, separate Read in data sources enables support for #7926 as we're introducing new behavior to tags* that is only meant for managed resources.

References

• Add Linter to Avoid Cross Resource Function References #16145

Definition of Done

• enable new linter check/rule once warning reports are managed

[ghost]

This has been released in version 3.37.0 of the Terraform AWS provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template for triage. Thanks!

[ghost]

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. Thanks!