-
Notifications
You must be signed in to change notification settings - Fork 9.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
resource/aws_datasync_task: Add excludes
argument, missing options
arguments
#16204
Conversation
21fb723
to
67bbea4
Compare
excludes
argument, missing options
argumentsexcludes
argument, missing options
arguments
6bbed8e
to
23f1f86
Compare
These are very useful updates, especially automation is not done, without the support for scheduling. Thanks for doing these! |
How soon before this PR will get merged? Trying to use datasync with terraform but the datasync task never logs anything to the logging group since there is no support for log_level until this is merged. |
Any update on when this may be merged? |
Great update. Need it :) |
allow updating `cloudwatch_log_group_arn` add arn validation for `cloudwatch_log_group_arn`, `source_location_arn`, `destination_location_arn`
23f1f86
to
665674b
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 🚀.
Commercial
% make testacc TEST=./aws TESTARGS='-run=TestAccAWSDataSyncTask_'
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./aws -v -count 1 -parallel 20 -run=TestAccAWSDataSyncTask_ -timeout 180m
=== RUN TestAccAWSDataSyncTask_basic
=== PAUSE TestAccAWSDataSyncTask_basic
=== RUN TestAccAWSDataSyncTask_disappears
=== PAUSE TestAccAWSDataSyncTask_disappears
=== RUN TestAccAWSDataSyncTask_schedule
=== PAUSE TestAccAWSDataSyncTask_schedule
=== RUN TestAccAWSDataSyncTask_CloudWatchLogGroupARN
=== PAUSE TestAccAWSDataSyncTask_CloudWatchLogGroupARN
=== RUN TestAccAWSDataSyncTask_Excludes
=== PAUSE TestAccAWSDataSyncTask_Excludes
=== RUN TestAccAWSDataSyncTask_DefaultSyncOptions_AtimeMtime
=== PAUSE TestAccAWSDataSyncTask_DefaultSyncOptions_AtimeMtime
=== RUN TestAccAWSDataSyncTask_DefaultSyncOptions_BytesPerSecond
=== PAUSE TestAccAWSDataSyncTask_DefaultSyncOptions_BytesPerSecond
=== RUN TestAccAWSDataSyncTask_DefaultSyncOptions_Gid
=== PAUSE TestAccAWSDataSyncTask_DefaultSyncOptions_Gid
=== RUN TestAccAWSDataSyncTask_DefaultSyncOptions_LogLevel
=== PAUSE TestAccAWSDataSyncTask_DefaultSyncOptions_LogLevel
=== RUN TestAccAWSDataSyncTask_DefaultSyncOptions_OverwriteMode
=== PAUSE TestAccAWSDataSyncTask_DefaultSyncOptions_OverwriteMode
=== RUN TestAccAWSDataSyncTask_DefaultSyncOptions_PosixPermissions
=== PAUSE TestAccAWSDataSyncTask_DefaultSyncOptions_PosixPermissions
=== RUN TestAccAWSDataSyncTask_DefaultSyncOptions_PreserveDeletedFiles
=== PAUSE TestAccAWSDataSyncTask_DefaultSyncOptions_PreserveDeletedFiles
=== RUN TestAccAWSDataSyncTask_DefaultSyncOptions_PreserveDevices
=== PAUSE TestAccAWSDataSyncTask_DefaultSyncOptions_PreserveDevices
=== RUN TestAccAWSDataSyncTask_DefaultSyncOptions_TaskQueueing
=== PAUSE TestAccAWSDataSyncTask_DefaultSyncOptions_TaskQueueing
=== RUN TestAccAWSDataSyncTask_DefaultSyncOptions_TransferMode
=== PAUSE TestAccAWSDataSyncTask_DefaultSyncOptions_TransferMode
=== RUN TestAccAWSDataSyncTask_DefaultSyncOptions_Uid
=== PAUSE TestAccAWSDataSyncTask_DefaultSyncOptions_Uid
=== RUN TestAccAWSDataSyncTask_DefaultSyncOptions_VerifyMode
=== PAUSE TestAccAWSDataSyncTask_DefaultSyncOptions_VerifyMode
=== RUN TestAccAWSDataSyncTask_Tags
provider_test.go:55: Tagging on creation is inconsistent
--- SKIP: TestAccAWSDataSyncTask_Tags (0.00s)
=== CONT TestAccAWSDataSyncTask_basic
=== CONT TestAccAWSDataSyncTask_DefaultSyncOptions_OverwriteMode
=== CONT TestAccAWSDataSyncTask_DefaultSyncOptions_TaskQueueing
=== CONT TestAccAWSDataSyncTask_DefaultSyncOptions_TransferMode
=== CONT TestAccAWSDataSyncTask_DefaultSyncOptions_AtimeMtime
=== CONT TestAccAWSDataSyncTask_DefaultSyncOptions_LogLevel
=== CONT TestAccAWSDataSyncTask_DefaultSyncOptions_Gid
=== CONT TestAccAWSDataSyncTask_DefaultSyncOptions_PosixPermissions
=== CONT TestAccAWSDataSyncTask_DefaultSyncOptions_BytesPerSecond
=== CONT TestAccAWSDataSyncTask_DefaultSyncOptions_PreserveDevices
=== CONT TestAccAWSDataSyncTask_CloudWatchLogGroupARN
=== CONT TestAccAWSDataSyncTask_DefaultSyncOptions_PreserveDeletedFiles
=== CONT TestAccAWSDataSyncTask_Excludes
=== CONT TestAccAWSDataSyncTask_DefaultSyncOptions_VerifyMode
=== CONT TestAccAWSDataSyncTask_disappears
=== CONT TestAccAWSDataSyncTask_schedule
=== CONT TestAccAWSDataSyncTask_DefaultSyncOptions_Uid
--- PASS: TestAccAWSDataSyncTask_basic (269.61s)
--- PASS: TestAccAWSDataSyncTask_disappears (287.47s)
--- PASS: TestAccAWSDataSyncTask_schedule (321.44s)
--- PASS: TestAccAWSDataSyncTask_DefaultSyncOptions_Gid (324.56s)
--- PASS: TestAccAWSDataSyncTask_DefaultSyncOptions_Uid (327.15s)
--- PASS: TestAccAWSDataSyncTask_CloudWatchLogGroupARN (327.48s)
--- PASS: TestAccAWSDataSyncTask_DefaultSyncOptions_LogLevel (332.43s)
--- PASS: TestAccAWSDataSyncTask_DefaultSyncOptions_PreserveDeletedFiles (343.10s)
--- PASS: TestAccAWSDataSyncTask_DefaultSyncOptions_AtimeMtime (357.65s)
--- PASS: TestAccAWSDataSyncTask_DefaultSyncOptions_PreserveDevices (358.26s)
--- PASS: TestAccAWSDataSyncTask_DefaultSyncOptions_TransferMode (359.06s)
--- PASS: TestAccAWSDataSyncTask_DefaultSyncOptions_TaskQueueing (363.15s)
--- PASS: TestAccAWSDataSyncTask_DefaultSyncOptions_BytesPerSecond (363.87s)
--- PASS: TestAccAWSDataSyncTask_DefaultSyncOptions_OverwriteMode (365.15s)
--- PASS: TestAccAWSDataSyncTask_DefaultSyncOptions_PosixPermissions (365.46s)
--- PASS: TestAccAWSDataSyncTask_Excludes (374.24s)
--- PASS: TestAccAWSDataSyncTask_DefaultSyncOptions_VerifyMode (389.90s)
PASS
ok github.com/terraform-providers/terraform-provider-aws/aws 392.804s
GovCloud
% make testacc TEST=./aws TESTARGS='-run=TestAccAWSDataSyncTask_'
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./aws -v -count 1 -parallel 20 -run=TestAccAWSDataSyncTask_ -timeout 180m
=== RUN TestAccAWSDataSyncTask_basic
=== PAUSE TestAccAWSDataSyncTask_basic
=== RUN TestAccAWSDataSyncTask_disappears
=== PAUSE TestAccAWSDataSyncTask_disappears
=== RUN TestAccAWSDataSyncTask_schedule
=== PAUSE TestAccAWSDataSyncTask_schedule
=== RUN TestAccAWSDataSyncTask_CloudWatchLogGroupARN
=== PAUSE TestAccAWSDataSyncTask_CloudWatchLogGroupARN
=== RUN TestAccAWSDataSyncTask_Excludes
=== PAUSE TestAccAWSDataSyncTask_Excludes
=== RUN TestAccAWSDataSyncTask_DefaultSyncOptions_AtimeMtime
=== PAUSE TestAccAWSDataSyncTask_DefaultSyncOptions_AtimeMtime
=== RUN TestAccAWSDataSyncTask_DefaultSyncOptions_BytesPerSecond
=== PAUSE TestAccAWSDataSyncTask_DefaultSyncOptions_BytesPerSecond
=== RUN TestAccAWSDataSyncTask_DefaultSyncOptions_Gid
=== PAUSE TestAccAWSDataSyncTask_DefaultSyncOptions_Gid
=== RUN TestAccAWSDataSyncTask_DefaultSyncOptions_LogLevel
=== PAUSE TestAccAWSDataSyncTask_DefaultSyncOptions_LogLevel
=== RUN TestAccAWSDataSyncTask_DefaultSyncOptions_OverwriteMode
=== PAUSE TestAccAWSDataSyncTask_DefaultSyncOptions_OverwriteMode
=== RUN TestAccAWSDataSyncTask_DefaultSyncOptions_PosixPermissions
=== PAUSE TestAccAWSDataSyncTask_DefaultSyncOptions_PosixPermissions
=== RUN TestAccAWSDataSyncTask_DefaultSyncOptions_PreserveDeletedFiles
=== PAUSE TestAccAWSDataSyncTask_DefaultSyncOptions_PreserveDeletedFiles
=== RUN TestAccAWSDataSyncTask_DefaultSyncOptions_PreserveDevices
=== PAUSE TestAccAWSDataSyncTask_DefaultSyncOptions_PreserveDevices
=== RUN TestAccAWSDataSyncTask_DefaultSyncOptions_TaskQueueing
=== PAUSE TestAccAWSDataSyncTask_DefaultSyncOptions_TaskQueueing
=== RUN TestAccAWSDataSyncTask_DefaultSyncOptions_TransferMode
=== PAUSE TestAccAWSDataSyncTask_DefaultSyncOptions_TransferMode
=== RUN TestAccAWSDataSyncTask_DefaultSyncOptions_Uid
=== PAUSE TestAccAWSDataSyncTask_DefaultSyncOptions_Uid
=== RUN TestAccAWSDataSyncTask_DefaultSyncOptions_VerifyMode
=== PAUSE TestAccAWSDataSyncTask_DefaultSyncOptions_VerifyMode
=== RUN TestAccAWSDataSyncTask_Tags
provider_test.go:55: Tagging on creation is inconsistent
--- SKIP: TestAccAWSDataSyncTask_Tags (0.00s)
=== CONT TestAccAWSDataSyncTask_basic
=== CONT TestAccAWSDataSyncTask_DefaultSyncOptions_OverwriteMode
=== CONT TestAccAWSDataSyncTask_DefaultSyncOptions_Uid
=== CONT TestAccAWSDataSyncTask_disappears
=== CONT TestAccAWSDataSyncTask_DefaultSyncOptions_TransferMode
=== CONT TestAccAWSDataSyncTask_DefaultSyncOptions_VerifyMode
=== CONT TestAccAWSDataSyncTask_DefaultSyncOptions_AtimeMtime
=== CONT TestAccAWSDataSyncTask_DefaultSyncOptions_LogLevel
=== CONT TestAccAWSDataSyncTask_DefaultSyncOptions_Gid
=== CONT TestAccAWSDataSyncTask_DefaultSyncOptions_BytesPerSecond
=== CONT TestAccAWSDataSyncTask_CloudWatchLogGroupARN
=== CONT TestAccAWSDataSyncTask_DefaultSyncOptions_PreserveDeletedFiles
=== CONT TestAccAWSDataSyncTask_schedule
=== CONT TestAccAWSDataSyncTask_Excludes
=== CONT TestAccAWSDataSyncTask_DefaultSyncOptions_PosixPermissions
=== CONT TestAccAWSDataSyncTask_DefaultSyncOptions_TaskQueueing
=== CONT TestAccAWSDataSyncTask_DefaultSyncOptions_PreserveDevices
--- PASS: TestAccAWSDataSyncTask_basic (242.60s)
--- PASS: TestAccAWSDataSyncTask_disappears (269.93s)
--- PASS: TestAccAWSDataSyncTask_DefaultSyncOptions_AtimeMtime (271.55s)
--- PASS: TestAccAWSDataSyncTask_DefaultSyncOptions_BytesPerSecond (275.03s)
--- PASS: TestAccAWSDataSyncTask_DefaultSyncOptions_Uid (291.40s)
--- PASS: TestAccAWSDataSyncTask_DefaultSyncOptions_TaskQueueing (293.64s)
--- PASS: TestAccAWSDataSyncTask_DefaultSyncOptions_PreserveDevices (300.06s)
--- PASS: TestAccAWSDataSyncTask_Excludes (309.14s)
--- PASS: TestAccAWSDataSyncTask_DefaultSyncOptions_Gid (322.80s)
--- PASS: TestAccAWSDataSyncTask_DefaultSyncOptions_VerifyMode (324.54s)
--- PASS: TestAccAWSDataSyncTask_CloudWatchLogGroupARN (325.62s)
--- PASS: TestAccAWSDataSyncTask_DefaultSyncOptions_LogLevel (328.24s)
--- PASS: TestAccAWSDataSyncTask_DefaultSyncOptions_PosixPermissions (330.22s)
--- PASS: TestAccAWSDataSyncTask_DefaultSyncOptions_OverwriteMode (331.32s)
--- PASS: TestAccAWSDataSyncTask_schedule (336.34s)
--- PASS: TestAccAWSDataSyncTask_DefaultSyncOptions_TransferMode (336.66s)
--- PASS: TestAccAWSDataSyncTask_DefaultSyncOptions_PreserveDeletedFiles (339.42s)
PASS
ok github.com/terraform-providers/terraform-provider-aws/aws 342.402s
This has been released in version 3.40.0 of the Terraform AWS provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading. For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template for triage. Thanks! |
I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. |
This builds on the changes by @DrFaust92 in #14452 and adds support for other arguments recently added to DataSync tasks.
Community Note
Closes #11153
Closes #14667
Release note for CHANGELOG:
Output from acceptance testing: