Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

r/datasync_task - add scheduling support #14452

Merged
merged 12 commits into from
May 12, 2021
Merged

r/datasync_task - add scheduling support #14452

merged 12 commits into from
May 12, 2021

Conversation

DrFaust92
Copy link
Collaborator

@DrFaust92 DrFaust92 commented Aug 3, 2020 •
edited
Loading

Community Note

  • Please vote on this pull request by adding a 👍 reaction to the original pull request comment to help the community and maintainers prioritize this request
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for pull request followers and do not help prioritize the request

Closes #10995

Release note for CHANGELOG:

resource_aws_datasync_task - add scheduling support
resource_aws_datasync_task  - `cloudwatch_log_group_arn` is now updatable
resource_aws_datasync_task - add plan time validation for `cloudwatch_log_group_arn` and `destination_location_arn`

Output from acceptance testing:

$ make testacc TESTARGS='-run=TestAccAWSDataSyncTask_'
--- PASS: TestAccAWSDataSyncTask_basic (360.50s)
--- PASS: TestAccAWSDataSyncTask_CloudWatchLogGroupARN(693.50s)
--- PASS: TestAccAWSDataSyncTask_disappears (371.05s)
--- PASS: TestAccAWSDataSyncTask_DefaultSyncOptions_VerifyMode
--- PASS: TestAccAWSDataSyncTask_DefaultSyncOptions_Uid
--- PASS: TestAccAWSDataSyncTask_DefaultSyncOptions_PreserveDevices
--- PASS: TestAccAWSDataSyncTask_DefaultSyncOptions_PreserveDeletedFiles
--- PASS: TestAccAWSDataSyncTask_DefaultSyncOptions_PosixPermissions
--- PASS: TestAccAWSDataSyncTask_DefaultSyncOptions_Gid
--- PASS: TestAccAWSDataSyncTask_DefaultSyncOptions_BytesPerSecond
--- PASS: TestAccAWSDataSyncTask_DefaultSyncOptions_AtimeMtime
--- PASS: TestAccAWSDataSyncTask_schedule (494.88s)

@ghost ghost added size/L Managed by automation to categorize the size of a PR. documentation Introduces or discusses updates to documentation. service/datasync Issues and PRs that pertain to the datasync service. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure. labels Aug 3, 2020
@DrFaust92 DrFaust92 marked this pull request as ready for review August 3, 2020 16:29
@DrFaust92 DrFaust92 requested a review from a team August 3, 2020 16:29
@DrFaust92 DrFaust92 added the enhancement Requests to existing resources that expand the functionality or scope. label Aug 3, 2020
@DrFaust92 DrFaust92 force-pushed the r/datasync_task_schedule branch from 5cf4da7 to 09a065c Compare November 9, 2020 19:40
@DrFaust92 DrFaust92 requested a review from a team as a code owner November 9, 2020 19:40
@gazoakley gazoakley mentioned this pull request Nov 15, 2020
Merged
Base automatically changed from master to main January 23, 2021 00:58
@DrFaust92 DrFaust92 force-pushed the r/datasync_task_schedule branch from 435092b to bd3a877 Compare March 27, 2021 18:12
DrFaust92 and others added 9 commits May 12, 2021 15:52
@ewbankkit ewbankkit force-pushed the r/datasync_task_schedule branch from 54d3db4 to fcc3456 Compare May 12, 2021 20:25
ewbankkit added 2 commits May 12, 2021 16:54
@ewbankkit
r/aws_datasync_task: Use '_Values()' in validations (hashicorp#14601)…
c8d5859 
… and simplify resource update.

Acceptance test output:

% make testacc TEST=./aws TESTARGS='-run=TestAccAWSDataSyncTask_basic'
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./aws -v -count 1 -parallel 20 -run=TestAccAWSDataSyncTask_basic -timeout 180m
=== RUN   TestAccAWSDataSyncTask_basic
=== PAUSE TestAccAWSDataSyncTask_basic
=== CONT  TestAccAWSDataSyncTask_basic
--- PASS: TestAccAWSDataSyncTask_basic (230.02s)
PASS
ok  	github.com/terraform-providers/terraform-provider-aws/aws	233.609s
@ewbankkit
r/aws_datasync_task: Add and use internal 'finder' package.
df165c2
@ghost ghost added size/XL Managed by automation to categorize the size of a PR. and removed size/L Managed by automation to categorize the size of a PR. labels May 12, 2021
ewbankkit
ewbankkit approved these changes May 12, 2021
View reviewed changes
Copy link
Contributor

@ewbankkit ewbankkit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀.

Commercial
% make testacc TEST=./aws TESTARGS='-run=TestAccAWSDataSyncTask_'
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./aws -v -count 1 -parallel 20 -run=TestAccAWSDataSyncTask_ -timeout 180m
=== RUN   TestAccAWSDataSyncTask_basic
=== PAUSE TestAccAWSDataSyncTask_basic
=== RUN   TestAccAWSDataSyncTask_disappears
=== PAUSE TestAccAWSDataSyncTask_disappears
=== RUN   TestAccAWSDataSyncTask_schedule
=== PAUSE TestAccAWSDataSyncTask_schedule
=== RUN   TestAccAWSDataSyncTask_CloudWatchLogGroupARN
=== PAUSE TestAccAWSDataSyncTask_CloudWatchLogGroupARN
=== RUN   TestAccAWSDataSyncTask_DefaultSyncOptions_AtimeMtime
=== PAUSE TestAccAWSDataSyncTask_DefaultSyncOptions_AtimeMtime
=== RUN   TestAccAWSDataSyncTask_DefaultSyncOptions_BytesPerSecond
=== PAUSE TestAccAWSDataSyncTask_DefaultSyncOptions_BytesPerSecond
=== RUN   TestAccAWSDataSyncTask_DefaultSyncOptions_Gid
=== PAUSE TestAccAWSDataSyncTask_DefaultSyncOptions_Gid
=== RUN   TestAccAWSDataSyncTask_DefaultSyncOptions_LogLevel
=== PAUSE TestAccAWSDataSyncTask_DefaultSyncOptions_LogLevel
=== RUN   TestAccAWSDataSyncTask_DefaultSyncOptions_PosixPermissions
=== PAUSE TestAccAWSDataSyncTask_DefaultSyncOptions_PosixPermissions
=== RUN   TestAccAWSDataSyncTask_DefaultSyncOptions_PreserveDeletedFiles
=== PAUSE TestAccAWSDataSyncTask_DefaultSyncOptions_PreserveDeletedFiles
=== RUN   TestAccAWSDataSyncTask_DefaultSyncOptions_PreserveDevices
=== PAUSE TestAccAWSDataSyncTask_DefaultSyncOptions_PreserveDevices
=== RUN   TestAccAWSDataSyncTask_DefaultSyncOptions_Uid
=== PAUSE TestAccAWSDataSyncTask_DefaultSyncOptions_Uid
=== RUN   TestAccAWSDataSyncTask_DefaultSyncOptions_VerifyMode
=== PAUSE TestAccAWSDataSyncTask_DefaultSyncOptions_VerifyMode
=== RUN   TestAccAWSDataSyncTask_Tags
    provider_test.go:55: Tagging on creation is inconsistent
--- SKIP: TestAccAWSDataSyncTask_Tags (0.00s)
=== CONT  TestAccAWSDataSyncTask_basic
=== CONT  TestAccAWSDataSyncTask_DefaultSyncOptions_LogLevel
=== CONT  TestAccAWSDataSyncTask_DefaultSyncOptions_VerifyMode
=== CONT  TestAccAWSDataSyncTask_DefaultSyncOptions_Uid
=== CONT  TestAccAWSDataSyncTask_DefaultSyncOptions_PreserveDevices
=== CONT  TestAccAWSDataSyncTask_DefaultSyncOptions_PreserveDeletedFiles
=== CONT  TestAccAWSDataSyncTask_DefaultSyncOptions_PosixPermissions
=== CONT  TestAccAWSDataSyncTask_DefaultSyncOptions_AtimeMtime
=== CONT  TestAccAWSDataSyncTask_disappears
=== CONT  TestAccAWSDataSyncTask_DefaultSyncOptions_BytesPerSecond
=== CONT  TestAccAWSDataSyncTask_CloudWatchLogGroupARN
=== CONT  TestAccAWSDataSyncTask_DefaultSyncOptions_Gid
=== CONT  TestAccAWSDataSyncTask_schedule
--- PASS: TestAccAWSDataSyncTask_disappears (254.19s)
--- PASS: TestAccAWSDataSyncTask_DefaultSyncOptions_AtimeMtime (291.67s)
--- PASS: TestAccAWSDataSyncTask_CloudWatchLogGroupARN (293.57s)
--- PASS: TestAccAWSDataSyncTask_basic (298.11s)
--- PASS: TestAccAWSDataSyncTask_DefaultSyncOptions_PosixPermissions (301.14s)
--- PASS: TestAccAWSDataSyncTask_DefaultSyncOptions_PreserveDeletedFiles (301.27s)
--- PASS: TestAccAWSDataSyncTask_schedule (302.96s)
--- PASS: TestAccAWSDataSyncTask_DefaultSyncOptions_BytesPerSecond (304.22s)
--- PASS: TestAccAWSDataSyncTask_DefaultSyncOptions_PreserveDevices (331.62s)
--- PASS: TestAccAWSDataSyncTask_DefaultSyncOptions_Gid (336.12s)
--- PASS: TestAccAWSDataSyncTask_DefaultSyncOptions_Uid (340.62s)
--- PASS: TestAccAWSDataSyncTask_DefaultSyncOptions_LogLevel (344.72s)
--- PASS: TestAccAWSDataSyncTask_DefaultSyncOptions_VerifyMode (345.72s)
PASS
ok  	github.com/terraform-providers/terraform-provider-aws/aws	348.806s
GovCloud
% make testacc TEST=./aws TESTARGS='-run=TestAccAWSDataSyncTask_' 
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./aws -v -count 1 -parallel 20 -run=TestAccAWSDataSyncTask_ -timeout 180m
=== RUN   TestAccAWSDataSyncTask_basic
=== PAUSE TestAccAWSDataSyncTask_basic
=== RUN   TestAccAWSDataSyncTask_disappears
=== PAUSE TestAccAWSDataSyncTask_disappears
=== RUN   TestAccAWSDataSyncTask_schedule
=== PAUSE TestAccAWSDataSyncTask_schedule
=== RUN   TestAccAWSDataSyncTask_CloudWatchLogGroupARN
=== PAUSE TestAccAWSDataSyncTask_CloudWatchLogGroupARN
=== RUN   TestAccAWSDataSyncTask_DefaultSyncOptions_AtimeMtime
=== PAUSE TestAccAWSDataSyncTask_DefaultSyncOptions_AtimeMtime
=== RUN   TestAccAWSDataSyncTask_DefaultSyncOptions_BytesPerSecond
=== PAUSE TestAccAWSDataSyncTask_DefaultSyncOptions_BytesPerSecond
=== RUN   TestAccAWSDataSyncTask_DefaultSyncOptions_Gid
=== PAUSE TestAccAWSDataSyncTask_DefaultSyncOptions_Gid
=== RUN   TestAccAWSDataSyncTask_DefaultSyncOptions_LogLevel
=== PAUSE TestAccAWSDataSyncTask_DefaultSyncOptions_LogLevel
=== RUN   TestAccAWSDataSyncTask_DefaultSyncOptions_PosixPermissions
=== PAUSE TestAccAWSDataSyncTask_DefaultSyncOptions_PosixPermissions
=== RUN   TestAccAWSDataSyncTask_DefaultSyncOptions_PreserveDeletedFiles
=== PAUSE TestAccAWSDataSyncTask_DefaultSyncOptions_PreserveDeletedFiles
=== RUN   TestAccAWSDataSyncTask_DefaultSyncOptions_PreserveDevices
=== PAUSE TestAccAWSDataSyncTask_DefaultSyncOptions_PreserveDevices
=== RUN   TestAccAWSDataSyncTask_DefaultSyncOptions_Uid
=== PAUSE TestAccAWSDataSyncTask_DefaultSyncOptions_Uid
=== RUN   TestAccAWSDataSyncTask_DefaultSyncOptions_VerifyMode
=== PAUSE TestAccAWSDataSyncTask_DefaultSyncOptions_VerifyMode
=== RUN   TestAccAWSDataSyncTask_Tags
    provider_test.go:55: Tagging on creation is inconsistent
--- SKIP: TestAccAWSDataSyncTask_Tags (0.00s)
=== CONT  TestAccAWSDataSyncTask_basic
=== CONT  TestAccAWSDataSyncTask_DefaultSyncOptions_LogLevel
=== CONT  TestAccAWSDataSyncTask_DefaultSyncOptions_VerifyMode
=== CONT  TestAccAWSDataSyncTask_DefaultSyncOptions_Uid
=== CONT  TestAccAWSDataSyncTask_DefaultSyncOptions_PreserveDevices
=== CONT  TestAccAWSDataSyncTask_DefaultSyncOptions_PreserveDeletedFiles
=== CONT  TestAccAWSDataSyncTask_DefaultSyncOptions_PosixPermissions
=== CONT  TestAccAWSDataSyncTask_schedule
=== CONT  TestAccAWSDataSyncTask_DefaultSyncOptions_Gid
=== CONT  TestAccAWSDataSyncTask_DefaultSyncOptions_AtimeMtime
=== CONT  TestAccAWSDataSyncTask_DefaultSyncOptions_BytesPerSecond
=== CONT  TestAccAWSDataSyncTask_CloudWatchLogGroupARN
=== CONT  TestAccAWSDataSyncTask_disappears
--- PASS: TestAccAWSDataSyncTask_disappears (207.54s)
--- PASS: TestAccAWSDataSyncTask_basic (241.95s)
--- PASS: TestAccAWSDataSyncTask_DefaultSyncOptions_Gid (258.47s)
--- PASS: TestAccAWSDataSyncTask_DefaultSyncOptions_PosixPermissions (269.14s)
--- PASS: TestAccAWSDataSyncTask_DefaultSyncOptions_Uid (278.07s)
--- PASS: TestAccAWSDataSyncTask_DefaultSyncOptions_PreserveDevices (279.14s)
--- PASS: TestAccAWSDataSyncTask_CloudWatchLogGroupARN (280.90s)
--- PASS: TestAccAWSDataSyncTask_DefaultSyncOptions_LogLevel (291.59s)
--- PASS: TestAccAWSDataSyncTask_schedule (293.79s)
--- PASS: TestAccAWSDataSyncTask_DefaultSyncOptions_PreserveDeletedFiles (298.36s)
--- PASS: TestAccAWSDataSyncTask_DefaultSyncOptions_AtimeMtime (317.25s)
--- PASS: TestAccAWSDataSyncTask_DefaultSyncOptions_VerifyMode (334.85s)
--- PASS: TestAccAWSDataSyncTask_DefaultSyncOptions_BytesPerSecond (335.74s)
PASS
ok  	github.com/terraform-providers/terraform-provider-aws/aws	338.663s

@ewbankkit ewbankkit merged commit afefee3 into hashicorp:main May 12, 2021
@github-actions github-actions bot added this to the v3.40.0 milestone May 12, 2021
@ghost
Copy link

ghost commented May 13, 2021

This has been released in version 3.40.0 of the Terraform AWS provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template for triage. Thanks!

@github-actions
Copy link

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jun 13, 2021
@DrFaust92 DrFaust92 deleted the r/datasync_task_schedule branch September 9, 2021 08:39
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@ewbankkit ewbankkit ewbankkit approved these changes

Assignees
No one assigned
Labels
documentation Introduces or discusses updates to documentation. enhancement Requests to existing resources that expand the functionality or scope. service/datasync Issues and PRs that pertain to the datasync service. size/XL Managed by automation to categorize the size of a PR. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure.
Projects
None yet
Milestone
v3.40.0
Development

Successfully merging this pull request may close these issues.

AWS DataSync Scheduling
2 participants
@DrFaust92 @ewbankkit