Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Expose aws_ami root volume size #1623

Closed
tomelliff opened this issue Sep 8, 2017 · 2 comments
Closed

Expose aws_ami root volume size #1623

tomelliff opened this issue Sep 8, 2017 · 2 comments
Labels
enhancement Requests to existing resources that expand the functionality or scope. service/ec2 Issues and PRs that pertain to the ec2 service. stale Old or inactive issues managed by automation, if no further action taken these will get closed.

Comments

@tomelliff
Copy link
Contributor

I was trying to get at the AMI's root volume size so that my instance modules can default to the root volume size of the AMI instead of having to either hard-code a default or require the variable to be passed to the volume.

Unfortunately it looks like it's not really possible to usefully get at the information inside the block_device_mappings map (as mentioned in #1572).

Instead can we expose this directly as something like root_volume_size? It might be useful to expose the other things like the volume_type and iops too at the same time for people who use provisioned IOPS I guess but I have no need for that.
@Ninir Ninir added the enhancement Requests to existing resources that expand the functionality or scope. label Sep 18, 2017
tomelliff pushed a commit to tomelliff/terraform-provider-aws that referenced this issue Oct 31, 2017
WIP Expose AMI's root volume size
e2d35d0 
Attempting to implement hashicorp#1623
Right now the tests I've added are failing with the root_volume_size not being set at all.
I'll debug this when I get a chance but just want to push the work up for now.
@tomelliff tomelliff mentioned this issue Oct 31, 2017
Closed
@radeksimko radeksimko added the service/ec2 Issues and PRs that pertain to the ec2 service. label Jan 28, 2018
@tomelliff tomelliff mentioned this issue Dec 9, 2018
Closed
@github-actions
Copy link

Marking this issue as stale due to inactivity. This helps our maintainers find and focus on the active issues. If this issue receives no comments in the next 30 days it will automatically be closed. Maintainers can also remove the stale label.

If this issue was automatically closed and you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. Thank you!

@github-actions github-actions bot added the stale Old or inactive issues managed by automation, if no further action taken these will get closed. label Mar 30, 2020
@ghost
Copy link

ghost commented May 30, 2020

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. Thanks!

@ghost ghost locked and limited conversation to collaborators May 30, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
enhancement Requests to existing resources that expand the functionality or scope. service/ec2 Issues and PRs that pertain to the ec2 service. stale Old or inactive issues managed by automation, if no further action taken these will get closed.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@radeksimko @Ninir @tomelliff