-
Notifications
You must be signed in to change notification settings - Fork 9.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adds launch_template to aws_autoscaling_group data source #16297
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great 👍 (aside from merge conflict in test file)
Output of acceptance tests:
--- PASS: TestAccAwsAutoScalingGroupDataSource_basic (29.18s)
--- PASS: TestAccAwsAutoScalingGroupDataSource_launchTemplate (32.99s)
resource "aws_launch_template" "test" { | ||
name_prefix = "test" | ||
image_id = data.aws_ami.test_ami.id | ||
instance_type = "t2.micro" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
not sure if we need to avoid the hardcoded instance type here, but we could also use the testAccAvailableEc2InstanceTypeForRegion("t3.micro", "t2.micro")
config and ref here
af05bbc
to
1ef6047
Compare
This has been released in version 3.22.0 of the Terraform AWS provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading. For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template for triage. Thanks! |
I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. Thanks! |
Adds
launch_template
toaws_autoscaling_group
data source.Closes #16289
Release note for CHANGELOG:
Output from acceptance testing: