Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

tests/resource/aws_lightsail_domain: Remove hardcoded region in configuration #16302

Closed
bflad opened this issue Nov 19, 2020 · 2 comments · Fixed by #16304
Closed

tests/resource/aws_lightsail_domain: Remove hardcoded region in configuration #16302

bflad opened this issue Nov 19, 2020 · 2 comments · Fixed by #16304
Assignees
@bflad
Labels
service/lightsail Issues and PRs that pertain to the lightsail service. technical-debt Addresses areas of the codebase that need refactoring or redesign. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure.
Milestone
v3.21.0

Comments

@bflad
Copy link
Contributor

bflad commented Nov 19, 2020

Community Note

  • Please vote on this issue by adding a 👍 reaction to the original issue to help the community and maintainers prioritize this request
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for issue followers and do not help prioritize the request
  • If you are interested in working on this issue or have submitted a pull request, please leave a comment

Description

Currently, the testing configurations for aws_lightsail_domain resource are hardcoded to us-east-1, which is not compatible with AWS partitions outside AWS Commercial. While other regions do not yet support Lightsail Domains, the testing should be prepared for it following other recent acceptance testing changes.

Affected Resource(s)

  • aws_lightsail_domain

References
@bflad bflad added tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure. service/lightsail Issues and PRs that pertain to the lightsail service. technical-debt Addresses areas of the codebase that need refactoring or redesign. labels Nov 19, 2020
@bflad bflad self-assigned this Nov 19, 2020
bflad added a commit that referenced this issue Nov 19, 2020
@bflad
tests/resource/aws_lightsail_domain: Remove hardcoded region and stan…
7d41efe 
…dardize disappears testing

Reference: #16302

Output from acceptance testing in AWS Commercial:

```
--- PASS: TestAccAWSLightsailDomain_disappears (10.22s)
--- PASS: TestAccAWSLightsailDomain_basic (10.27s)
```

Output from acceptance testing in AWS GovCloud (US):

```
--- SKIP: TestAccAWSLightsailDomain_basic (1.70s)
--- SKIP: TestAccAWSLightsailDomain_disappears (1.70s)
```
@bflad bflad mentioned this issue Nov 19, 2020
Merged
@bflad bflad added this to the v3.21.0 milestone Dec 4, 2020
bflad added a commit that referenced this issue Dec 4, 2020
@bflad
tests/resource/aws_lightsail_domain: Remove hardcoded region and stan…
5cd4f1e 
…dardize disappears testing (#16304)

Reference: #16302

Output from acceptance testing in AWS Commercial:

```
--- PASS: TestAccAWSLightsailDomain_disappears (10.22s)
--- PASS: TestAccAWSLightsailDomain_basic (10.27s)
```

Output from acceptance testing in AWS GovCloud (US):

```
--- SKIP: TestAccAWSLightsailDomain_basic (1.70s)
--- SKIP: TestAccAWSLightsailDomain_disappears (1.70s)
```
@ghost
Copy link

ghost commented Dec 11, 2020

This has been released in version 3.21.0 of the Terraform AWS provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template for triage. Thanks!

@ghost
Copy link

ghost commented Jan 4, 2021

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. Thanks!

@ghost ghost locked as resolved and limited conversation to collaborators Jan 4, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@bflad bflad

Labels
service/lightsail Issues and PRs that pertain to the lightsail service. technical-debt Addresses areas of the codebase that need refactoring or redesign. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure.
Projects
None yet
Milestone
v3.21.0
1 participant
@bflad