Mark aws_kinesis_firehose_delivery_stream access_key as sensitive

[kyeah]

Community Note

• Please vote on this issue by adding a 👍 reaction to the original issue to help the community and maintainers prioritize this request
• Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for issue followers and do not help prioritize the request
• If you are interested in working on this issue or have submitted a pull request, please leave a comment

Description

Hi there! We've been using the new http_endpoint_configuration for the aws_kinesis_firehose_delivery_stream and appreciate the addition.

However, we notice that the access_key is not marked as sensitive. For integrations like New Relic, this means that the New Relic API key is printed in plain text within plan outputs. Ideally this would be marked as sensitive.

New or Affected Resource(s)

• aws_kinesis_firehose_delivery_stream

Potential Terraform Configuration

resource "aws_kinesis_firehose_delivery_stream" "aws_waf" {
  name        = "aws-waf-logs-firewall-to-newrelic"
  destination = "http_endpoint"

  s3_configuration {
    role_arn           = aws_iam_role.kinesis_aws_waf_role.arn
    bucket_arn         = aws_s3_bucket.kinesis_dead_letter_drop.arn
    buffer_size        = 10
    buffer_interval    = 400
    compression_format = "GZIP"
  }

  http_endpoint_configuration {
    url                = "https://aws-api.newrelic.com/firehose/v1"
    name               = "New Relic"
    access_key         = data.aws_ssm_parameter.newrelic-api-key.value
    buffering_size     = 15
    buffering_interval = 600
    role_arn           = aws_iam_role.kinesis_aws_waf_role.arn
    s3_backup_mode     = "FailedDataOnly"

    request_configuration {
      content_encoding = "GZIP"
    }
  }
}

References

• Add http_endpoint_configuration to r/aws_kinesis_firehose_delivery_stream #14469

[ghost]

This has been released in version 3.22.0 of the Terraform AWS provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template for triage. Thanks!

[ghost]

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. Thanks!