Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New Resource: aws_ecrpublic_repository #16865

Merged
merged 33 commits into from
Feb 24, 2021
Merged

Conversation

breathingdust
Copy link
Member

@breathingdust breathingdust commented Dec 21, 2020

Community Note

  • Please vote on this pull request by adding a 👍 reaction to the original pull request comment to help the community and maintainers prioritize this request
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for pull request followers and do not help prioritize the request

Closes #16537

Release note for CHANGELOG:

* **New Resource:** `aws_ecrpublic_repository` 

Output from acceptance testing:

make testacc TESTARGS='-run=TestAccAWSEcrPublicRepository_'
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./aws -v -count 1 -parallel 20 -run=TestAccAWSEcrPublicRepository_ -timeout 120m
=== RUN   TestAccAWSEcrPublicRepository_basic
=== PAUSE TestAccAWSEcrPublicRepository_basic
=== RUN   TestAccAWSEcrPublicRepository_catalogdata_abouttext
=== PAUSE TestAccAWSEcrPublicRepository_catalogdata_abouttext
=== RUN   TestAccAWSEcrPublicRepository_catalogdata_architectures
=== PAUSE TestAccAWSEcrPublicRepository_catalogdata_architectures
=== RUN   TestAccAWSEcrPublicRepository_catalogdata_description
=== PAUSE TestAccAWSEcrPublicRepository_catalogdata_description
=== RUN   TestAccAWSEcrPublicRepository_catalogdata_operatingsystems
=== PAUSE TestAccAWSEcrPublicRepository_catalogdata_operatingsystems
=== RUN   TestAccAWSEcrPublicRepository_catalogdata_usagetext
=== PAUSE TestAccAWSEcrPublicRepository_catalogdata_usagetext
=== RUN   TestAccAWSEcrPublicRepository_catalogdata_logoimageblob
=== PAUSE TestAccAWSEcrPublicRepository_catalogdata_logoimageblob
=== RUN   TestAccAWSEcrPublicRepository_disappears
=== PAUSE TestAccAWSEcrPublicRepository_disappears
=== CONT  TestAccAWSEcrPublicRepository_basic
=== CONT  TestAccAWSEcrPublicRepository_catalogdata_usagetext
=== CONT  TestAccAWSEcrPublicRepository_catalogdata_operatingsystems
=== CONT  TestAccAWSEcrPublicRepository_disappears
=== CONT  TestAccAWSEcrPublicRepository_catalogdata_description
=== CONT  TestAccAWSEcrPublicRepository_catalogdata_architectures
=== CONT  TestAccAWSEcrPublicRepository_catalogdata_abouttext
=== CONT  TestAccAWSEcrPublicRepository_catalogdata_logoimageblob
--- PASS: TestAccAWSEcrPublicRepository_disappears (12.97s)
2020/12/23 08:58:37 [DEBUG] Trying to get account information via sts:GetCallerIdentity
--- PASS: TestAccAWSEcrPublicRepository_catalogdata_usagetext (17.59s)
--- PASS: TestAccAWSEcrPublicRepository_catalogdata_operatingsystems (18.58s)
--- PASS: TestAccAWSEcrPublicRepository_catalogdata_abouttext (18.62s)
--- PASS: TestAccAWSEcrPublicRepository_catalogdata_description (18.69s)
--- PASS: TestAccAWSEcrPublicRepository_catalogdata_architectures (18.80s)
--- PASS: TestAccAWSEcrPublicRepository_basic (18.94s)
--- PASS: TestAccAWSEcrPublicRepository_catalogdata_logoimageblob (19.11s)
PASS
ok      github.com/terraform-providers/terraform-provider-aws/aws       20.813s

@ghost ghost added size/XL Managed by automation to categorize the size of a PR. provider Pertains to the provider itself, rather than any interaction with AWS. service/ecrpublic Issues and PRs that pertain to the ecrpublic service. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure. labels Dec 21, 2020
@breathingdust breathingdust added the new-resource Introduces a new resource. label Dec 21, 2020
@ghost ghost added the documentation Introduces or discusses updates to documentation. label Dec 22, 2020
@breathingdust breathingdust marked this pull request as ready for review December 23, 2020 18:39
@breathingdust breathingdust requested a review from a team as a code owner December 23, 2020 18:39
@breathingdust breathingdust changed the title New Resource: aws_ecrpublic_repostitory New Resource: aws_ecrpublic_repository Dec 23, 2020
Base automatically changed from master to main January 23, 2021 01:00
@bflad bflad self-assigned this Feb 10, 2021
Copy link
Contributor

@bflad bflad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please reach out with any questions. 👍

aws/resource_aws_ecrpublic_repository.go Show resolved Hide resolved
aws/resource_aws_ecrpublic_repository.go Outdated Show resolved Hide resolved
aws/resource_aws_ecrpublic_repository.go Outdated Show resolved Hide resolved
aws/resource_aws_ecrpublic_repository.go Outdated Show resolved Hide resolved
aws/resource_aws_ecrpublic_repository.go Outdated Show resolved Hide resolved
aws/resource_aws_ecrpublic_repository_test.go Outdated Show resolved Hide resolved
aws/resource_aws_ecrpublic_repository_test.go Outdated Show resolved Hide resolved
website/docs/r/ecrpublic_repository.html.markdown Outdated Show resolved Hide resolved
Copy link
Contributor

@bflad bflad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Two minor documentation things, otherwise let's get this in. 🚀

Output from acceptance testing in AWS Commercial (us-east-1):

--- PASS: TestAccAWSEcrPublicRepository_basic (13.67s)
--- PASS: TestAccAWSEcrPublicRepository_basic_forcedestroy (13.61s)
--- PASS: TestAccAWSEcrPublicRepository_catalogdata_abouttext (20.45s)
--- PASS: TestAccAWSEcrPublicRepository_catalogdata_architectures (20.23s)
--- PASS: TestAccAWSEcrPublicRepository_catalogdata_description (19.54s)
--- PASS: TestAccAWSEcrPublicRepository_catalogdata_logoimageblob (13.78s)
--- PASS: TestAccAWSEcrPublicRepository_catalogdata_operatingsystems (20.36s)
--- PASS: TestAccAWSEcrPublicRepository_catalogdata_usagetext (19.52s)
--- PASS: TestAccAWSEcrPublicRepository_disappears (10.02s)

Output from acceptance testing in AWS GovCloud (US):

--- SKIP: TestAccAWSEcrPublicRepository_basic (23.85s)
--- SKIP: TestAccAWSEcrPublicRepository_basic_forcedestroy (24.27s)
--- SKIP: TestAccAWSEcrPublicRepository_catalogdata_abouttext (18.87s)
--- SKIP: TestAccAWSEcrPublicRepository_catalogdata_architectures (20.94s)
--- SKIP: TestAccAWSEcrPublicRepository_catalogdata_description (22.37s)
--- SKIP: TestAccAWSEcrPublicRepository_catalogdata_logoimageblob (24.61s)
--- SKIP: TestAccAWSEcrPublicRepository_catalogdata_operatingsystems (25.02s)
--- SKIP: TestAccAWSEcrPublicRepository_catalogdata_usagetext (27.37s)
--- SKIP: TestAccAWSEcrPublicRepository_disappears (25.22s)

website/docs/r/ecrpublic_repository.html.markdown Outdated Show resolved Hide resolved
@breathingdust breathingdust merged commit 90a98dd into main Feb 24, 2021
@breathingdust breathingdust deleted the f-ecr-public-repository branch February 24, 2021 23:30
@github-actions github-actions bot added this to the v3.30.0 milestone Feb 24, 2021
@ghost
Copy link

ghost commented Feb 26, 2021

This has been released in version 3.30.0 of the Terraform AWS provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template for triage. Thanks!

@ghost
Copy link

ghost commented Mar 27, 2021

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. Thanks!

@ghost ghost locked as resolved and limited conversation to collaborators Mar 27, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
documentation Introduces or discusses updates to documentation. new-resource Introduces a new resource. provider Pertains to the provider itself, rather than any interaction with AWS. service/ecrpublic Issues and PRs that pertain to the ecrpublic service. size/XL Managed by automation to categorize the size of a PR. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Support for Managing ECR Public Repositories
2 participants