-
Notifications
You must be signed in to change notification settings - Fork 9.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
New Resource: aws_ecrpublic_repository #16865
Merged
+949
−0
Merged
Changes from 1 commit
Commits
Show all changes
33 commits
Select commit
Hold shift + click to select a range
3b4626e
schema and create function
breathingdust dc7d378
most of read, few questions
breathingdust ed3115e
add computed fields
breathingdust f3c5670
add deletefunc
breathingdust 2bbbcd6
UpdateFunc
breathingdust 66860a9
add basic test
breathingdust ca0f9e0
tests passing without catalog_data block
breathingdust 21f7ba0
basic test passing
breathingdust 93aa7db
add disappears test
breathingdust 46de2a6
all catalog block tests except for logo
breathingdust b7dc263
failing logo test
breathingdust aaa0a47
fix file encoding
breathingdust 24cf563
fix acc test linting errors
breathingdust e114cac
added documentation
breathingdust bed44aa
fix formatting
breathingdust 62a2a15
website lint fixes
breathingdust 19f12a3
import naming fix
breathingdust 0aaa6e5
add an error check to logo blob read
breathingdust cdcf277
get partition from helper
breathingdust e29138b
revert debug line
breathingdust 9e55e82
add custom precheck
breathingdust 4313830
rename repository_arn to arn
breathingdust 3290854
nil check AWS SDK output
breathingdust 8d71e19
use type conversion function
breathingdust c009e4e
change architecture + operatingsystem to TypeSet
breathingdust be701b2
modify force_destroy handling
breathingdust 77f9489
add update test steps for attributes
breathingdust 2dea23b
correct %q usage
breathingdust b5af6ed
add id attribute documentation
breathingdust f5cf291
remove drift detection for logo attribute
breathingdust 6278495
add special handling for computer logo_image_blob attribute
breathingdust 9eed993
add changelog
breathingdust 7c9d19a
fix import documentation
breathingdust File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
add an error check to logo blob read
commit 0aaa6e54c421db913ef7895fefddb9a7a80783c8
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There are quite a few considerations that must be taken into account when creating a custom HTTP client (such as respecting HTTP proxies and other restrictions in certain environments), which is why we typically discourage the practice. It might be best to document that we do not support drift detection for this attribute and remove this or provide a method for opting out for environments that might have trouble with this.