Add Tags for resource aws_dms_certificate

[snowsky]

Community Note

• Please vote on this pull request by adding a 👍 reaction to the original pull request comment to help the community and maintainers prioritize this request
• Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for pull request followers and do not help prioritize the request

Relates OR Closes #17092

Release note for CHANGELOG:

Output from acceptance testing:

$ make testacc TESTARGS='-run=TestAccAWSDmsCertificate_basic'
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./aws -v -count 1 -parallel 20 -run=TestAccAWSDmsCertificate_basic -timeout 120m
=== RUN   TestAccAWSDmsCertificate_basic
=== PAUSE TestAccAWSDmsCertificate_basic
=== CONT  TestAccAWSDmsCertificate_basic
--- PASS: TestAccAWSDmsCertificate_basic (28.89s)
PASS
ok  	github.com/terraform-providers/terraform-provider-aws/aws	36.841s

...

[github-actions]

Welcome @snowsky 👋

It looks like this is your first Pull Request submission to the Terraform AWS Provider! If you haven’t already done so please make sure you have checked out our CONTRIBUTING guide and FAQ to make sure your contribution is adhering to best practice and has all the necessary elements in place for a successful approval.

Also take a look at our FAQ which details how we prioritize Pull Requests for inclusion.

Thanks again, and welcome to the community! 😃

[anGie44]

Hi @snowsky, thank you for this PR! It's off to a great start, please find my initial comments for review.

In addition to implementing tags in the Create function, we'll also want to implement them in the Read and Update functions as well. Please refer to our docs page for more info/examples: https://github.com/hashicorp/terraform-provider-aws/blob/master/docs/contributing/contribution-checklists.md#resource-tagging-code-implementation. A good example of tests to go along with the updated implementation can be found in this resource's tests _Tags func to validate the update and multiple tags:

terraform-provider-aws/aws/resource_aws_ec2_managed_prefix_list_test.go

Lines 190 to 234 in 6e1126c

	func TestAccAwsEc2ManagedPrefixList_Tags(t *testing.T) {
	resourceName := "aws_ec2_managed_prefix_list.test"
	rName := acctest.RandomWithPrefix("tf-acc-test")
	resource.ParallelTest(t, resource.TestCase{
	PreCheck: func() { testAccPreCheck(t) },
	Providers: testAccProviders,
	CheckDestroy: testAccCheckAwsEc2ManagedPrefixListDestroy,
	Steps: []resource.TestStep{
	{
	Config: testAccAwsEc2ManagedPrefixListConfig_Tags1(rName, "key1", "value1"),
	Check: resource.ComposeAggregateTestCheckFunc(
	testAccAwsEc2ManagedPrefixListExists(resourceName),
	resource.TestCheckResourceAttr(resourceName, "tags.%", "1"),
	resource.TestCheckResourceAttr(resourceName, "tags.key1", "value1"),
	resource.TestCheckResourceAttr(resourceName, "version", "1"),
	),
	},
	{
	ResourceName: resourceName,
	ImportState: true,
	ImportStateVerify: true,
	},
	{
	Config: testAccAwsEc2ManagedPrefixListConfig_Tags2(rName, "key1", "value1updated", "key2", "value2"),
	Check: resource.ComposeAggregateTestCheckFunc(
	testAccAwsEc2ManagedPrefixListExists(resourceName),
	resource.TestCheckResourceAttr(resourceName, "tags.%", "2"),
	resource.TestCheckResourceAttr(resourceName, "tags.key1", "value1updated"),
	resource.TestCheckResourceAttr(resourceName, "tags.key2", "value2"),
	resource.TestCheckResourceAttr(resourceName, "version", "1"),
	),
	},
	{
	Config: testAccAwsEc2ManagedPrefixListConfig_Tags1(rName, "key2", "value2"),
	Check: resource.ComposeAggregateTestCheckFunc(
	testAccAwsEc2ManagedPrefixListExists(resourceName),
	resource.TestCheckResourceAttr(resourceName, "tags.%", "1"),
	resource.TestCheckResourceAttr(resourceName, "tags.key2", "value2"),
	resource.TestCheckResourceAttr(resourceName, "version", "1"),
	),
	},
	},
	})
	}

If you have any additional implementation/testing questions, lmk :)

[snowsky]

@anGie44, could you please take another look? Thanks.

[anGie44]

thanks again @snowsky and apologies for the delay! the changes overall look good, to get this into an upcoming release i'm going to add to the tags test and adjust some of the error formatting used in the return statements (%s -> %w)

Output of acceptance test:

--- PASS: TestAccAWSDmsCertificate_tags (32.93s)

[snowsky]

Thanks @anGie44, learned from your commit :)

[ghost]

This has been released in version 3.30.0 of the Terraform AWS provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template for triage. Thanks!

[ghost]

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. Thanks!