r/aws_sqs_queue: append .fifo suffix for FIFO queue if name unspecified #17164

drexler · 2021-01-19T03:00:04Z

Community Note

Please vote on this pull request by adding a 👍 reaction to the original pull request comment to help the community and maintainers prioritize this request
Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for pull request followers and do not help prioritize the request

Release note for CHANGELOG:

append .fifo suffix for FIFO queue if name unspecified

Output from acceptance testing:

 make testacc TEST=./aws TESTARGS='-run=TestAccAWSSQSQueue'
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./aws -v -count 1 -parallel 20 -run=TestAccAWSSQSQueue -timeout 120m
=== RUN   TestAccAWSSQSQueuePolicy_basic
=== PAUSE TestAccAWSSQSQueuePolicy_basic
=== RUN   TestAccAWSSQSQueuePolicy_disappears_queue
=== PAUSE TestAccAWSSQSQueuePolicy_disappears_queue
=== RUN   TestAccAWSSQSQueuePolicy_disappears
=== PAUSE TestAccAWSSQSQueuePolicy_disappears
=== RUN   TestAccAWSSQSQueue_basic
=== PAUSE TestAccAWSSQSQueue_basic
=== RUN   TestAccAWSSQSQueue_tags
=== PAUSE TestAccAWSSQSQueue_tags
=== RUN   TestAccAWSSQSQueue_namePrefix
=== PAUSE TestAccAWSSQSQueue_namePrefix
=== RUN   TestAccAWSSQSQueue_namePrefix_fifo
=== PAUSE TestAccAWSSQSQueue_namePrefix_fifo
=== RUN   TestAccAWSSQSQueue_policy
=== PAUSE TestAccAWSSQSQueue_policy
=== RUN   TestAccAWSSQSQueue_queueDeletedRecently
=== PAUSE TestAccAWSSQSQueue_queueDeletedRecently
=== RUN   TestAccAWSSQSQueue_redrivePolicy
=== PAUSE TestAccAWSSQSQueue_redrivePolicy
=== RUN   TestAccAWSSQSQueue_Policybasic
=== PAUSE TestAccAWSSQSQueue_Policybasic
=== RUN   TestAccAWSSQSQueue_FIFO
=== PAUSE TestAccAWSSQSQueue_FIFO
=== RUN   TestAccAWSSQSQueue_FIFOExpectNameError
=== PAUSE TestAccAWSSQSQueue_FIFOExpectNameError
=== RUN   TestAccAWSSQSQueue_FIFOWithContentBasedDeduplication
=== PAUSE TestAccAWSSQSQueue_FIFOWithContentBasedDeduplication
=== RUN   TestAccAWSSQSQueue_ExpectContentBasedDeduplicationError
=== PAUSE TestAccAWSSQSQueue_ExpectContentBasedDeduplicationError
=== RUN   TestAccAWSSQSQueue_Encryption
=== PAUSE TestAccAWSSQSQueue_Encryption
=== RUN   TestAccAWSSQSQueue_FIFO_MinusName
=== PAUSE TestAccAWSSQSQueue_FIFO_MinusName
=== CONT  TestAccAWSSQSQueuePolicy_basic
=== CONT  TestAccAWSSQSQueue_redrivePolicy
=== CONT  TestAccAWSSQSQueuePolicy_disappears_queue
=== CONT  TestAccAWSSQSQueue_ExpectContentBasedDeduplicationError
=== CONT  TestAccAWSSQSQueue_FIFOExpectNameError
=== CONT  TestAccAWSSQSQueue_FIFOWithContentBasedDeduplication
=== CONT  TestAccAWSSQSQueue_FIFO_MinusName
=== CONT  TestAccAWSSQSQueue_Policybasic
=== CONT  TestAccAWSSQSQueue_Encryption
=== CONT  TestAccAWSSQSQueue_policy
=== CONT  TestAccAWSSQSQueue_FIFO
=== CONT  TestAccAWSSQSQueue_namePrefix
=== CONT  TestAccAWSSQSQueue_basic
=== CONT  TestAccAWSSQSQueue_queueDeletedRecently
=== CONT  TestAccAWSSQSQueue_namePrefix_fifo
=== CONT  TestAccAWSSQSQueuePolicy_disappears
=== CONT  TestAccAWSSQSQueue_tags
--- PASS: TestAccAWSSQSQueue_FIFOExpectNameError (11.06s)
--- PASS: TestAccAWSSQSQueue_ExpectContentBasedDeduplicationError (11.85s)
--- PASS: TestAccAWSSQSQueuePolicy_disappears_queue (25.90s)
--- PASS: TestAccAWSSQSQueuePolicy_disappears (31.18s)
--- PASS: TestAccAWSSQSQueue_FIFO_MinusName (32.58s)
--- PASS: TestAccAWSSQSQueue_FIFOWithContentBasedDeduplication (32.79s)
--- PASS: TestAccAWSSQSQueue_Encryption (33.02s)
--- PASS: TestAccAWSSQSQueue_FIFO (33.16s)
--- PASS: TestAccAWSSQSQueue_namePrefix_fifo (33.22s)
--- PASS: TestAccAWSSQSQueue_namePrefix (33.38s)
--- PASS: TestAccAWSSQSQueue_redrivePolicy (33.59s)
--- PASS: TestAccAWSSQSQueue_Policybasic (35.33s)
--- PASS: TestAccAWSSQSQueue_policy (35.86s)
--- PASS: TestAccAWSSQSQueuePolicy_basic (39.98s)
--- PASS: TestAccAWSSQSQueue_queueDeletedRecently (40.16s)
--- PASS: TestAccAWSSQSQueue_basic (50.78s)
--- PASS: TestAccAWSSQSQueue_tags (50.83s)
PASS
ok      github.com/terraform-providers/terraform-provider-aws/aws       50.937s

...

ewbankkit · 2021-01-19T13:59:47Z

Should do something similar for SNS FIFO topics: #15828.
Suggest converting this code to use the name generation functionality in aws/internal/naming/naming.go: #15694.
Could add a new function naming.GenerateWithSuffix(name, namePrefix, nameSuffix string).

drexler · 2021-01-26T17:59:21Z

Should do something similar for SNS FIFO topics: #15828.
Suggest converting this code to use the name generation functionality in aws/internal/naming/naming.go: #15694.
Could add a new function naming.GenerateWithSuffix(name, namePrefix, nameSuffix string).

@ewbankkit Thanks. I'll update this PR with your suggestions. 👍

…aws_sns_topic (hashicorp#15828). Acceptance test output: % make testacc TEST=./aws TESTARGS='-run=TestAccAWSSQSQueue_' ACCTEST_PARALLELISM=4 ==> Checking that code complies with gofmt requirements... TF_ACC=1 go test ./aws -v -count 1 -parallel 4 -run=TestAccAWSSQSQueue_ -timeout 180m === RUN TestAccAWSSQSQueue_basic === PAUSE TestAccAWSSQSQueue_basic === RUN TestAccAWSSQSQueue_tags === PAUSE TestAccAWSSQSQueue_tags === RUN TestAccAWSSQSQueue_namePrefix === PAUSE TestAccAWSSQSQueue_namePrefix === RUN TestAccAWSSQSQueue_namePrefix_fifo === PAUSE TestAccAWSSQSQueue_namePrefix_fifo === RUN TestAccAWSSQSQueue_policy === PAUSE TestAccAWSSQSQueue_policy === RUN TestAccAWSSQSQueue_queueDeletedRecently === PAUSE TestAccAWSSQSQueue_queueDeletedRecently === RUN TestAccAWSSQSQueue_redrivePolicy === PAUSE TestAccAWSSQSQueue_redrivePolicy === RUN TestAccAWSSQSQueue_Policybasic === PAUSE TestAccAWSSQSQueue_Policybasic === RUN TestAccAWSSQSQueue_FIFO === PAUSE TestAccAWSSQSQueue_FIFO === RUN TestAccAWSSQSQueue_FIFOExpectNameError === PAUSE TestAccAWSSQSQueue_FIFOExpectNameError === RUN TestAccAWSSQSQueue_FIFOWithContentBasedDeduplication === PAUSE TestAccAWSSQSQueue_FIFOWithContentBasedDeduplication === RUN TestAccAWSSQSQueue_ExpectContentBasedDeduplicationError === PAUSE TestAccAWSSQSQueue_ExpectContentBasedDeduplicationError === RUN TestAccAWSSQSQueue_Encryption === PAUSE TestAccAWSSQSQueue_Encryption === RUN TestAccAWSSQSQueue_FIFO_MinusName === PAUSE TestAccAWSSQSQueue_FIFO_MinusName === CONT TestAccAWSSQSQueue_basic === CONT TestAccAWSSQSQueue_FIFO === CONT TestAccAWSSQSQueue_Encryption === CONT TestAccAWSSQSQueue_policy --- PASS: TestAccAWSSQSQueue_FIFO (14.10s) === CONT TestAccAWSSQSQueue_Policybasic --- PASS: TestAccAWSSQSQueue_Encryption (14.34s) === CONT TestAccAWSSQSQueue_redrivePolicy --- PASS: TestAccAWSSQSQueue_redrivePolicy (14.96s) === CONT TestAccAWSSQSQueue_queueDeletedRecently --- PASS: TestAccAWSSQSQueue_basic (33.02s) === CONT TestAccAWSSQSQueue_FIFOWithContentBasedDeduplication --- PASS: TestAccAWSSQSQueue_FIFOWithContentBasedDeduplication (11.85s) === CONT TestAccAWSSQSQueue_ExpectContentBasedDeduplicationError --- PASS: TestAccAWSSQSQueue_ExpectContentBasedDeduplicationError (1.64s) === CONT TestAccAWSSQSQueue_namePrefix_fifo --- PASS: TestAccAWSSQSQueue_queueDeletedRecently (17.96s) === CONT TestAccAWSSQSQueue_FIFOExpectNameError --- PASS: TestAccAWSSQSQueue_FIFOExpectNameError (1.59s) === CONT TestAccAWSSQSQueue_FIFO_MinusName --- PASS: TestAccAWSSQSQueue_namePrefix_fifo (13.39s) === CONT TestAccAWSSQSQueue_tags --- PASS: TestAccAWSSQSQueue_FIFO_MinusName (13.12s) === CONT TestAccAWSSQSQueue_namePrefix --- PASS: TestAccAWSSQSQueue_policy (66.36s) --- PASS: TestAccAWSSQSQueue_namePrefix (11.90s) --- PASS: TestAccAWSSQSQueue_Policybasic (64.42s) --- PASS: TestAccAWSSQSQueue_tags (30.27s) PASS ok github.com/terraform-providers/terraform-provider-aws/aws 94.367s

Acceptance test output: % make testacc TEST=./aws TESTARGS='-run=TestAccAWSSQSQueue_' ACCTEST_PARALLELISM=4 ==> Checking that code complies with gofmt requirements... TF_ACC=1 go test ./aws -v -count 1 -parallel 4 -run=TestAccAWSSQSQueue_ -timeout 180m === RUN TestAccAWSSQSQueue_basic === PAUSE TestAccAWSSQSQueue_basic === RUN TestAccAWSSQSQueue_tags === PAUSE TestAccAWSSQSQueue_tags === RUN TestAccAWSSQSQueue_Name_Generated === PAUSE TestAccAWSSQSQueue_Name_Generated === RUN TestAccAWSSQSQueue_Name_Generated_FIFOQueue === PAUSE TestAccAWSSQSQueue_Name_Generated_FIFOQueue === RUN TestAccAWSSQSQueue_NamePrefix === PAUSE TestAccAWSSQSQueue_NamePrefix === RUN TestAccAWSSQSQueue_NamePrefix_FIFOQueue === PAUSE TestAccAWSSQSQueue_NamePrefix_FIFOQueue === RUN TestAccAWSSQSQueue_policy === PAUSE TestAccAWSSQSQueue_policy === RUN TestAccAWSSQSQueue_queueDeletedRecently === PAUSE TestAccAWSSQSQueue_queueDeletedRecently === RUN TestAccAWSSQSQueue_redrivePolicy === PAUSE TestAccAWSSQSQueue_redrivePolicy === RUN TestAccAWSSQSQueue_Policybasic === PAUSE TestAccAWSSQSQueue_Policybasic === RUN TestAccAWSSQSQueue_FIFO === PAUSE TestAccAWSSQSQueue_FIFO === RUN TestAccAWSSQSQueue_FIFOExpectNameError === PAUSE TestAccAWSSQSQueue_FIFOExpectNameError === RUN TestAccAWSSQSQueue_FIFOWithContentBasedDeduplication === PAUSE TestAccAWSSQSQueue_FIFOWithContentBasedDeduplication === RUN TestAccAWSSQSQueue_ExpectContentBasedDeduplicationError === PAUSE TestAccAWSSQSQueue_ExpectContentBasedDeduplicationError === RUN TestAccAWSSQSQueue_Encryption === PAUSE TestAccAWSSQSQueue_Encryption === CONT TestAccAWSSQSQueue_basic === CONT TestAccAWSSQSQueue_redrivePolicy === CONT TestAccAWSSQSQueue_NamePrefix === CONT TestAccAWSSQSQueue_queueDeletedRecently --- PASS: TestAccAWSSQSQueue_NamePrefix (14.27s) === CONT TestAccAWSSQSQueue_policy --- PASS: TestAccAWSSQSQueue_redrivePolicy (16.99s) === CONT TestAccAWSSQSQueue_Name_Generated --- PASS: TestAccAWSSQSQueue_queueDeletedRecently (20.58s) === CONT TestAccAWSSQSQueue_Name_Generated_FIFOQueue --- PASS: TestAccAWSSQSQueue_Name_Generated (12.20s) === CONT TestAccAWSSQSQueue_FIFOWithContentBasedDeduplication --- PASS: TestAccAWSSQSQueue_Name_Generated_FIFOQueue (12.84s) === CONT TestAccAWSSQSQueue_NamePrefix_FIFOQueue --- PASS: TestAccAWSSQSQueue_basic (34.10s) === CONT TestAccAWSSQSQueue_tags --- PASS: TestAccAWSSQSQueue_FIFOWithContentBasedDeduplication (13.36s) === CONT TestAccAWSSQSQueue_ExpectContentBasedDeduplicationError --- PASS: TestAccAWSSQSQueue_ExpectContentBasedDeduplicationError (1.61s) === CONT TestAccAWSSQSQueue_Encryption --- PASS: TestAccAWSSQSQueue_NamePrefix_FIFOQueue (12.78s) === CONT TestAccAWSSQSQueue_FIFO --- PASS: TestAccAWSSQSQueue_Encryption (11.97s) === CONT TestAccAWSSQSQueue_FIFOExpectNameError --- PASS: TestAccAWSSQSQueue_FIFOExpectNameError (1.62s) === CONT TestAccAWSSQSQueue_Policybasic --- PASS: TestAccAWSSQSQueue_FIFO (11.88s) --- PASS: TestAccAWSSQSQueue_tags (30.67s) --- PASS: TestAccAWSSQSQueue_policy (64.88s) --- PASS: TestAccAWSSQSQueue_Policybasic (63.94s) PASS ok github.com/terraform-providers/terraform-provider-aws/aws 124.792s

…n acceptance tests. Acceptance test output: % make testacc TEST=./aws TESTARGS='-run=TestAccAWSSNSTopic_' ACCTEST_PARALLELISM=4 ==> Checking that code complies with gofmt requirements... TF_ACC=1 go test ./aws -v -count 1 -parallel 4 -run=TestAccAWSSNSTopic_ -timeout 180m === RUN TestAccAWSSNSTopic_basic === PAUSE TestAccAWSSNSTopic_basic === RUN TestAccAWSSNSTopic_Name === PAUSE TestAccAWSSNSTopic_Name === RUN TestAccAWSSNSTopic_NamePrefix === PAUSE TestAccAWSSNSTopic_NamePrefix === RUN TestAccAWSSNSTopic_policy === PAUSE TestAccAWSSNSTopic_policy === RUN TestAccAWSSNSTopic_withIAMRole === PAUSE TestAccAWSSNSTopic_withIAMRole === RUN TestAccAWSSNSTopic_withFakeIAMRole === PAUSE TestAccAWSSNSTopic_withFakeIAMRole === RUN TestAccAWSSNSTopic_withDeliveryPolicy === PAUSE TestAccAWSSNSTopic_withDeliveryPolicy === RUN TestAccAWSSNSTopic_deliveryStatus === PAUSE TestAccAWSSNSTopic_deliveryStatus === RUN TestAccAWSSNSTopic_Name_Generated_FIFOTopic === PAUSE TestAccAWSSNSTopic_Name_Generated_FIFOTopic === RUN TestAccAWSSNSTopic_Name_FIFOTopic === PAUSE TestAccAWSSNSTopic_Name_FIFOTopic === RUN TestAccAWSSNSTopic_NamePrefix_FIFOTopic === PAUSE TestAccAWSSNSTopic_NamePrefix_FIFOTopic === RUN TestAccAWSSNSTopic_FIFOWithContentBasedDeduplication === PAUSE TestAccAWSSNSTopic_FIFOWithContentBasedDeduplication === RUN TestAccAWSSNSTopic_FIFOExpectContentBasedDeduplicationError === PAUSE TestAccAWSSNSTopic_FIFOExpectContentBasedDeduplicationError === RUN TestAccAWSSNSTopic_encryption === PAUSE TestAccAWSSNSTopic_encryption === RUN TestAccAWSSNSTopic_tags === PAUSE TestAccAWSSNSTopic_tags === CONT TestAccAWSSNSTopic_basic === CONT TestAccAWSSNSTopic_Name_Generated_FIFOTopic === CONT TestAccAWSSNSTopic_FIFOWithContentBasedDeduplication === CONT TestAccAWSSNSTopic_FIFOExpectContentBasedDeduplicationError --- PASS: TestAccAWSSNSTopic_FIFOExpectContentBasedDeduplicationError (3.24s) === CONT TestAccAWSSNSTopic_NamePrefix_FIFOTopic --- PASS: TestAccAWSSNSTopic_basic (17.44s) === CONT TestAccAWSSNSTopic_Name_FIFOTopic --- PASS: TestAccAWSSNSTopic_Name_Generated_FIFOTopic (17.45s) === CONT TestAccAWSSNSTopic_withIAMRole --- PASS: TestAccAWSSNSTopic_NamePrefix_FIFOTopic (16.26s) === CONT TestAccAWSSNSTopic_deliveryStatus --- PASS: TestAccAWSSNSTopic_FIFOWithContentBasedDeduplication (29.43s) === CONT TestAccAWSSNSTopic_withDeliveryPolicy --- PASS: TestAccAWSSNSTopic_Name_FIFOTopic (13.79s) === CONT TestAccAWSSNSTopic_withFakeIAMRole --- PASS: TestAccAWSSNSTopic_withIAMRole (23.62s) === CONT TestAccAWSSNSTopic_Name --- PASS: TestAccAWSSNSTopic_withDeliveryPolicy (14.49s) === CONT TestAccAWSSNSTopic_policy --- PASS: TestAccAWSSNSTopic_deliveryStatus (34.30s) === CONT TestAccAWSSNSTopic_tags --- PASS: TestAccAWSSNSTopic_Name (13.55s) === CONT TestAccAWSSNSTopic_NamePrefix --- PASS: TestAccAWSSNSTopic_policy (15.40s) === CONT TestAccAWSSNSTopic_encryption --- PASS: TestAccAWSSNSTopic_NamePrefix (13.83s) --- PASS: TestAccAWSSNSTopic_encryption (26.86s) --- PASS: TestAccAWSSNSTopic_tags (38.04s) --- PASS: TestAccAWSSNSTopic_withFakeIAMRole (125.75s) PASS ok github.com/terraform-providers/terraform-provider-aws/aws 160.023s

ewbankkit · 2021-04-15T20:43:59Z

@drexler Thanks for the contribution 👏.
I took the liberty of rebasing and making naming changes similar to those for SNS FIFO topics (#15828).

ewbankkit

LGTM.

Acceptance test output

Commercial

--- PASS: TestAccAWSSQSQueue_Encryption (14.77s)
--- PASS: TestAccAWSSQSQueue_ExpectContentBasedDeduplicationError (1.72s)
--- PASS: TestAccAWSSNSTopic_basic (16.80s)
--- PASS: TestAccAWSSQSQueue_FIFOExpectNameError (1.63s)
--- PASS: TestAccAWSSQSQueue_FIFOWithContentBasedDeduplication (11.88s)
--- PASS: TestAccAWSSQSQueue_FIFO (11.97s)
--- PASS: TestAccAWSSQSQueue_tags (33.93s)
--- PASS: TestAccAWSSNSTopic_Name_Generated_FIFOTopic (13.70s)
--- PASS: TestAccAWSSNSTopic_withIAMRole (23.54s)
--- PASS: TestAccAWSSQSQueue_basic (31.91s)
--- PASS: TestAccAWSSQSQueue_Policybasic (66.90s)
--- PASS: TestAccAWSSNSTopic_deliveryStatus (29.88s)
--- PASS: TestAccAWSSNSTopic_withDeliveryPolicy (14.34s)
--- PASS: TestAccAWSSNSTopic_FIFOExpectContentBasedDeduplicationError (1.65s)
--- PASS: TestAccAWSSNSTopic_tags (37.41s)
--- PASS: TestAccAWSSNSTopic_FIFOWithContentBasedDeduplication (25.47s)
--- PASS: TestAccAWSSQSQueue_queueDeletedRecently (18.44s)
--- PASS: TestAccAWSSQSQueue_redrivePolicy (14.43s)
--- PASS: TestAccAWSSNSTopic_NamePrefix_FIFOTopic (13.71s)
--- PASS: TestAccAWSSNSTopic_Name_FIFOTopic (15.97s)
--- PASS: TestAccAWSSNSTopic_encryption (27.08s)
--- PASS: TestAccAWSSQSQueue_NamePrefix_FIFOQueue (13.98s)
--- PASS: TestAccAWSSQSQueue_Name_Generated (12.38s)
--- PASS: TestAccAWSSNSTopic_NamePrefix (13.69s)
--- PASS: TestAccAWSSQSQueue_Name_Generated_FIFOQueue (11.91s)
--- PASS: TestAccAWSSNSTopic_policy (15.38s)
--- PASS: TestAccAWSSQSQueue_NamePrefix (12.08s)
--- PASS: TestAccAWSSNSTopic_Name (13.73s)
--- PASS: TestAccAWSSNSTopic_withFakeIAMRole (125.55s)
--- PASS: TestAccAWSSQSQueue_policy (64.10s)

GovCloud

--- PASS: TestAccAWSSQSQueue_ExpectContentBasedDeduplicationError (4.22s)
--- PASS: TestAccAWSSQSQueue_Encryption (18.32s)
--- PASS: TestAccAWSSQSQueue_FIFOWithContentBasedDeduplication (16.20s)
--- PASS: TestAccAWSSQSQueue_FIFOExpectNameError (2.13s)
--- PASS: TestAccAWSSNSTopic_basic (20.48s)
--- PASS: TestAccAWSSQSQueue_FIFO (16.64s)
--- PASS: TestAccAWSSQSQueue_redrivePolicy (20.01s)
--- PASS: TestAccAWSSQSQueue_tags (46.35s)
--- PASS: TestAccAWSSQSQueue_NamePrefix_FIFOQueue (15.91s)
--- PASS: TestAccAWSSQSQueue_queueDeletedRecently (27.00s)
--- PASS: TestAccAWSSQSQueue_NamePrefix (16.24s)
--- PASS: TestAccAWSSQSQueue_Name_Generated_FIFOQueue (16.26s)
--- FAIL: TestAccAWSSNSTopic_Name_Generated_FIFOTopic (4.01s)
--- PASS: TestAccAWSSQSQueue_Policybasic (71.18s)
--- PASS: TestAccAWSSQSQueue_Name_Generated (17.25s)
--- PASS: TestAccAWSSQSQueue_policy (69.93s)
--- FAIL: TestAccAWSSQSQueue_basic (27.75s)
--- PASS: TestAccAWSSNSTopic_FIFOExpectContentBasedDeduplicationError (2.24s)
--- FAIL: TestAccAWSSNSTopic_FIFOWithContentBasedDeduplication (4.09s) 
--- FAIL: TestAccAWSSNSTopic_NamePrefix_FIFOTopic (4.10s)
--- FAIL: TestAccAWSSNSTopic_Name_FIFOTopic (4.16s)
--- PASS: TestAccAWSSNSTopic_encryption (35.77s)
--- PASS: TestAccAWSSNSTopic_tags (50.52s)
--- PASS: TestAccAWSSNSTopic_withIAMRole (27.06s)
--- PASS: TestAccAWSSNSTopic_withDeliveryPolicy (18.96s)
--- PASS: TestAccAWSSNSTopic_deliveryStatus (33.81s)
--- PASS: TestAccAWSSNSTopic_NamePrefix (20.43s)
--- PASS: TestAccAWSSNSTopic_policy (21.95s)
--- PASS: TestAccAWSSNSTopic_Name (20.13s)
--- PASS: TestAccAWSSNSTopic_withFakeIAMRole (127.89s)

Failures are pre-existing.

Add CHANGELOG entry for #17164

ghost · 2021-04-16T16:35:16Z

This has been released in version 3.37.0 of the Terraform AWS provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template for triage. Thanks!

drexler · 2021-04-20T13:11:45Z

@ewbankkit Thanks for taking care of this. 👍

ghost · 2021-05-16T17:10:06Z

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. Thanks!

drexler requested a review from a team as a code owner January 19, 2021 03:00

ghost added size/S Managed by automation to categorize the size of a PR. service/sqs Issues and PRs that pertain to the sqs service. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure. labels Jan 19, 2021

github-actions bot added the needs-triage Waiting for first response or review from a maintainer. label Jan 19, 2021

ewbankkit mentioned this pull request Jan 19, 2021

Add support for Amazon SNS FIFO Topics #15828

Merged

Base automatically changed from master to main January 23, 2021 01:00

chris-burkhardt mentioned this pull request Feb 14, 2021

Amazon SNS FIFO topics #15805

Closed

ewbankkit self-assigned this Apr 14, 2021

ewbankkit removed the needs-triage Waiting for first response or review from a maintainer. label Apr 14, 2021

drexler and others added 3 commits April 15, 2021 09:41

fix: append .fifo suffix for FIFO queue if name unspecified

1917920

test: add test for unnamed fifo queues

a1e946e

ewbankkit force-pushed the sqs-fifo-fix branch from dc349ba to b6f347e Compare April 15, 2021 13:53

ghost added size/L Managed by automation to categorize the size of a PR. documentation Introduces or discusses updates to documentation. and removed size/S Managed by automation to categorize the size of a PR. labels Apr 15, 2021

ghost added the service/sns Issues and PRs that pertain to the sns service. label Apr 15, 2021

ewbankkit force-pushed the sqs-fifo-fix branch from 2fac50f to 80d2ac4 Compare April 15, 2021 15:16

ghost added size/XL Managed by automation to categorize the size of a PR. and removed size/L Managed by automation to categorize the size of a PR. labels Apr 15, 2021

ewbankkit approved these changes Apr 15, 2021

View reviewed changes

ewbankkit merged commit f47d5cb into hashicorp:main Apr 15, 2021

github-actions bot added this to the v3.37.0 milestone Apr 15, 2021

ewbankkit added a commit that referenced this pull request Apr 15, 2021

Add CHANGELOG entry for #17164.

b2d97bd

ewbankkit mentioned this pull request Apr 15, 2021

Add CHANGELOG entry for #17164 #18908

Merged

anGie44 added a commit that referenced this pull request Apr 15, 2021

Merge pull request #18908 from hashicorp/td-changelog-for-17164

5badb7f

Add CHANGELOG entry for #17164

ghost locked as resolved and limited conversation to collaborators May 16, 2021

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

r/aws_sqs_queue: append .fifo suffix for FIFO queue if name unspecified #17164

r/aws_sqs_queue: append .fifo suffix for FIFO queue if name unspecified #17164

drexler commented Jan 19, 2021

ewbankkit commented Jan 19, 2021

drexler commented Jan 26, 2021

ewbankkit commented Apr 15, 2021

ewbankkit left a comment

ghost commented Apr 16, 2021

drexler commented Apr 20, 2021

ghost commented May 16, 2021

r/aws_sqs_queue: append .fifo suffix for FIFO queue if name unspecified #17164

r/aws_sqs_queue: append .fifo suffix for FIFO queue if name unspecified #17164

Conversation

drexler commented Jan 19, 2021

Community Note

ewbankkit commented Jan 19, 2021

drexler commented Jan 26, 2021

ewbankkit commented Apr 15, 2021

ewbankkit left a comment

Choose a reason for hiding this comment

Acceptance test output

Commercial

GovCloud

ghost commented Apr 16, 2021

drexler commented Apr 20, 2021

ghost commented May 16, 2021