Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

r/sagemaker_app_image_config - new resource #17221

Merged
merged 21 commits into from
Jan 28, 2021

Conversation

DrFaust92
Copy link
Collaborator

@DrFaust92 DrFaust92 commented Jan 21, 2021

Community Note

  • Please vote on this pull request by adding a 👍 reaction to the original pull request comment to help the community and maintainers prioritize this request
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for pull request followers and do not help prioritize the request

Release note for CHANGELOG:

Output from acceptance testing:

$ make testacc TESTARGS='-run=TestAccAWSSagemakerAppImageConfig_'
--- PASS: TestAccAWSSagemakerAppImageConfig_basic (36.17s)
--- PASS: TestAccAWSSagemakerAppImageConfig_disappears (21.47s)
--- PASS: TestAccAWSSagemakerAppImageConfig_kernelGatewayImageConfig_fileSystemConfig (60.59s)
--- PASS: TestAccAWSSagemakerAppImageConfig_kernelGatewayImageConfig_kernalSpecs (59.63s)

@ghost ghost added size/XL Managed by automation to categorize the size of a PR. documentation Introduces or discusses updates to documentation. provider Pertains to the provider itself, rather than any interaction with AWS. service/sagemaker Issues and PRs that pertain to the sagemaker service. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure. labels Jan 21, 2021
Base automatically changed from master to main January 23, 2021 01:00
@DrFaust92 DrFaust92 added the new-resource Introduces a new resource. label Jan 23, 2021
@DrFaust92 DrFaust92 marked this pull request as ready for review January 23, 2021 11:28
@DrFaust92 DrFaust92 requested a review from a team as a code owner January 23, 2021 11:28
@DrFaust92
Copy link
Collaborator Author

Tags test is being weird and causes a loop of InternalFailure errors. does not reproduce for other tests. possibly related to #15572

Copy link
Contributor

@ewbankkit ewbankkit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

$ make testacc TEST=./aws TESTARGS='-run=TestAccAWSSagemakerAppImageConfig_'
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./aws -v -count 1 -parallel 20 -run=TestAccAWSSagemakerAppImageConfig_ -timeout 120m
=== RUN   TestAccAWSSagemakerAppImageConfig_basic
=== PAUSE TestAccAWSSagemakerAppImageConfig_basic
=== RUN   TestAccAWSSagemakerAppImageConfig_kernelGatewayImageConfig_kernalSpecs
=== PAUSE TestAccAWSSagemakerAppImageConfig_kernelGatewayImageConfig_kernalSpecs
=== RUN   TestAccAWSSagemakerAppImageConfig_kernelGatewayImageConfig_fileSystemConfig
=== PAUSE TestAccAWSSagemakerAppImageConfig_kernelGatewayImageConfig_fileSystemConfig
=== RUN   TestAccAWSSagemakerAppImageConfig_tags
    resource_aws_sagemaker_app_image_config_test.go:193: Flaky Test, possibly related to https://github.com/hashicorp/terraform-provider-aws/issues/15572
--- SKIP: TestAccAWSSagemakerAppImageConfig_tags (0.00s)
=== RUN   TestAccAWSSagemakerAppImageConfig_disappears
=== PAUSE TestAccAWSSagemakerAppImageConfig_disappears
=== CONT  TestAccAWSSagemakerAppImageConfig_basic
=== CONT  TestAccAWSSagemakerAppImageConfig_disappears
=== CONT  TestAccAWSSagemakerAppImageConfig_kernelGatewayImageConfig_fileSystemConfig
=== CONT  TestAccAWSSagemakerAppImageConfig_kernelGatewayImageConfig_kernalSpecs
--- PASS: TestAccAWSSagemakerAppImageConfig_disappears (12.95s)
--- PASS: TestAccAWSSagemakerAppImageConfig_basic (18.16s)
--- PASS: TestAccAWSSagemakerAppImageConfig_kernelGatewayImageConfig_fileSystemConfig (28.82s)
--- PASS: TestAccAWSSagemakerAppImageConfig_kernelGatewayImageConfig_kernalSpecs (31.25s)
PASS
ok  	github.com/terraform-providers/terraform-provider-aws/aws	31.369s

@ewbankkit
Copy link
Contributor

If deleting a previously tagged App Image Config causes problems - I get that with the CLI too:

$ aws --region us-west-2 sagemaker delete-app-image-config --app-image-config-name tf-acc-test-8058719989336263580

An error occurred (InternalFailure) when calling the DeleteAppImageConfig operation (reached max retries: 4):

do you think it would be better to remove the tags attribute and associated logic for now, open a new Issue here and also an AWS Support issue? This would prevent problems for operators.

@DrFaust92
Copy link
Collaborator Author

Thanks @ewbankkit, opened a follow up issue and remove tagging logic for now:

--- PASS: TestAccAWSSagemakerAppImageConfig_basic (32.83s)
--- PASS: TestAccAWSSagemakerAppImageConfig_kernelGatewayImageConfig_fileSystemConfig (52.96s)
--- PASS: TestAccAWSSagemakerAppImageConfig_disappears (20.76s)
--- PASS: TestAccAWSSagemakerAppImageConfig_kernelGatewayImageConfig_kernalSpecs (53.68s)

Copy link
Contributor

@ewbankkit ewbankkit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

$ make testacc TEST=./aws TESTARGS='-run=TestAccAWSSagemakerAppImageConfig_'
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./aws -v -count 1 -parallel 20 -run=TestAccAWSSagemakerAppImageConfig_ -timeout 120m
=== RUN   TestAccAWSSagemakerAppImageConfig_basic
=== PAUSE TestAccAWSSagemakerAppImageConfig_basic
=== RUN   TestAccAWSSagemakerAppImageConfig_kernelGatewayImageConfig_kernalSpecs
=== PAUSE TestAccAWSSagemakerAppImageConfig_kernelGatewayImageConfig_kernalSpecs
=== RUN   TestAccAWSSagemakerAppImageConfig_kernelGatewayImageConfig_fileSystemConfig
=== PAUSE TestAccAWSSagemakerAppImageConfig_kernelGatewayImageConfig_fileSystemConfig
=== RUN   TestAccAWSSagemakerAppImageConfig_disappears
=== PAUSE TestAccAWSSagemakerAppImageConfig_disappears
=== CONT  TestAccAWSSagemakerAppImageConfig_basic
=== CONT  TestAccAWSSagemakerAppImageConfig_disappears
=== CONT  TestAccAWSSagemakerAppImageConfig_kernelGatewayImageConfig_fileSystemConfig
=== CONT  TestAccAWSSagemakerAppImageConfig_kernelGatewayImageConfig_kernalSpecs
--- PASS: TestAccAWSSagemakerAppImageConfig_disappears (12.66s)
--- PASS: TestAccAWSSagemakerAppImageConfig_basic (17.78s)
--- PASS: TestAccAWSSagemakerAppImageConfig_kernelGatewayImageConfig_fileSystemConfig (27.71s)
--- PASS: TestAccAWSSagemakerAppImageConfig_kernelGatewayImageConfig_kernalSpecs (32.45s)
PASS
ok  	github.com/terraform-providers/terraform-provider-aws/aws	32.550s

@breathingdust
Copy link
Member

LGTM 🚀 Thanks @DrFaust92

Verified Acceptance Tests in Commercial (us-west-2)

make testacc TEST=./aws TESTARGS='-run=TestAccAWSSagemakerAppImageConfig_'
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./aws -v -count 1 -parallel 20 -run=TestAccAWSSagemakerAppImageConfig_ -timeout 120m
=== RUN   TestAccAWSSagemakerAppImageConfig_basic
=== PAUSE TestAccAWSSagemakerAppImageConfig_basic
=== RUN   TestAccAWSSagemakerAppImageConfig_kernelGatewayImageConfig_kernalSpecs
=== PAUSE TestAccAWSSagemakerAppImageConfig_kernelGatewayImageConfig_kernalSpecs
=== RUN   TestAccAWSSagemakerAppImageConfig_kernelGatewayImageConfig_fileSystemConfig
=== PAUSE TestAccAWSSagemakerAppImageConfig_kernelGatewayImageConfig_fileSystemConfig
=== RUN   TestAccAWSSagemakerAppImageConfig_disappears
=== PAUSE TestAccAWSSagemakerAppImageConfig_disappears
=== CONT  TestAccAWSSagemakerAppImageConfig_basic
=== CONT  TestAccAWSSagemakerAppImageConfig_disappears
=== CONT  TestAccAWSSagemakerAppImageConfig_kernelGatewayImageConfig_fileSystemConfig
=== CONT  TestAccAWSSagemakerAppImageConfig_kernelGatewayImageConfig_kernalSpecs
--- PASS: TestAccAWSSagemakerAppImageConfig_disappears (10.07s)
--- PASS: TestAccAWSSagemakerAppImageConfig_basic (13.19s)
--- PASS: TestAccAWSSagemakerAppImageConfig_kernelGatewayImageConfig_fileSystemConfig (21.64s)
--- PASS: TestAccAWSSagemakerAppImageConfig_kernelGatewayImageConfig_kernalSpecs (24.82s)
PASS
ok  	github.com/terraform-providers/terraform-provider-aws/aws	26.431s

As this feature is part of Sagemaker studio, this will not work in GovCloud. I will create an issue and link back to cover enabling the test to skip in that region.

@breathingdust breathingdust merged commit 2481804 into hashicorp:main Jan 28, 2021
@github-actions github-actions bot added this to the v3.26.0 milestone Jan 28, 2021
@ghost
Copy link

ghost commented Jan 28, 2021

This has been released in version 3.26.0 of the Terraform AWS provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template for triage. Thanks!

@ghost
Copy link

ghost commented Feb 28, 2021

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. Thanks!

@ghost ghost locked as resolved and limited conversation to collaborators Feb 28, 2021
@DrFaust92 DrFaust92 deleted the r/sagemaker_app_image_config branch April 15, 2021 10:36
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
documentation Introduces or discusses updates to documentation. new-resource Introduces a new resource. provider Pertains to the provider itself, rather than any interaction with AWS. service/sagemaker Issues and PRs that pertain to the sagemaker service. size/XL Managed by automation to categorize the size of a PR. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants