Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sagemaker App Image Config - add tagging support #17267

Closed
DrFaust92 opened this issue Jan 24, 2021 · 4 comments · Fixed by #21037
Closed

Sagemaker App Image Config - add tagging support #17267

DrFaust92 opened this issue Jan 24, 2021 · 4 comments · Fixed by #21037
Labels
enhancement Requests to existing resources that expand the functionality or scope. service/sagemaker Issues and PRs that pertain to the sagemaker service.
Milestone

Comments

@DrFaust92
Copy link
Collaborator

Community Note

  • Please vote on this issue by adding a 👍 reaction to the original issue to help the community and maintainers prioritize this request
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for issue followers and do not help prioritize the request
  • If you are interested in working on this issue or have submitted a pull request, please leave a comment

Description

A follow-up issue to #17221, to support tagging. currently there is a server side bug with deleting tagged Sagemaker App Image configs (see #17221 (comment))

New or Affected Resource(s)

  • aws_sagemaker_app_image_config

Potential Terraform Configuration

# Copy-paste your Terraform configurations here - for large Terraform configs,
# please use a service like Dropbox and share a link to the ZIP file. For
# security, you can also encrypt the files using our GPG public key.

References

@DrFaust92 DrFaust92 added the enhancement Requests to existing resources that expand the functionality or scope. label Jan 24, 2021
@ghost ghost added the service/sagemaker Issues and PRs that pertain to the sagemaker service. label Jan 24, 2021
@maciej-wilczynski
Copy link

Also documentation says that tags are optional here but the truth is:

Error: Unsupported argument

  on sage_maker_image.tf line 21, in resource "aws_sagemaker_app_image_config" "image_config":
  21:   tags = {

An argument named "tags" is not expected here.

and there is no argument in https://github.com/hashicorp/terraform-provider-aws/blob/v3.29.1/aws/resource_aws_sagemaker_app_image_config.go#L25

@DrFaust92
Copy link
Collaborator Author

probably a leftover from when i tried to implement. sorry! need to be deleted from docs

@github-actions
Copy link

github-actions bot commented Oct 7, 2021

This functionality has been released in v3.61.0 of the Terraform AWS Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

@github-actions
Copy link

github-actions bot commented Jun 4, 2022

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems similar to this, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jun 4, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
enhancement Requests to existing resources that expand the functionality or scope. service/sagemaker Issues and PRs that pertain to the sagemaker service.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants