Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

aws_elb_hosted_zone_id are wrong to the China region #17225

Closed
shell-autonomic-sh opened this issue Jan 21, 2021 · 3 comments · Fixed by #17226
Closed

aws_elb_hosted_zone_id are wrong to the China region #17225

shell-autonomic-sh opened this issue Jan 21, 2021 · 3 comments · Fixed by #17226
Assignees
Labels
bug Addresses a defect in current functionality. service/elb Issues and PRs that pertain to the elb service.
Milestone

Comments

@shell-autonomic-sh
Copy link
Contributor

Provider version 3.24.1, it's a bug in here.

https://github.com/hashicorp/terraform-provider-aws/blob/master/aws/data_source_aws_elb_hosted_zone_id.go#L23

I refer the data sheet from here.

https://docs.amazonaws.cn/en_us/general/latest/gr/elb.html

As we can see, the ID of China Ningxia Region (cn-northwest-1) is ZM7IZAIOVVDZF. But in the code it's Z3BX2TMKNYI13Y.

@github-actions github-actions bot added the needs-triage Waiting for first response or review from a maintainer. label Jan 21, 2021
shell-autonomic-sh added a commit to shell-autonomic-sh/terraform-provider-aws that referenced this issue Jan 21, 2021
@ewbankkit ewbankkit added service/elb Issues and PRs that pertain to the elb service. service/elbv2 Issues and PRs that pertain to the elbv2 service. bug Addresses a defect in current functionality. and removed needs-triage Waiting for first response or review from a maintainer. service/elbv2 Issues and PRs that pertain to the elbv2 service. labels Jan 21, 2021
@bflad bflad linked a pull request Jan 26, 2021 that will close this issue
@bflad bflad self-assigned this Jan 26, 2021
@bflad bflad added this to the v3.26.0 milestone Jan 26, 2021
@bflad
Copy link
Contributor

bflad commented Jan 26, 2021

The fix for this has been merged and will release with version 3.26.0 of the Terraform AWS Provider, later this week. Thank you to @shell-autonomic-sh for the implementation. 👍

@ghost
Copy link

ghost commented Jan 28, 2021

This has been released in version 3.26.0 of the Terraform AWS provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template for triage. Thanks!

@ghost
Copy link

ghost commented Feb 25, 2021

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. Thanks!

@ghost ghost locked as resolved and limited conversation to collaborators Feb 25, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Addresses a defect in current functionality. service/elb Issues and PRs that pertain to the elb service.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants