Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tests/service/sagemaker: Serialize or Enable Configurable Synchronization for Domain Testing #17402

Closed
bflad opened this issue Feb 2, 2021 · 3 comments · Fixed by #17251
Closed
Labels
service/sagemaker Issues and PRs that pertain to the sagemaker service. technical-debt Addresses areas of the codebase that need refactoring or redesign. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure.
Milestone

Comments

@bflad
Copy link
Contributor

bflad commented Feb 2, 2021

Community Note

  • Please vote on this issue by adding a 👍 reaction to the original issue to help the community and maintainers prioritize this request
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for issue followers and do not help prioritize the request
  • If you are interested in working on this issue or have submitted a pull request, please leave a comment

Description

Many of the SageMaker Domain and User Profile tests are failing in the main testing account:

=== CONT  TestAccAWSSagemakerDomain_kms
resource_aws_sagemaker_domain_test.go:109: Step 1/2 error: Error running apply:
Error: error creating SageMaker domain: ResourceLimitExceeded: The account-level service limit 'Total domains' is 1 Domains, with current utilization of 1 Domains and a request delta of 1 Domains. Please contact AWS support to request an increase for this limit.
--- FAIL: TestAccAWSSagemakerDomain_kms (31.54s)

=== CONT  TestAccAWSSagemakerDomain_tags
resource_aws_sagemaker_domain_test.go:135: Step 1/4 error: Error running apply:
Error: error creating SageMaker domain: ResourceLimitExceeded: The account-level service limit 'Total domains' is 1 Domains, with current utilization of 1 Domains and a request delta of 1 Domains. Please contact AWS support to request an increase for this limit.
--- FAIL: TestAccAWSSagemakerDomain_tags (28.42s)

=== CONT  TestAccAWSSagemakerDomain_sharingSettings
resource_aws_sagemaker_domain_test.go:214: Step 1/2 error: Error running apply:
Error: error creating SageMaker domain: ResourceLimitExceeded: The account-level service limit 'Total domains' is 1 Domains, with current utilization of 1 Domains and a request delta of 1 Domains. Please contact AWS support to request an increase for this limit.
--- FAIL: TestAccAWSSagemakerDomain_sharingSettings (28.79s)

=== CONT  TestAccAWSSagemakerDomain_securityGroup
resource_aws_sagemaker_domain_test.go:179: Step 1/3 error: Error running apply:
Error: error creating SageMaker domain: ResourceLimitExceeded: The account-level service limit 'Total domains' is 1 Domains, with current utilization of 1 Domains and a request delta of 1 Domains. Please contact AWS support to request an increase for this limit.
--- FAIL: TestAccAWSSagemakerDomain_securityGroup (30.11s)

=== CONT  TestAccAWSSagemakerDomain_tensorboardAppSettings
resource_aws_sagemaker_domain_test.go:244: Step 1/2 error: Error running apply:
Error: error creating SageMaker domain: ResourceLimitExceeded: The account-level service limit 'Total domains' is 1 Domains, with current utilization of 1 Domains and a request delta of 1 Domains. Please contact AWS support to request an increase for this limit.
--- FAIL: TestAccAWSSagemakerDomain_tensorboardAppSettings (30.00s)

=== CONT  TestAccAWSSagemakerDomain_kernelGatewayAppSettings
resource_aws_sagemaker_domain_test.go:303: Step 1/2 error: Error running apply:
Error: error creating SageMaker domain: ResourceLimitExceeded: The account-level service limit 'Total domains' is 1 Domains, with current utilization of 1 Domains and a request delta of 1 Domains. Please contact AWS support to request an increase for this limit.
--- FAIL: TestAccAWSSagemakerDomain_kernelGatewayAppSettings (27.80s)

=== CONT  TestAccAWSSagemakerDomain_jupyterServerAppSettings
resource_aws_sagemaker_domain_test.go:332: Step 1/2 error: Error running apply:
Error: error creating SageMaker domain: ResourceLimitExceeded: The account-level service limit 'Total domains' is 1 Domains, with current utilization of 1 Domains and a request delta of 1 Domains. Please contact AWS support to request an increase for this limit.
--- FAIL: TestAccAWSSagemakerDomain_jupyterServerAppSettings (27.20s)

=== CONT  TestAccAWSSagemakerDomain_disappears
resource_aws_sagemaker_domain_test.go:361: Step 1/1 error: Error running apply:
Error: error creating SageMaker domain: ResourceLimitExceeded: The account-level service limit 'Total domains' is 1 Domains, with current utilization of 1 Domains and a request delta of 1 Domains. Please contact AWS support to request an increase for this limit.
--- FAIL: TestAccAWSSagemakerDomain_disappears (26.42s)

=== CONT  TestAccAWSSagemakerDomain_tensorboardAppSettingsWithImage
resource_aws_sagemaker_domain_test.go:273: Step 1/2 error: Error running apply:
Error: error creating SageMaker domain: ResourceLimitExceeded: The account-level service limit 'Total domains' is 1 Domains, with current utilization of 1 Domains and a request delta of 1 Domains. Please contact AWS support to request an increase for this limit.
--- FAIL: TestAccAWSSagemakerDomain_tensorboardAppSettingsWithImage (86.05s)

=== CONT  TestAccAWSSagemakerUserProfile_tensorboardAppSettings
resource_aws_sagemaker_user_profile_test.go:145: Step 1/2 error: Error running apply:
Error: error creating SageMaker domain: ResourceLimitExceeded: The account-level service limit 'Total domains' is 1 Domains, with current utilization of 1 Domains and a request delta of 1 Domains. Please contact AWS support to request an increase for this limit.
--- FAIL: TestAccAWSSagemakerUserProfile_tensorboardAppSettings (15.31s)

=== CONT  TestAccAWSSagemakerUserProfile_kernelGatewayAppSettings
resource_aws_sagemaker_user_profile_test.go:204: Step 1/2 error: Error running apply:
Error: error creating SageMaker domain: ResourceLimitExceeded: The account-level service limit 'Total domains' is 1 Domains, with current utilization of 1 Domains and a request delta of 1 Domains. Please contact AWS support to request an increase for this limit.
--- FAIL: TestAccAWSSagemakerUserProfile_kernelGatewayAppSettings (9.07s)

=== CONT  TestAccAWSSagemakerUserProfile_jupyterServerAppSettings
resource_aws_sagemaker_user_profile_test.go:233: Step 1/2 error: Error running apply:
Error: error creating SageMaker domain: ResourceLimitExceeded: The account-level service limit 'Total domains' is 1 Domains, with current utilization of 1 Domains and a request delta of 1 Domains. Please contact AWS support to request an increase for this limit.
--- FAIL: TestAccAWSSagemakerUserProfile_jupyterServerAppSettings (8.69s)

=== CONT  TestAccAWSSagemakerUserProfile_disappears
resource_aws_sagemaker_user_profile_test.go:262: Step 1/1 error: Error running apply:
Error: error creating SageMaker domain: ResourceLimitExceeded: The account-level service limit 'Total domains' is 1 Domains, with current utilization of 1 Domains and a request delta of 1 Domains. Please contact AWS support to request an increase for this limit.
--- FAIL: TestAccAWSSagemakerUserProfile_disappears (8.49s)

=== CONT  TestAccAWSSagemakerUserProfile_tensorboardAppSettingsWithImage
resource_aws_sagemaker_user_profile_test.go:174: Step 1/2 error: Error running apply:
Error: error creating SageMaker domain: ResourceLimitExceeded: The account-level service limit 'Total domains' is 1 Domains, with current utilization of 1 Domains and a request delta of 1 Domains. Please contact AWS support to request an increase for this limit.
--- FAIL: TestAccAWSSagemakerUserProfile_tensorboardAppSettingsWithImage (69.80s)

The acceptance tests likely should be serialized for the default AWS limits so they can pass without special AWS account setup. Otherwise, the test synchronization limit should be looked up or configurable via environment variable.

Affected Resource(s)

  • aws_sagemaker_domain
  • aws_sagemaker_user_profile
@bflad bflad added tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure. service/sagemaker Issues and PRs that pertain to the sagemaker service. technical-debt Addresses areas of the codebase that need refactoring or redesign. labels Feb 2, 2021
@bflad bflad added this to the Roadmap milestone Feb 2, 2021
@DrFaust92 DrFaust92 self-assigned this Feb 2, 2021
@DrFaust92
Copy link
Collaborator

Added this as part of #17251 as it adds another downstream sagemaker studio resource

@github-actions github-actions bot modified the milestones: Roadmap, v3.30.0 Feb 26, 2021
@ghost
Copy link

ghost commented Feb 26, 2021

This has been released in version 3.30.0 of the Terraform AWS provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template for triage. Thanks!

@ghost
Copy link

ghost commented Mar 28, 2021

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. Thanks!

@ghost ghost locked as resolved and limited conversation to collaborators Mar 28, 2021
@DrFaust92 DrFaust92 removed their assignment Mar 26, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
service/sagemaker Issues and PRs that pertain to the sagemaker service. technical-debt Addresses areas of the codebase that need refactoring or redesign. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants