r/sagemaker_app - new resource #17251

DrFaust92 · 2021-01-22T20:59:55Z

Community Note

Please vote on this pull request by adding a 👍 reaction to the original pull request comment to help the community and maintainers prioritize this request
Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for pull request followers and do not help prioritize the request

Output from acceptance testing:

$ ACCTEST_PARALLELISM=1 make testacc TESTARGS='-run=TestAccAWSSagemakerApp_'

--- PASS: TestAccAWSSagemakerApp_tags (940.80s)
--- PASS: TestAccAWSSagemakerApp_basic (853.22s)
--- PASS: TestAccAWSSagemakerApp_resourceSpec (1016.37s)
--- PASS: TestAccAWSSagemakerApp_disappears (737.55s)

$ ACCTEST_PARALLELISM=1 make testacc TESTARGS='-run=TestAccAWSSagemakerUserProfile_disappears'

--- PASS: TestAccAWSSagemakerUserProfile_disappears (263.88s)

$ ACCTEST_PARALLELISM=1 make testacc TESTARGS='-run=TestAccAWSSagemakerDomain_kernelGatewayAppSettings_customImage'
--- PASS: TestAccAWSSagemakerDomain_kernelGatewayAppSettings_customImage (383.50s)

.changelog/17251.txt

ewbankkit

LGTM.

$ make testacc TEST=./aws/ TESTARGS='-run=TestAccAWSSagemakerApp_\|TestAccAWSSagemakerUserProfile_disappears' ACCTEST_PARALLELISM=1
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./aws -v -count 1 -parallel 1 -run=TestAccAWSSagemakerApp_\|TestAccAWSSagemakerUserProfile_disappears -timeout 120m
=== RUN   TestAccAWSSagemakerApp_basic
=== PAUSE TestAccAWSSagemakerApp_basic
=== RUN   TestAccAWSSagemakerApp_resourceSpec
=== PAUSE TestAccAWSSagemakerApp_resourceSpec
=== RUN   TestAccAWSSagemakerApp_tags
=== PAUSE TestAccAWSSagemakerApp_tags
=== RUN   TestAccAWSSagemakerApp_disappears
=== PAUSE TestAccAWSSagemakerApp_disappears
=== RUN   TestAccAWSSagemakerUserProfile_disappears
=== PAUSE TestAccAWSSagemakerUserProfile_disappears
=== CONT  TestAccAWSSagemakerApp_basic
--- PASS: TestAccAWSSagemakerApp_basic (602.93s)
=== CONT  TestAccAWSSagemakerApp_disappears
--- PASS: TestAccAWSSagemakerApp_disappears (775.08s)
=== CONT  TestAccAWSSagemakerUserProfile_disappears
--- PASS: TestAccAWSSagemakerUserProfile_disappears (196.78s)
=== CONT  TestAccAWSSagemakerApp_tags
--- PASS: TestAccAWSSagemakerApp_tags (942.22s)
=== CONT  TestAccAWSSagemakerApp_resourceSpec
--- PASS: TestAccAWSSagemakerApp_resourceSpec (826.60s)
PASS
ok  	github.com/terraform-providers/terraform-provider-aws/aws	3343.715s
$ SAGEMAKER_IMAGE_VERSION_BASE_IMAGE=x make testacc TEST=./aws/ TESTARGS='-run=TestAccAWSSagemakerDomain_kernelGatewayAppSettings_customImage'
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./aws -v -count 1 -parallel 20 -run=TestAccAWSSagemakerDomain_kernelGatewayAppSettings_customImage -timeout 120m
=== RUN   TestAccAWSSagemakerDomain_kernelGatewayAppSettings_customImage
=== PAUSE TestAccAWSSagemakerDomain_kernelGatewayAppSettings_customImage
=== CONT  TestAccAWSSagemakerDomain_kernelGatewayAppSettings_customImage
--- PASS: TestAccAWSSagemakerDomain_kernelGatewayAppSettings_customImage (260.99s)
PASS
ok  	github.com/terraform-providers/terraform-provider-aws/aws	261.094s

DrFaust92 · 2021-02-04T10:22:32Z

Serialized Sagemaker Studio tests

ewbankkit · 2021-02-04T13:10:41Z

aws/resource_aws_sagemaker_app_test.go

+	rName := acctest.RandomWithPrefix("tf-acc-test")
+	resourceName := "aws_sagemaker_app.test"
+
+	resource.ParallelTest(t, resource.TestCase{


To get test serialization you will also have to change all the relevant resource.ParallelTest(...) calls into resource.Test(...) calls, otherwise I get errors like:

$ SAGEMAKER_IMAGE_VERSION_BASE_IMAGE=x make testacc TEST=./aws/ TESTARGS='-run=TestAccAWSSagemakerDomain_\|TestAccAWSSagemakerApp_\|TestAccAWSSagemakerUserProfile_disappears' ==> Checking that code complies with gofmt requirements... TF_ACC=1 go test ./aws -v -count 1 -parallel 20 -run=TestAccAWSSagemakerDomain_\|TestAccAWSSagemakerApp_\|TestAccAWSSagemakerUserProfile_disappears -timeout 120m === RUN TestAccAWSSagemakerDomain_serial === RUN TestAccAWSSagemakerDomain_serial/Domain === RUN TestAccAWSSagemakerDomain_serial/Domain/basic === PAUSE TestAccAWSSagemakerDomain_serial/Domain/basic === RUN TestAccAWSSagemakerDomain_serial/Domain/tags === PAUSE TestAccAWSSagemakerDomain_serial/Domain/tags === RUN TestAccAWSSagemakerDomain_serial/Domain/tensorboardAppSettings === PAUSE TestAccAWSSagemakerDomain_serial/Domain/tensorboardAppSettings === RUN TestAccAWSSagemakerDomain_serial/Domain/kernelGatewayAppSettings_customImage === PAUSE TestAccAWSSagemakerDomain_serial/Domain/kernelGatewayAppSettings_customImage === RUN TestAccAWSSagemakerDomain_serial/Domain/jupyterServerAppSettings === PAUSE TestAccAWSSagemakerDomain_serial/Domain/jupyterServerAppSettings === RUN TestAccAWSSagemakerDomain_serial/Domain/kms === PAUSE TestAccAWSSagemakerDomain_serial/Domain/kms === RUN TestAccAWSSagemakerDomain_serial/Domain/disappears === PAUSE TestAccAWSSagemakerDomain_serial/Domain/disappears === RUN TestAccAWSSagemakerDomain_serial/Domain/tensorboardAppSettingsWithImage === PAUSE TestAccAWSSagemakerDomain_serial/Domain/tensorboardAppSettingsWithImage === RUN TestAccAWSSagemakerDomain_serial/Domain/kernelGatewayAppSettings === PAUSE TestAccAWSSagemakerDomain_serial/Domain/kernelGatewayAppSettings === RUN TestAccAWSSagemakerDomain_serial/Domain/securityGroup === PAUSE TestAccAWSSagemakerDomain_serial/Domain/securityGroup === RUN TestAccAWSSagemakerDomain_serial/Domain/sharingSettings === PAUSE TestAccAWSSagemakerDomain_serial/Domain/sharingSettings === CONT TestAccAWSSagemakerDomain_serial/Domain/basic === CONT TestAccAWSSagemakerDomain_serial/Domain/sharingSettings === CONT TestAccAWSSagemakerDomain_serial/Domain/securityGroup === CONT TestAccAWSSagemakerDomain_serial/Domain/kernelGatewayAppSettings === CONT TestAccAWSSagemakerDomain_serial/Domain/tensorboardAppSettingsWithImage === CONT TestAccAWSSagemakerDomain_serial/Domain/disappears === CONT TestAccAWSSagemakerDomain_serial/Domain/kms === CONT TestAccAWSSagemakerDomain_serial/Domain/jupyterServerAppSettings === CONT TestAccAWSSagemakerDomain_serial/Domain/kernelGatewayAppSettings_customImage === CONT TestAccAWSSagemakerDomain_serial/Domain/tensorboardAppSettings === CONT TestAccAWSSagemakerDomain_serial/Domain/tags === CONT TestAccAWSSagemakerDomain_serial/Domain/securityGroup resource_aws_sagemaker_domain_test.go:224: Step 1/3 error: Error running apply: 2021/02/04 07:51:43 [DEBUG] Using modified User-Agent: Terraform/0.12.26 HashiCorp-terraform-exec/0.12.0 Error: error creating SageMaker domain: ResourceLimitExceeded: The account-level service limit 'Total domains' is 1 Domains, with current utilization of 1 Domains and a request delta of 1 Domains. Please contact AWS support to request an increase for this limit.

ewbankkit · 2021-02-04T13:14:22Z

aws/resource_aws_sagemaker_domain_test.go

 	"github.com/hashicorp/terraform-plugin-sdk/v2/helper/acctest"
 	"github.com/hashicorp/terraform-plugin-sdk/v2/helper/resource"
 	"github.com/hashicorp/terraform-plugin-sdk/v2/terraform"
 	"github.com/terraform-providers/terraform-provider-aws/aws/internal/service/sagemaker/finder"
 )

+func TestAccAWSSagemakerDomain_serial(t *testing.T) {


Maybe add a comment noting that SageMaker app and user profile tests are also serialized as they reference a SageMaker domain resource and there is a low overall account limit to the number of domains.

breathingdust · 2021-02-25T23:59:18Z

LGTM 🚀 Thanks @DrFaust92!

Verified Acceptance Tests in Commercial (us-west-2)

ACCTEST_TIMEOUT=600m SAGEMAKER_IMAGE_VERSION_BASE_IMAGE=x.dkr.ecr.us-west-2.amazonaws.com/smtest make testacc TEST=./aws/ TESTARGS='-run=TestAccAWSSagemakerDomain_serial'
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./aws -v -count 1 -parallel 20 -run=TestAccAWSSagemakerDomain_serial -timeout 600m
=== RUN   TestAccAWSSagemakerDomain_serial
=== RUN   TestAccAWSSagemakerDomain_serial/Domain
=== RUN   TestAccAWSSagemakerDomain_serial/Domain/sharingSettings
=== RUN   TestAccAWSSagemakerDomain_serial/Domain/basic
=== RUN   TestAccAWSSagemakerDomain_serial/Domain/tags
=== RUN   TestAccAWSSagemakerDomain_serial/Domain/tensorboardAppSettings
=== RUN   TestAccAWSSagemakerDomain_serial/Domain/tensorboardAppSettingsWithImage
=== RUN   TestAccAWSSagemakerDomain_serial/Domain/kms
=== RUN   TestAccAWSSagemakerDomain_serial/Domain/disappears
=== RUN   TestAccAWSSagemakerDomain_serial/Domain/kernelGatewayAppSettings
=== RUN   TestAccAWSSagemakerDomain_serial/Domain/kernelGatewayAppSettings_customImage
=== RUN   TestAccAWSSagemakerDomain_serial/Domain/jupyterServerAppSettings
=== RUN   TestAccAWSSagemakerDomain_serial/Domain/securityGroup
=== RUN   TestAccAWSSagemakerDomain_serial/UserProfile
=== RUN   TestAccAWSSagemakerDomain_serial/UserProfile/kernelGatewayAppSettings
=== RUN   TestAccAWSSagemakerDomain_serial/UserProfile/jupyterServerAppSettings
=== RUN   TestAccAWSSagemakerDomain_serial/UserProfile/basic
=== RUN   TestAccAWSSagemakerDomain_serial/UserProfile/disappears
=== RUN   TestAccAWSSagemakerDomain_serial/UserProfile/tags
=== RUN   TestAccAWSSagemakerDomain_serial/UserProfile/tensorboardAppSettings
=== RUN   TestAccAWSSagemakerDomain_serial/UserProfile/tensorboardAppSettingsWithImage
=== RUN   TestAccAWSSagemakerDomain_serial/App
=== RUN   TestAccAWSSagemakerDomain_serial/App/basic
=== RUN   TestAccAWSSagemakerDomain_serial/App/disappears
=== RUN   TestAccAWSSagemakerDomain_serial/App/tags
=== RUN   TestAccAWSSagemakerDomain_serial/App/resourceSpec
--- PASS: TestAccAWSSagemakerDomain_serial (7755.79s)
    --- PASS: TestAccAWSSagemakerDomain_serial/Domain (2413.67s)
        --- PASS: TestAccAWSSagemakerDomain_serial/Domain/sharingSettings (253.48s)
        --- PASS: TestAccAWSSagemakerDomain_serial/Domain/basic (178.50s)
        --- PASS: TestAccAWSSagemakerDomain_serial/Domain/tags (218.93s)
        --- PASS: TestAccAWSSagemakerDomain_serial/Domain/tensorboardAppSettings (310.72s)
        --- PASS: TestAccAWSSagemakerDomain_serial/Domain/tensorboardAppSettingsWithImage (249.84s)
        --- PASS: TestAccAWSSagemakerDomain_serial/Domain/kms (190.80s)
        --- PASS: TestAccAWSSagemakerDomain_serial/Domain/disappears (236.71s)
        --- PASS: TestAccAWSSagemakerDomain_serial/Domain/kernelGatewayAppSettings (191.01s)
        --- PASS: TestAccAWSSagemakerDomain_serial/Domain/kernelGatewayAppSettings_customImage (74.11s)
        --- PASS: TestAccAWSSagemakerDomain_serial/Domain/jupyterServerAppSettings (189.90s)
        --- PASS: TestAccAWSSagemakerDomain_serial/Domain/securityGroup (319.67s)
    --- PASS: TestAccAWSSagemakerDomain_serial/UserProfile (2218.77s)
        --- PASS: TestAccAWSSagemakerDomain_serial/UserProfile/kernelGatewayAppSettings (266.94s)
        --- PASS: TestAccAWSSagemakerDomain_serial/UserProfile/jupyterServerAppSettings (368.26s)
        --- PASS: TestAccAWSSagemakerDomain_serial/UserProfile/basic (226.84s)
        --- PASS: TestAccAWSSagemakerDomain_serial/UserProfile/disappears (437.79s)
        --- PASS: TestAccAWSSagemakerDomain_serial/UserProfile/tags (369.45s)
        --- PASS: TestAccAWSSagemakerDomain_serial/UserProfile/tensorboardAppSettings (272.96s)
        --- PASS: TestAccAWSSagemakerDomain_serial/UserProfile/tensorboardAppSettingsWithImage (276.51s)
    --- PASS: TestAccAWSSagemakerDomain_serial/App (3123.35s)
        --- PASS: TestAccAWSSagemakerDomain_serial/App/basic (800.60s)
        --- PASS: TestAccAWSSagemakerDomain_serial/App/disappears (788.74s)
        --- PASS: TestAccAWSSagemakerDomain_serial/App/tags (800.01s)
        --- PASS: TestAccAWSSagemakerDomain_serial/App/resourceSpec (734.00s)
PASS
Ok    github.com/terraform-providers/terraform-provider-aws/aws       7759.179s

ghost · 2021-02-26T04:02:14Z

This has been released in version 3.30.0 of the Terraform AWS provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template for triage. Thanks!

ghost · 2021-03-28T17:11:07Z

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. Thanks!

DrFaust92 added the new-resource Introduces a new resource. label Jan 22, 2021

Base automatically changed from master to main January 23, 2021 01:00

DrFaust92 force-pushed the r/sagemaker_app branch 3 times, most recently from baab6f6 to 927aede Compare January 28, 2021 22:53

ghost added size/XXL Managed by automation to categorize the size of a PR. and removed size/XL Managed by automation to categorize the size of a PR. labels Jan 28, 2021

DrFaust92 marked this pull request as ready for review January 29, 2021 10:36

DrFaust92 requested a review from a team as a code owner January 29, 2021 10:36

ewbankkit self-assigned this Jan 29, 2021

ewbankkit reviewed Jan 29, 2021

View reviewed changes

.changelog/17251.txt Outdated Show resolved Hide resolved

ewbankkit approved these changes Jan 29, 2021

View reviewed changes

DrFaust92 force-pushed the r/sagemaker_app branch from 16c4d8a to c2a310a Compare February 4, 2021 08:22

DrFaust92 marked this pull request as draft February 4, 2021 08:29

DrFaust92 marked this pull request as ready for review February 4, 2021 10:21

DrFaust92 marked this pull request as draft February 4, 2021 10:22

DrFaust92 marked this pull request as ready for review February 4, 2021 10:22

DrFaust92 mentioned this pull request Feb 4, 2021

tests/service/sagemaker: Serialize or Enable Configurable Synchronization for Domain Testing #17402

Closed

ewbankkit requested changes Feb 4, 2021

View reviewed changes

DrFaust92 added 22 commits February 25, 2021 22:45

fmt

745c59e

rename

2b8c27d

simplify error on delete check

36edcad

add changelog file

29d480e

dns

21d24f6

changes to domain based on app image config

03b8c2d

sweeper

02c4050

revert image version arn

50bae9b

fmt

4d7a226

fmt

ef161d9

remove acctest item from changelog

67c53f1

serialize app tests

1c4612b

serialize sagemaker domain tests

c12b937

lint

54e0181

de-parallelize

7eef33f

comment

e47ce81

misspel

1c32206

mispell 2

4064d3d

plural

1fb7275

wait for update to finish

08cba74

changelog

ddf76f9

wait for user profile update to finish

36dfddc

DrFaust92 force-pushed the r/sagemaker_app branch from ccbb508 to 36dfddc Compare February 25, 2021 20:45

breathingdust merged commit a2ae208 into hashicorp:main Feb 25, 2021

github-actions bot added this to the v3.30.0 milestone Feb 26, 2021

ghost locked as resolved and limited conversation to collaborators Mar 28, 2021

DrFaust92 deleted the r/sagemaker_app branch April 15, 2021 10:36

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

r/sagemaker_app - new resource #17251

r/sagemaker_app - new resource #17251

DrFaust92 commented Jan 22, 2021 •

edited

Loading

ewbankkit left a comment •

edited

Loading

DrFaust92 commented Feb 4, 2021

ewbankkit Feb 4, 2021

ewbankkit Feb 4, 2021

breathingdust commented Feb 25, 2021

ghost commented Feb 26, 2021

ghost commented Mar 28, 2021

r/sagemaker_app - new resource #17251

r/sagemaker_app - new resource #17251

Conversation

DrFaust92 commented Jan 22, 2021 • edited Loading

Community Note

ewbankkit left a comment • edited Loading

Choose a reason for hiding this comment

DrFaust92 commented Feb 4, 2021

ewbankkit Feb 4, 2021

Choose a reason for hiding this comment

ewbankkit Feb 4, 2021

Choose a reason for hiding this comment

breathingdust commented Feb 25, 2021

ghost commented Feb 26, 2021

ghost commented Mar 28, 2021

DrFaust92 commented Jan 22, 2021 •

edited

Loading

ewbankkit left a comment •

edited

Loading