resource/aws_codebuild_project: Deprecate source and secondary_sources auth blocks #17465
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bflad
added
the
technical-debt
ghost
added
size/M
bflad
added a commit
that referenced
this pull request
Feb 4, 2021
anGie44
approved these changes
Mar 17, 2021
…s auth blocks Reference: https://docs.aws.amazon.com/codebuild/latest/APIReference/API_SourceAuth.html Reference: #13450 Currently, the following consistent test failure occurs in AWSCodeBuildProject acceptance testing: ``` --- FAIL: TestAccAWSCodeBuildProject_Source_Auth (11.50s) testing.go:683: Step 1 error: errors during apply: Error: Error creating CodeBuild project: InvalidInputException: No Access token found, please visit AWS CodeBuild console to connect to GitHub ``` The API documentation now very explicitly states this underlying API type is deprecated. Here we mark the block and underlying attributes as deprecated suggesting the `aws_codebuild_source_credential` resource and removing the problematic test rather than temporarily introducing a skipping mechanism.
bflad
force-pushed
the
t-aws_codebuild_project-envvar
branch
from
731fdd1
to
cbdc721
Compare
|
I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. Thanks! |
ghost
locked as resolved and limited conversation to collaborators
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Community Note
Reference: https://docs.aws.amazon.com/codebuild/latest/APIReference/API_SourceAuth.html
Closes #13450
Currently, the following consistent test failure occurs in AWSCodeBuildProject acceptance testing:
The API documentation now very explicitly states this underlying API type is deprecated. Here we mark the block and underlying attributes as deprecated suggesting the
aws_codebuild_source_credentialresource and removing the problematic test rather than temporarily introducing a skipping mechanism.