Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

aws_workspaces_directory workspace_access_properties lacks device_type_linux setting which is available in AWS Console #17553

Closed
guydavis opened this issue Feb 10, 2021 · 6 comments · Fixed by #20462
Labels
enhancement Requests to existing resources that expand the functionality or scope. good first issue Call to action for new contributors looking for a place to start. Smaller or straightforward issues. service/workspaces Issues and PRs that pertain to the workspaces service.
Milestone

Comments

@guydavis
Copy link

As show in attached AWS Console allows one to enable Linux device access to an AWS Workspaces Directory, however the aws_workspaces_directory workspace_access_properties lacks device_type_linux setting. Example:

resource "aws_workspaces_directory" "my-directory" {
  provider    = aws.resources-eu-west-1
  directory_id = aws_directory_service_directory.my-connector.id
  subnet_ids = [aws_subnet.my-private2.id, aws_subnet.my-private3.id,]

  workspace_creation_properties {
    custom_security_group_id            = "sg-123456789"
    default_ou                          = "OU=Workspaces,DC=ad,DC=dev,DC=foo,DC=com"
    enable_internet_access              = false
    enable_maintenance_mode             = true
    user_enabled_as_local_administrator = false
  }

  workspace_access_properties {
    device_type_android    = "ALLOW"
    device_type_chromeos   = "ALLOW"
    device_type_ios        = "ALLOW"
    device_type_osx        = "ALLOW"
    device_type_web        = "ALLOW"
    device_type_windows    = "ALLOW"
    device_type_zeroclient = "ALLOW"
    device_type_linux      = "ALLOW"
  }
}

Terraform jobs with that setting fail with Error: Unsupported argument. Using: Plugin for provider "aws" (hashicorp/aws) 3.27.0.

20210210_112903

@ghost ghost added the service/workspaces Issues and PRs that pertain to the workspaces service. label Feb 10, 2021
@github-actions github-actions bot added the needs-triage Waiting for first response or review from a maintainer. label Feb 10, 2021
@anGie44 anGie44 added upstream Addresses functionality related to the cloud provider. and removed needs-triage Waiting for first response or review from a maintainer. labels Feb 11, 2021
@anGie44
Copy link
Contributor

anGie44 commented Feb 11, 2021

Hi @guydavis, thank you for raising this issue. Unfortunately, I believe we're blocked at this time by the upstream AWS API / AWS Go SDK as the property is not yet configurable programmatically (supported attributes in the API docs https://docs.aws.amazon.com/workspaces/latest/api/API_WorkspaceAccessProperties.html, supported attributes in the SDK: https://docs.aws.amazon.com/sdk-for-go/api/service/workspaces/#WorkspaceAccessProperties).

@danial-k
Copy link

Still unavailable in upstream; also missing from CLI v2 docs: https://awscli.amazonaws.com/v2/documentation/api/latest/reference/workspaces/modify-workspace-access-properties.html

@anGie44 anGie44 added the enhancement Requests to existing resources that expand the functionality or scope. label Apr 15, 2021
@sysfsss
Copy link

sysfsss commented Jun 10, 2021

This is now available in the Go SDK:

https://github.com/aws/aws-sdk-go/blob/v1.38.58/service/workspaces/api.go#L11214

@anGie44 anGie44 added good first issue Call to action for new contributors looking for a place to start. Smaller or straightforward issues. and removed upstream Addresses functionality related to the cloud provider. labels Jun 10, 2021
@mattk-ce
Copy link

mattk-ce commented Jul 2, 2021

Any sense of when this can be done now that it is no longer blocked upstream?

@github-actions
Copy link

This functionality has been released in v3.54.0 of the Terraform AWS Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

@github-actions
Copy link

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems similar to this, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Sep 12, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
enhancement Requests to existing resources that expand the functionality or scope. good first issue Call to action for new contributors looking for a place to start. Smaller or straightforward issues. service/workspaces Issues and PRs that pertain to the workspaces service.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants