Add device_type_linux to workspace_access_properties

[dhinus]

Community Note

• Please vote on this pull request by adding a 👍 reaction to the original pull request comment to help the community and maintainers prioritize this request
• Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for pull request followers and do not help prioritize the request

Closes #17553.
Closes #18352.

Output from acceptance testing:

$ make testacc TESTARGS='-run=TestAccDataSourceAwsWorkspacesDirectory_basic'

==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./aws -v -count 1 -parallel 20 -run=TestAccDataSourceAwsWorkspacesDirectory_basic -timeout 180m
=== RUN   TestAccDataSourceAwsWorkspacesDirectory_basic
=== PAUSE TestAccDataSourceAwsWorkspacesDirectory_basic
=== CONT  TestAccDataSourceAwsWorkspacesDirectory_basic


--- PASS: TestAccDataSourceAwsWorkspacesDirectory_basic (499.03s)
PASS
ok      github.com/terraform-providers/terraform-provider-aws/aws       500.848s

$ make testacc TESTARGS='-run=TestAccAwsWorkspacesDirectory_basic'

==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./aws -v -count 1 -parallel 20 -run=TestAccAwsWorkspacesDirectory_basic -timeout 180m
=== RUN   TestAccAwsWorkspacesDirectory_basic
=== PAUSE TestAccAwsWorkspacesDirectory_basic
=== CONT  TestAccAwsWorkspacesDirectory_basic
--- PASS: TestAccAwsWorkspacesDirectory_basic (639.21s)
PASS
ok      github.com/terraform-providers/terraform-provider-aws/aws       641.048s

$ make testacc TESTARGS='-run=TestAccAwsWorkspacesDirectory_workspaceAccessProperties'

==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./aws -v -count 1 -parallel 20 -run=TestAccAwsWorkspacesDirectory_workspaceAccessProperties -timeout 180m
=== RUN   TestAccAwsWorkspacesDirectory_workspaceAccessProperties
=== PAUSE TestAccAwsWorkspacesDirectory_workspaceAccessProperties
=== CONT  TestAccAwsWorkspacesDirectory_workspaceAccessProperties
--- PASS: TestAccAwsWorkspacesDirectory_workspaceAccessProperties (708.22s)
PASS
ok      github.com/terraform-providers/terraform-provider-aws/aws       710.210s

[github-actions]

Welcome @dhinus 👋

It looks like this is your first Pull Request submission to the Terraform AWS Provider! If you haven’t already done so please make sure you have checked out our CONTRIBUTING guide and FAQ to make sure your contribution is adhering to best practice and has all the necessary elements in place for a successful approval.

Also take a look at our FAQ which details how we prioritize Pull Requests for inclusion.

Thanks again, and welcome to the community! 😃

[ewbankkit]

LGTM 🚀.

% make testacc TESTARGS='-run=TestAccAWSWorkspaces_serial/Directory/basic'                                               
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./aws -v -count 1 -parallel 20 -run=TestAccAWSWorkspaces_serial/Directory/basic -timeout 180m
=== RUN   TestAccAWSWorkspaces_serial
=== RUN   TestAccAWSWorkspaces_serial/Directory
=== RUN   TestAccAWSWorkspaces_serial/Directory/basic
--- PASS: TestAccAWSWorkspaces_serial (833.57s)
    --- PASS: TestAccAWSWorkspaces_serial/Directory (833.57s)
        --- PASS: TestAccAWSWorkspaces_serial/Directory/basic (833.57s)
PASS
ok  	github.com/terraform-providers/terraform-provider-aws/aws	837.925s
% make testacc TESTARGS='-run=TestAccDataSourceAwsWorkspaces_serial/Directory/basic'
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./aws -v -count 1 -parallel 20 -run=TestAccDataSourceAwsWorkspaces_serial/Directory/basic -timeout 180m
=== RUN   TestAccDataSourceAwsWorkspaces_serial
=== RUN   TestAccDataSourceAwsWorkspaces_serial/Directory
=== RUN   TestAccDataSourceAwsWorkspaces_serial/Directory/basic
--- PASS: TestAccDataSourceAwsWorkspaces_serial (703.79s)
    --- PASS: TestAccDataSourceAwsWorkspaces_serial/Directory (703.79s)
        --- PASS: TestAccDataSourceAwsWorkspaces_serial/Directory/basic (703.79s)
PASS
ok  	github.com/terraform-providers/terraform-provider-aws/aws	706.885s
% make testacc TESTARGS='-run=TestAccAWSWorkspaces_serial/IpGroup/multipleDirectories'
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./aws -v -count 1 -parallel 20 -run=TestAccAWSWorkspaces_serial/IpGroup/multipleDirectories -timeout 180m
=== RUN   TestAccAWSWorkspaces_serial
=== RUN   TestAccAWSWorkspaces_serial/IpGroup
=== RUN   TestAccAWSWorkspaces_serial/IpGroup/multipleDirectories
--- PASS: TestAccAWSWorkspaces_serial (775.07s)
    --- PASS: TestAccAWSWorkspaces_serial/IpGroup (775.07s)
        --- PASS: TestAccAWSWorkspaces_serial/IpGroup/multipleDirectories (775.07s)
PASS
ok  	github.com/terraform-providers/terraform-provider-aws/aws	778.253s

[ewbankkit]

@dhinus Thanks for the contribution 🎉 👏.
I changed the Workspaces acceptance tests to be serial as we are seeing errors like

== RUN   TestAccAwsWorkspacesDirectory_workspaceAccessProperties
=== PAUSE TestAccAwsWorkspacesDirectory_workspaceAccessProperties
=== CONT  TestAccAwsWorkspacesDirectory_workspaceAccessProperties
resource_aws_workspaces_directory_test.go:285: Step 1/1 error: Error running apply: exit status 1
Error: DirectoryLimitExceededException: Directory limit exceeded. A maximum of 10 directories may be created. : RequestId: 47be73e8-3f71-4b9a-86a2-7c898a7aafec
{
RespMetadata: {
StatusCode: 400,
RequestID: "47be73e8-3f71-4b9a-86a2-7c898a7aafec"
},
Message_: "Directory limit exceeded. A maximum of 10 directories may be created. : RequestId: 47be73e8-3f71-4b9a-86a2-7c898a7aafec",
RequestId: "47be73e8-3f71-4b9a-86a2-7c898a7aafec"
}
on terraform_plugin_test.tf line 49, in resource "aws_directory_service_directory" "main":
49: resource "aws_directory_service_directory" "main" {
--- FAIL: TestAccAwsWorkspacesDirectory_workspaceAccessProperties (211.69s)

in CI.

[github-actions]

This functionality has been released in v3.54.0 of the Terraform AWS Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

[github-actions]

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.