Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

F/aws appautoscaling scheduled action #17689

Merged
merged 5 commits into from
Mar 5, 2021
Merged

F/aws appautoscaling scheduled action #17689

merged 5 commits into from
Mar 5, 2021

Conversation

nikhil-goenka
Copy link
Contributor

@nikhil-goenka nikhil-goenka commented Feb 18, 2021 •
edited by gdavison
Loading

Community Note

  • Please vote on this pull request by adding a 👍 reaction to the original pull request comment to help the community and maintainers prioritize this request
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for pull request followers and do not help prioritize the request

Closes #17600

Output from acceptance testing:

$ make testacc TESTARGS='-run=TestAccXXX'

...

@nikhil-goenka nikhil-goenka requested a review from a team as a code owner February 18, 2021 19:05
@ghost ghost added size/XS Managed by automation to categorize the size of a PR. documentation Introduces or discusses updates to documentation. service/applicationautoscaling service/servicediscovery Issues and PRs that pertain to the servicediscovery service. labels Feb 18, 2021
@github-actions github-actions bot added the needs-triage Waiting for first response or review from a maintainer. label Feb 18, 2021
@gdavison gdavison self-assigned this Mar 3, 2021
gdavison
gdavison approved these changes Mar 5, 2021
View reviewed changes
Copy link
Contributor

@gdavison gdavison left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @nikhil-goenka, this PR is a great start. I've made some additions to extend acceptance testing and to allow timezones on start_time and end_time

gdavison added a commit that referenced this pull request Mar 5, 2021
@gdavison
Merge pull request #17689 from nikhil-goenka/f/aws_appautoscaling_sch…
a5dc3d0 
…eduled_action
@gdavison gdavison merged commit 4686da1 into hashicorp:main Mar 5, 2021
@github-actions github-actions bot added this to the v3.32.0 milestone Mar 5, 2021
@ghost
Copy link

ghost commented Mar 12, 2021

This has been released in version 3.32.0 of the Terraform AWS provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template for triage. Thanks!

@gpanula gpanula mentioned this pull request Mar 16, 2021
Closed
@ghost
Copy link

ghost commented Apr 5, 2021

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. Thanks!

@ghost ghost locked as resolved and limited conversation to collaborators Apr 5, 2021
@breathingdust breathingdust removed the needs-triage Waiting for first response or review from a maintainer. label Sep 17, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@gdavison gdavison gdavison approved these changes

Assignees

@gdavison gdavison

Labels
documentation Introduces or discusses updates to documentation. service/servicediscovery Issues and PRs that pertain to the servicediscovery service. size/XS Managed by automation to categorize the size of a PR.
Projects
None yet
Milestone
v3.32.0
Development

Successfully merging this pull request may close these issues.

Update aws_appautoscaling_scheduled_action to support timezones
3 participants
@nikhil-goenka @gdavison @breathingdust