Add preserve_client_ip attribute support in aws_lb_target_group resource #17731
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
added
size/S
github-actions
bot
added
the
needs-triage
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
There was a problem hiding this comment.
Welcome @amitdaga 👋
It looks like this is your first Pull Request submission to the Terraform AWS Provider! If you haven’t already done so please make sure you have checked out our CONTRIBUTING guide and FAQ to make sure your contribution is adhering to best practice and has all the necessary elements in place for a successful approval.
Also take a look at our FAQ which details how we prioritize Pull Requests for inclusion.
Thanks again, and welcome to the community! 😃
ghost
added
size/L
amitdaga
force-pushed
the
f-aws_lb_target_group-add_attribute
branch
3 times, most recently
from
1dd2a9b
to
fb4fb9a
Compare
amitdaga
changed the title
eapolinario
reviewed
Mar 9, 2021
| @@ -154,6 +154,11 @@ func dataSourceAwsLbTargetGroup() *schema.Resource { | |||
| }, | |||
| }, | |||
|
|
|||
| "preserve_client_id": { | |||
There was a problem hiding this comment.
Thanks for noticing. It is fixed now.
YakDriver
removed
the
needs-triage
YakDriver
force-pushed
the
f-aws_lb_target_group-add_attribute
branch
from
c90adcf
to
06e1dfc
Compare
ghost
added
size/XL
ghost
added
size/XXL
YakDriver
approved these changes
Mar 30, 2021
There was a problem hiding this comment.
@amitdaga This looks great! Thanks for contributing. I'm impressed that you remembered to add the arg to the data source as well!
Acceptance tests on commercial (us-west-2):
--- PASS: TestAccAWSALBTargetGroup_basic (32.79s)
--- PASS: TestAccAWSALBTargetGroup_changeNameForceNew (66.85s)
--- PASS: TestAccAWSALBTargetGroup_changePortForceNew (91.39s)
--- PASS: TestAccAWSALBTargetGroup_changeProtocolForceNew (83.55s)
--- PASS: TestAccAWSALBTargetGroup_changeVpcForceNew (71.14s)
--- PASS: TestAccAWSALBTargetGroup_generatedName (50.01s)
--- PASS: TestAccAWSALBTargetGroup_lambda (27.28s)
--- PASS: TestAccAWSALBTargetGroup_lambdaMultiValueHeadersEnabled (85.42s)
--- PASS: TestAccAWSALBTargetGroup_missingPortProtocolVpc (34.66s)
--- PASS: TestAccAWSALBTargetGroup_namePrefix (41.66s)
--- PASS: TestAccAWSALBTargetGroup_setAndUpdateSlowStart (73.55s)
--- PASS: TestAccAWSALBTargetGroup_tags (88.33s)
--- PASS: TestAccAWSALBTargetGroup_updateHealthCheck (83.28s)
--- PASS: TestAccAWSALBTargetGroup_updateLoadBalancingAlgorithmType (131.17s)
--- PASS: TestAccAWSALBTargetGroup_updateSticknessEnabled (119.79s)
--- PASS: TestAccAWSLBTargetGroup_BackwardsCompatibility (53.99s)
--- PASS: TestAccAWSLBTargetGroup_basic (45.45s)
--- PASS: TestAccAWSLBTargetGroup_basicUdp (43.12s)
--- PASS: TestAccAWSLBTargetGroup_changeNameForceNew (102.03s)
--- PASS: TestAccAWSLBTargetGroup_changePortForceNew (98.16s)
--- PASS: TestAccAWSLBTargetGroup_changeProtocolForceNew (99.78s)
--- PASS: TestAccAWSLBTargetGroup_changeVpcForceNew (95.17s)
--- PASS: TestAccAWSLBTargetGroup_defaults_application (41.47s)
--- PASS: TestAccAWSLBTargetGroup_defaults_network (58.49s)
--- PASS: TestAccAWSLBTargetGroup_enableHealthCheck (75.75s)
--- PASS: TestAccAWSLBTargetGroup_generatedName (36.12s)
--- PASS: TestAccAWSLBTargetGroup_namePrefix (41.01s)
--- PASS: TestAccAWSLBTargetGroup_networkLB_TargetGroup (136.27s)
--- PASS: TestAccAWSLBTargetGroup_networkLB_TargetGroupWithProxy (95.90s)
--- PASS: TestAccAWSLBTargetGroup_preserveClientIPValid (55.16s)
--- PASS: TestAccAWSLBTargetGroup_Protocol_Geneve (58.18s)
--- PASS: TestAccAWSLBTargetGroup_Protocol_Tcp_HealthCheck_Protocol (110.57s)
--- PASS: TestAccAWSLBTargetGroup_Protocol_Tls (43.58s)
--- PASS: TestAccAWSLBTargetGroup_ProtocolVersion (45.24s)
--- PASS: TestAccAWSLBTargetGroup_ProtocolVersion_GRPC_HealthCheck (69.20s)
--- PASS: TestAccAWSLBTargetGroup_ProtocolVersion_HTTP_GRPC_Update (88.52s)
--- PASS: TestAccAWSLBTargetGroup_stickinessDefaultALB (46.28s)
--- PASS: TestAccAWSLBTargetGroup_stickinessDefaultNLB (92.68s)
--- PASS: TestAccAWSLBTargetGroup_stickinessInvalidALB (89.21s)
--- PASS: TestAccAWSLBTargetGroup_stickinessInvalidNLB (61.07s)
--- PASS: TestAccAWSLBTargetGroup_stickinessValidALB (79.56s)
--- PASS: TestAccAWSLBTargetGroup_stickinessValidNLB (182.43s)
--- PASS: TestAccAWSLBTargetGroup_tags (131.09s)
--- PASS: TestAccAWSLBTargetGroup_TCP_HTTPHealthCheck (99.27s)
--- PASS: TestAccAWSLBTargetGroup_updateHealthCheck (103.69s)
--- PASS: TestAccAWSLBTargetGroup_updateSticknessEnabled (78.15s)
--- PASS: TestAccAWSLBTargetGroup_withoutHealthcheck (26.31s)
--- PASS: TestAccDataSourceAWSALBTargetGroup_basic (188.54s)
--- PASS: TestAccDataSourceAWSLBTargetGroup_BackwardsCompatibility (180.43s)
--- PASS: TestALBTargetGroupCloudwatchSuffixFromARN (0.00s)
--- PASS: TestLBTargetGroupCloudwatchSuffixFromARN (0.00s)
Acceptance tests on GovCloud:
--- PASS: TestAccAWSALBTargetGroup_basic (54.97s)
--- PASS: TestAccAWSALBTargetGroup_changeNameForceNew (94.46s)
--- PASS: TestAccAWSALBTargetGroup_changePortForceNew (99.33s)
--- PASS: TestAccAWSALBTargetGroup_changeProtocolForceNew (103.41s)
--- PASS: TestAccAWSALBTargetGroup_changeVpcForceNew (97.51s)
--- PASS: TestAccAWSALBTargetGroup_generatedName (58.51s)
--- PASS: TestAccAWSALBTargetGroup_lambda (42.23s)
--- PASS: TestAccAWSALBTargetGroup_lambdaMultiValueHeadersEnabled (97.62s)
--- PASS: TestAccAWSALBTargetGroup_missingPortProtocolVpc (41.62s)
--- PASS: TestAccAWSALBTargetGroup_namePrefix (48.67s)
--- PASS: TestAccAWSALBTargetGroup_setAndUpdateSlowStart (89.23s)
--- PASS: TestAccAWSALBTargetGroup_tags (97.99s)
--- PASS: TestAccAWSALBTargetGroup_updateHealthCheck (77.47s)
--- PASS: TestAccAWSALBTargetGroup_updateLoadBalancingAlgorithmType (109.50s)
--- PASS: TestAccAWSALBTargetGroup_updateSticknessEnabled (116.80s)
--- PASS: TestAccAWSLBTargetGroup_BackwardsCompatibility (63.34s)
--- PASS: TestAccAWSLBTargetGroup_basic (55.00s)
--- PASS: TestAccAWSLBTargetGroup_basicUdp (56.16s)
--- PASS: TestAccAWSLBTargetGroup_changeNameForceNew (136.81s)
--- PASS: TestAccAWSLBTargetGroup_changePortForceNew (123.47s)
--- PASS: TestAccAWSLBTargetGroup_changeProtocolForceNew (120.41s)
--- PASS: TestAccAWSLBTargetGroup_changeVpcForceNew (119.10s)
--- PASS: TestAccAWSLBTargetGroup_defaults_application (37.10s)
--- PASS: TestAccAWSLBTargetGroup_defaults_network (74.33s)
--- PASS: TestAccAWSLBTargetGroup_enableHealthCheck (46.49s)
--- PASS: TestAccAWSLBTargetGroup_generatedName (43.66s)
--- PASS: TestAccAWSLBTargetGroup_namePrefix (43.35s)
--- PASS: TestAccAWSLBTargetGroup_networkLB_TargetGroup (186.24s)
--- PASS: TestAccAWSLBTargetGroup_networkLB_TargetGroupWithProxy (116.28s)
--- PASS: TestAccAWSLBTargetGroup_preserveClientIPValid (87.92s)
--- PASS: TestAccAWSLBTargetGroup_Protocol_Tcp_HealthCheck_Protocol (98.57s)
--- PASS: TestAccAWSLBTargetGroup_Protocol_Tls (55.71s)
--- PASS: TestAccAWSLBTargetGroup_ProtocolVersion (66.65s)
--- PASS: TestAccAWSLBTargetGroup_ProtocolVersion_GRPC_HealthCheck (70.81s)
--- PASS: TestAccAWSLBTargetGroup_ProtocolVersion_HTTP_GRPC_Update (112.43s)
--- PASS: TestAccAWSLBTargetGroup_stickinessDefaultALB (58.71s)
--- PASS: TestAccAWSLBTargetGroup_stickinessDefaultNLB (111.95s)
--- PASS: TestAccAWSLBTargetGroup_stickinessInvalidALB (116.79s)
--- PASS: TestAccAWSLBTargetGroup_stickinessInvalidNLB (52.35s)
--- PASS: TestAccAWSLBTargetGroup_stickinessValidALB (113.47s)
--- PASS: TestAccAWSLBTargetGroup_stickinessValidNLB (199.68s)
--- PASS: TestAccAWSLBTargetGroup_tags (149.23s)
--- PASS: TestAccAWSLBTargetGroup_TCP_HTTPHealthCheck (125.73s)
--- PASS: TestAccAWSLBTargetGroup_updateHealthCheck (145.56s)
--- PASS: TestAccAWSLBTargetGroup_updateSticknessEnabled (177.52s)
--- PASS: TestAccAWSLBTargetGroup_withoutHealthcheck (34.98s)
--- PASS: TestAccDataSourceAWSALBTargetGroup_basic (197.37s)
--- PASS: TestAccDataSourceAWSLBTargetGroup_BackwardsCompatibility (178.83s)
--- PASS: TestALBTargetGroupCloudwatchSuffixFromARN (0.00s)
--- PASS: TestLBTargetGroupCloudwatchSuffixFromARN (0.00s)
--- SKIP: TestAccAWSLBTargetGroup_Protocol_Geneve (0.33s)
|
This has been released in version 3.35.0 of the Terraform AWS provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading. For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template for triage. Thanks! |
|
I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. Thanks! |
ghost
locked as resolved and limited conversation to collaborators
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Community Note
Closes #17550
Output from acceptance testing: