Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add preserve_client_ip attribute support in aws_lb_target_group resource #17731

Merged
merged 12 commits into from
Mar 30, 2021
Merged

Add preserve_client_ip attribute support in aws_lb_target_group resource #17731

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
12 commits
Select commit Hold shift + click to select a range
d8b0bdd
Add preserve_client_ip attribute support in aws_lb_target_group resource
amitdaga Feb 24, 2021
213520b
Add CHANGELOG entry
amitdaga Feb 24, 2021
06e1dfc
Typo fix
amitdaga Mar 10, 2021
0bfbb1a
r/aws_lb_target_group: Sort arguments
YakDriver Mar 30, 2021
5a62c6c
ds/aws_lbl_target_group: Sort arguments
YakDriver Mar 30, 2021
55ac0ae
r/lb_target_group: Add ErrorCheck
YakDriver Mar 30, 2021
64d434d
r/lb_target_group: Lowercase error
YakDriver Mar 30, 2021
8d811c3
r/lb_target_group: Prefer AWS pointer conversion funcs
YakDriver Mar 30, 2021
69f4d91
tests/ds/lb_target_group: Convert to standard var naming
YakDriver Mar 30, 2021
dffd54c
tests/r/alb_target_group: Convert to standard var naming
YakDriver Mar 30, 2021
ebd0a25
tests/r/lb_target_group: Convert to standard var naming
YakDriver Mar 30, 2021
c9f2e6f
docs/r/lb_target_group: Clean up docs
YakDriver Mar 30, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions .changelog/17731.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,3 @@
```release-note:enhancement
resource/aws_lb_target_group: Add preserve_client_ip target attribute support
```
155 changes: 68 additions & 87 deletions aws/data_source_aws_lb_target_group.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,69 +18,15 @@ func dataSourceAwsLbTargetGroup() *schema.Resource {
Optional: true,
Computed: true,
},

"arn_suffix": {
Type: schema.TypeString,
Computed: true,
},

"name": {
Type: schema.TypeString,
Optional: true,
Computed: true,
},

"port": {
Type: schema.TypeInt,
Computed: true,
},

"protocol": {
Type: schema.TypeString,
Computed: true,
},

"protocol_version": {
Type: schema.TypeString,
Computed: true,
},

"vpc_id": {
Type: schema.TypeString,
Computed: true,
},

"deregistration_delay": {
Type: schema.TypeInt,
Computed: true,
},

"slow_start": {
Type: schema.TypeInt,
Computed: true,
},

"proxy_protocol_v2": {
Type: schema.TypeBool,
Computed: true,
},

"lambda_multi_value_headers_enabled": {
Type: schema.TypeBool,
Computed: true,
},

"load_balancing_algorithm_type": {
Type: schema.TypeString,
Computed: true,
},

"target_type": {
Type: schema.TypeString,
Computed: true,
},

"stickiness": {
"health_check": {
Type: schema.TypeList,
Computed: true,
Elem: &schema.Resource{
Expand All @@ -89,72 +35,107 @@ func dataSourceAwsLbTargetGroup() *schema.Resource {
Type: schema.TypeBool,
Computed: true,
},
"type": {
Type: schema.TypeString,
Computed: true,
},
"cookie_duration": {
"healthy_threshold": {
Type: schema.TypeInt,
Computed: true,
},
},
},
},

"health_check": {
Type: schema.TypeList,
Computed: true,
Elem: &schema.Resource{
Schema: map[string]*schema.Schema{
"enabled": {
Type: schema.TypeBool,
Computed: true,
},

"interval": {
Type: schema.TypeInt,
Computed: true,
},

"matcher": {
Type: schema.TypeString,
Computed: true,
},
"path": {
Type: schema.TypeString,
Computed: true,
},

"port": {
Type: schema.TypeString,
Computed: true,
},

"protocol": {
Type: schema.TypeString,
Computed: true,
},

"timeout": {
Type: schema.TypeInt,
Computed: true,
},

"healthy_threshold": {
"unhealthy_threshold": {
Type: schema.TypeInt,
Computed: true,
},

"matcher": {
Type: schema.TypeString,
},
},
},
"lambda_multi_value_headers_enabled": {
Type: schema.TypeBool,
Computed: true,
},
"load_balancing_algorithm_type": {
Type: schema.TypeString,
Computed: true,
},
"name": {
Type: schema.TypeString,
Optional: true,
Computed: true,
},
"port": {
Type: schema.TypeInt,
Computed: true,
},
"preserve_client_ip": {
Type: schema.TypeString,
Computed: true,
},
"protocol": {
Type: schema.TypeString,
Computed: true,
},
"protocol_version": {
Type: schema.TypeString,
Computed: true,
},
"proxy_protocol_v2": {
Type: schema.TypeBool,
Computed: true,
},
"slow_start": {
Type: schema.TypeInt,
Computed: true,
},
"stickiness": {
Type: schema.TypeList,
Computed: true,
Elem: &schema.Resource{
Schema: map[string]*schema.Schema{
"cookie_duration": {
Type: schema.TypeInt,
Computed: true,
},

"unhealthy_threshold": {
Type: schema.TypeInt,
"enabled": {
Type: schema.TypeBool,
Computed: true,
},
"type": {
Type: schema.TypeString,
Computed: true,
},
},
},
},

"target_type": {
Type: schema.TypeString,
Computed: true,
},
"tags": tagsSchemaComputed(),
"vpc_id": {
Type: schema.TypeString,
Computed: true,
},
},
}
}
Expand Down
Loading