-
Notifications
You must be signed in to change notification settings - Fork 9.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Cannot plan when aws_acm_certificate validation window has expired #17799
Comments
FYI here's the response that was coming back from the DescribeCertificate calls: {
"Certificate": {
"CertificateArn": "arn:aws:acm:us-east-1:123456789012:certificate/some-uuid-here",
"CreatedAt": 1613782427,
"DomainName": "nonprod.media.somedomain.com",
"DomainValidationOptions": [
{
"DomainName": "nonprod.media.somedomain.com",
"ValidationDomain": "nonprod.media.somedomain.com",
"ValidationMethod": "DNS",
"ValidationStatus": "PENDING_VALIDATION"
},
{
"DomainName": "www.nonprod.media.somedomain.com",
"ValidationDomain": "www.nonprod.media.somedomain.com",
"ValidationMethod": "DNS",
"ValidationStatus": "FAILED"
}
],
"ExtendedKeyUsages": [],
"FailureReason": "OTHER",
"InUseBy": [],
"Issuer": "Amazon",
"KeyAlgorithm": "RSA-2048",
"KeyUsages": [],
"Options": {
"CertificateTransparencyLoggingPreference": "ENABLED"
},
"RenewalEligibility": "INELIGIBLE",
"SignatureAlgorithm": "SHA256WITHRSA",
"Status": "VALIDATION_TIMED_OUT",
"Subject": "CN=nonprod.media.somedomain.com",
"SubjectAlternativeNames": [
"nonprod.media.somedomain.com",
"www.nonprod.media.somedomain.com"
],
"Type": "AMAZON_ISSUED"
}
} |
…ON_TIMED_OUT status Reference: #17799 This change is not pragmatic for acceptance testing as it requires 72 hours to trigger the behavior, but acceptance testing is used for finding any regresions. Output from acceptance testing: ``` --- PASS: TestAccAWSAcmCertificate_disableCTLogging (28.63s) --- PASS: TestAccAWSAcmCertificate_dnsValidation (33.31s) --- PASS: TestAccAWSAcmCertificate_emailValidation (26.54s) --- PASS: TestAccAWSAcmCertificate_imported_DomainName (46.51s) --- PASS: TestAccAWSAcmCertificate_imported_IpAddress (19.45s) --- PASS: TestAccAWSAcmCertificate_privateCert (22.21s) --- PASS: TestAccAWSAcmCertificate_PrivateKey_Tags (34.60s) --- PASS: TestAccAWSAcmCertificate_root (33.01s) --- PASS: TestAccAWSAcmCertificate_root_TrailingPeriod (4.08s) --- PASS: TestAccAWSAcmCertificate_rootAndWildcardSan (26.85s) --- PASS: TestAccAWSAcmCertificate_san_multiple (35.05s) --- PASS: TestAccAWSAcmCertificate_san_single (28.67s) --- PASS: TestAccAWSAcmCertificate_san_TrailingPeriod (38.97s) --- PASS: TestAccAWSAcmCertificate_SubjectAlternativeNames_EmptyString (4.00s) --- PASS: TestAccAWSAcmCertificate_tags (60.14s) --- PASS: TestAccAWSAcmCertificate_wildcard (25.46s) --- PASS: TestAccAWSAcmCertificate_wildcardAndRootSan (29.57s) ```
Thank you for raising this, @devonbleak, I have submitted a fix for this here: #17869 |
…ON_TIMED_OUT status (#17869) Reference: #17799 This change is not pragmatic for acceptance testing as it requires 72 hours to trigger the behavior, but acceptance testing is used for finding any regresions. Output from acceptance testing: ``` --- PASS: TestAccAWSAcmCertificate_disableCTLogging (28.63s) --- PASS: TestAccAWSAcmCertificate_dnsValidation (33.31s) --- PASS: TestAccAWSAcmCertificate_emailValidation (26.54s) --- PASS: TestAccAWSAcmCertificate_imported_DomainName (46.51s) --- PASS: TestAccAWSAcmCertificate_imported_IpAddress (19.45s) --- PASS: TestAccAWSAcmCertificate_privateCert (22.21s) --- PASS: TestAccAWSAcmCertificate_PrivateKey_Tags (34.60s) --- PASS: TestAccAWSAcmCertificate_root (33.01s) --- PASS: TestAccAWSAcmCertificate_root_TrailingPeriod (4.08s) --- PASS: TestAccAWSAcmCertificate_rootAndWildcardSan (26.85s) --- PASS: TestAccAWSAcmCertificate_san_multiple (35.05s) --- PASS: TestAccAWSAcmCertificate_san_single (28.67s) --- PASS: TestAccAWSAcmCertificate_san_TrailingPeriod (38.97s) --- PASS: TestAccAWSAcmCertificate_SubjectAlternativeNames_EmptyString (4.00s) --- PASS: TestAccAWSAcmCertificate_tags (60.14s) --- PASS: TestAccAWSAcmCertificate_wildcard (25.46s) --- PASS: TestAccAWSAcmCertificate_wildcardAndRootSan (29.57s) ```
This has been released in version 3.31.0 of the Terraform AWS provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading. For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template for triage. Thanks! |
I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. Thanks! |
Community Note
Terraform CLI and Terraform AWS Provider Version
Terraform v0.13.5
Affected Resource(s)
Terraform Configuration Files
Please include all Terraform configurations required to reproduce the bug. Bug reports without a functional reproduction may be closed without investigation.
Debug Output
Panic Output
No panic.
Expected Behavior
Terraform should be able to plan in order to recreate the certificate
Actual Behavior
TF tries to DescribeCertificate multiple times (can see it in the trace output) until it finally gives up with error:
Steps to Reproduce
terraform plan
terraform refresh
is also impacted.Important Factoids
Culprit seems to be in
func convertValidationOptions
References
The text was updated successfully, but these errors were encountered: