resource/aws_synthetics_canary: Implement Retries for IAM Eventual Consistency Error

[bflad]

Community Note

• Please vote on this issue by adding a 👍 reaction to the original issue to help the community and maintainers prioritize this request
• Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for issue followers and do not help prioritize the request
• If you are interested in working on this issue or have submitted a pull request, please leave a comment

Description

Similar to the aws_lambda_function resource, the aws_synthetics_canary resource can receive delayed eventual consistency errors after the initial creation operation returns as successful, but waiting for its completion. From acceptance testing over the weekend:

=== CONT  TestAccAWSSyntheticsCanary_basic
resource_aws_synthetics_canary_test.go:82: Step 1/3 error: Error running apply: exit status 1
Error: error waiting for Synthetics Canary (tf-acc-test-s9t49btk) creation: : The role defined for the function cannot be assumed by Lambda. (Service: AWSLambda; Status Code: 400; Error Code: InvalidParameterValueException; Request ID: 8e3169db-124d-4c5a-ac0e-d9f382cf737f; Proxy: null)
on terraform_plugin_test.tf line 92, in resource "aws_synthetics_canary" "test":
92: resource "aws_synthetics_canary" "test" {
--- FAIL: TestAccAWSSyntheticsCanary_basic (16.37s)

=== CONT  TestAccAWSSyntheticsCanary_runtimeVersion
resource_aws_synthetics_canary_test.go:156: Step 1/3 error: Error running apply: exit status 1
Error: error waiting for Synthetics Canary (tf-acc-test-nenvizbg) creation: : The role defined for the function cannot be assumed by Lambda. (Service: AWSLambda; Status Code: 400; Error Code: InvalidParameterValueException; Request ID: ffcb7edb-c77e-43f2-8a0a-1183e92f0f8c; Proxy: null)
on terraform_plugin_test.tf line 92, in resource "aws_synthetics_canary" "test":
92: resource "aws_synthetics_canary" "test" {
--- FAIL: TestAccAWSSyntheticsCanary_runtimeVersion (16.85s)

=== CONT  TestAccAWSSyntheticsCanary_startCanary_codeChanges
resource_aws_synthetics_canary_test.go:239: Step 1/3 error: Error running apply: exit status 1
Error: error waiting for Synthetics Canary (tf-acc-test-7c9erovn) creation: : The role defined for the function cannot be assumed by Lambda. (Service: AWSLambda; Status Code: 400; Error Code: InvalidParameterValueException; Request ID: 1c4bacd4-3134-4df3-8e82-2538e155b524; Proxy: null)
on terraform_plugin_test.tf line 92, in resource "aws_synthetics_canary" "test":
92: resource "aws_synthetics_canary" "test" {
--- FAIL: TestAccAWSSyntheticsCanary_startCanary_codeChanges (16.92s)

=== CONT  TestAccAWSSyntheticsCanary_startCanary
resource_aws_synthetics_canary_test.go:190: Step 1/4 error: Error running apply: exit status 1
Error: error waiting for Synthetics Canary (tf-acc-test-gzn0ksyz) creation: : The role defined for the function cannot be assumed by Lambda. (Service: AWSLambda; Status Code: 400; Error Code: InvalidParameterValueException; Request ID: afa63236-ac58-4cec-9c93-67192216f734; Proxy: null)
on terraform_plugin_test.tf line 92, in resource "aws_synthetics_canary" "test":
92: resource "aws_synthetics_canary" "test" {
--- FAIL: TestAccAWSSyntheticsCanary_startCanary (17.91s)

=== CONT  TestAccAWSSyntheticsCanary_s3
resource_aws_synthetics_canary_test.go:281: Step 1/2 error: Error running apply: exit status 1
Error: error waiting for Synthetics Canary (tf-acc-test-rhjz4908) creation: : The role defined for the function cannot be assumed by Lambda. (Service: AWSLambda; Status Code: 400; Error Code: InvalidParameterValueException; Request ID: ea96e8db-b243-499e-b6e9-54e5d30c7604; Proxy: null)
on terraform_plugin_test.tf line 92, in resource "aws_synthetics_canary" "test":
92: resource "aws_synthetics_canary" "test" {
--- FAIL: TestAccAWSSyntheticsCanary_s3 (16.68s)

=== CONT  TestAccAWSSyntheticsCanary_runConfig
resource_aws_synthetics_canary_test.go:326: Step 1/4 error: Error running apply: exit status 1
Error: error waiting for Synthetics Canary (tf-acc-test-qy4r4rep) creation: : The role defined for the function cannot be assumed by Lambda. (Service: AWSLambda; Status Code: 400; Error Code: InvalidParameterValueException; Request ID: aee1cc0e-6f2d-4f8d-8720-91aa25333dcc; Proxy: null)
on terraform_plugin_test.tf line 92, in resource "aws_synthetics_canary" "test":
92: resource "aws_synthetics_canary" "test" {
--- FAIL: TestAccAWSSyntheticsCanary_runConfig (15.30s)

=== CONT  TestAccAWSSyntheticsCanary_runConfigTracing
resource_aws_synthetics_canary_test.go:373: Step 1/4 error: Error running apply: exit status 1
Error: error waiting for Synthetics Canary (tf-acc-test-44kmj0af) creation: : The role defined for the function cannot be assumed by Lambda. (Service: AWSLambda; Status Code: 400; Error Code: InvalidParameterValueException; Request ID: 653d7e28-e3a6-4d5d-8da0-818cb7debb9a; Proxy: null)
on terraform_plugin_test.tf line 92, in resource "aws_synthetics_canary" "test":
92: resource "aws_synthetics_canary" "test" {
--- FAIL: TestAccAWSSyntheticsCanary_runConfigTracing (14.80s)

=== CONT  TestAccAWSSyntheticsCanary_vpc
resource_aws_synthetics_canary_test.go:416: Step 1/4 error: Error running apply: exit status 1
Error: error waiting for Synthetics Canary (tf-acc-test-278kyhh1) creation: : The role defined for the function cannot be assumed by Lambda. (Service: AWSLambda; Status Code: 400; Error Code: InvalidParameterValueException; Request ID: 9e377590-2ea9-42db-8340-f181964fd388; Proxy: null)
on terraform_plugin_test.tf line 150, in resource "aws_synthetics_canary" "test":
150: resource "aws_synthetics_canary" "test" {
--- FAIL: TestAccAWSSyntheticsCanary_vpc (15.25s)

=== CONT  TestAccAWSSyntheticsCanary_tags
resource_aws_synthetics_canary_test.go:466: Step 1/4 error: Error running apply: exit status 1
Error: error waiting for Synthetics Canary (tf-acc-test-8thffpcs) creation: : The role defined for the function cannot be assumed by Lambda. (Service: AWSLambda; Status Code: 400; Error Code: InvalidParameterValueException; Request ID: 60d2ea31-fdcb-4c4e-85ec-eecda075d58c; Proxy: null)
on terraform_plugin_test.tf line 92, in resource "aws_synthetics_canary" "test":
92: resource "aws_synthetics_canary" "test" {
--- FAIL: TestAccAWSSyntheticsCanary_tags (15.32s)

=== CONT  TestAccAWSSyntheticsCanary_disappears
resource_aws_synthetics_canary_test.go:513: Step 1/1 error: Error running apply: exit status 1
Error: error waiting for Synthetics Canary (tf-acc-test-yelzrxeu) creation: : The role defined for the function cannot be assumed by Lambda. (Service: AWSLambda; Status Code: 400; Error Code: InvalidParameterValueException; Request ID: 398f9321-06ea-4019-ba08-37594ec32f04; Proxy: null)
on terraform_plugin_test.tf line 92, in resource "aws_synthetics_canary" "test":
92: resource "aws_synthetics_canary" "test" {
--- FAIL: TestAccAWSSyntheticsCanary_disappears (15.34s)

Typically we can just wrap the problematic operation, but in this case, it will need to wrap both the problematic operation and the waiter as well, to ensure that the logic retries both.

Affected Resources

• aws_synthetics_canary

References

• https://github.com/hashicorp/terraform-provider-aws/blob/main/docs/contributing/retries-and-waiters.md

[bflad]

Submitted fix for this here: #18404

[ghost]

This has been released in version 3.35.0 of the Terraform AWS provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template for triage. Thanks!

[ghost]

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. Thanks!