Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

r/pinpoint_sms_channel - fix no setting params on update #18281

Merged
merged 2 commits into from
Mar 19, 2021

Conversation

DrFaust92
Copy link
Collaborator

Community Note

  • Please vote on this pull request by adding a 👍 reaction to the original pull request comment to help the community and maintainers prioritize this request
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for pull request followers and do not help prioritize the request

Closes #11853

Output from acceptance testing:

$ make testacc TESTARGS='-run=TestAccAWSPinpointSMSChannel_'
--- PASS: TestAccAWSPinpointSMSChannel_disappears (34.04s)
--- PASS: TestAccAWSPinpointSMSChannel_basic (76.71s)
--- PASS: TestAccAWSPinpointSMSChannel_full (77.54s)

@DrFaust92 DrFaust92 requested a review from a team as a code owner March 19, 2021 11:04
@ghost ghost added size/M Managed by automation to categorize the size of a PR. service/pinpoint Issues and PRs that pertain to the pinpoint service. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure. labels Mar 19, 2021
@DrFaust92 DrFaust92 added the bug Addresses a defect in current functionality. label Mar 19, 2021
@bflad bflad self-assigned this Mar 19, 2021
Copy link
Contributor

@bflad bflad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me, thank you @DrFaust92 🚀

Output from acceptance testing:

--- PASS: TestAccAWSPinpointSMSChannel_disappears (15.43s)
--- PASS: TestAccAWSPinpointSMSChannel_full (31.57s)
--- PASS: TestAccAWSPinpointSMSChannel_basic (32.19s)

@bflad bflad merged commit 14bef4b into hashicorp:main Mar 19, 2021
@github-actions github-actions bot added this to the v3.34.0 milestone Mar 19, 2021
@ghost
Copy link

ghost commented Mar 26, 2021

This has been released in version 3.34.0 of the Terraform AWS provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template for triage. Thanks!

@DrFaust92 DrFaust92 deleted the r/pinpoint_sms_channel_fix branch April 15, 2021 10:34
@ghost
Copy link

ghost commented Apr 18, 2021

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. Thanks!

@ghost ghost locked as resolved and limited conversation to collaborators Apr 18, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Addresses a defect in current functionality. service/pinpoint Issues and PRs that pertain to the pinpoint service. size/M Managed by automation to categorize the size of a PR. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Pinpoint SMS sender ID not controlled by terraform
2 participants