New data source: aws_subnets

[farhanangullia]

Community Note

• Please vote on this pull request by adding a 👍 reaction to the original pull request comment to help the community and maintainers prioritize this request
• Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for pull request followers and do not help prioritize the request

Closes #18060

Release note for CHANGELOG:

aws_subnets

Output from acceptance testing:

$ make testacc TESTARGS='-run=TestAccDataSourceAwsSubnets'
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./aws -v -count 1 -parallel 20 -run=TestAccDataSourceAwsSubnets -timeout 180m
=== RUN   TestAccDataSourceAwsSubnets_basic
=== PAUSE TestAccDataSourceAwsSubnets_basic
=== RUN   TestAccDataSourceAwsSubnets_filter
=== PAUSE TestAccDataSourceAwsSubnets_filter
=== CONT  TestAccDataSourceAwsSubnets_basic
=== CONT  TestAccDataSourceAwsSubnets_filter
--- PASS: TestAccDataSourceAwsSubnets_filter (99.45s)
--- PASS: TestAccDataSourceAwsSubnets_basic (157.00s)
PASS
ok      github.com/terraform-providers/terraform-provider-aws/aws       158.517s

...

[YakDriver]

@farhanangullia This looks like a great PR at first glance! Tests, code, and submission seem to be in order. Note, this is a quick scan. We aren't able to get to everything we'd like in a day but hopefully we'll be able to give this a more careful review soon!

[farhanangullia]

@farhanangullia This looks like a great PR at first glance! Tests, code, and submission seem to be in order. Note, this is a quick scan. We aren't able to get to everything we'd like in a day but hopefully we'll be able to give this a more careful review soon!

Thank you @YakDriver 🙏

[FireballDWF]

@ewbankkit review requested

[ewbankkit]

LGTM 🚀.

% make testacc TESTARGS='-run=TestAccDataSourceAwsSubnets_'
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./aws -v -count 1 -parallel 20 -run=TestAccDataSourceAwsSubnets_ -timeout 180m
=== RUN   TestAccDataSourceAwsSubnets_basic
=== PAUSE TestAccDataSourceAwsSubnets_basic
=== RUN   TestAccDataSourceAwsSubnets_filter
=== PAUSE TestAccDataSourceAwsSubnets_filter
=== CONT  TestAccDataSourceAwsSubnets_basic
=== CONT  TestAccDataSourceAwsSubnets_filter
--- PASS: TestAccDataSourceAwsSubnets_filter (30.77s)
--- PASS: TestAccDataSourceAwsSubnets_basic (41.93s)
PASS
ok  	github.com/terraform-providers/terraform-provider-aws/aws	45.334s

[ewbankkit]

@farhanangullia Thanks for the contribution 🎉 👏.
In our upcoming (Version 4.0 Release)[https://github.com//issues/20433] we will expect plural data sources to return an empty list if no matching resources are found, so I went ahead and made that minor change to the PR.

[github-actions]

This functionality has been released in v3.55.0 of the Terraform AWS Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

[yermulnik]

Out of interest: it looks like aws_subnets provides more convenience and flexibility over the aws_subnet_ids resource — are there any plans to deprecate the latter in favour of the former?

[github-actions]

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.