Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implement object lambda access points for S3 #19294

Merged
merged 28 commits into from
Nov 16, 2021
Merged

Implement object lambda access points for S3 #19294

merged 28 commits into from
Nov 16, 2021

Conversation

gijzelaerr
Copy link
Contributor

@gijzelaerr gijzelaerr commented May 10, 2021 •
edited by ewbankkit
Loading

Community Note

  • Please vote on this pull request by adding a 👍 reaction to the original pull request comment to help the community and maintainers prioritize this request
  • Please do not leave "+1" or other comments that do not add relevant new information or questions; they generate extra noise for pull request followers and do not help prioritize the request

Closes #18206.
Closes #12235.
Closes #18132.
Closes #20325.

Notes about this PR

  • I'm basing the code on the s3 access point module since that seems to be the most similar.

@ghost ghost added size/XL Managed by automation to categorize the size of a PR. service/lambda Issues and PRs that pertain to the lambda service. service/s3 Issues and PRs that pertain to the s3 service. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure. labels May 10, 2021
@github-actions github-actions bot added the needs-triage Waiting for first response or review from a maintainer. label May 10, 2021
github-actions[bot]
github-actions bot reviewed May 10, 2021
View reviewed changes
Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Welcome @gijzelaerr 👋

It looks like this is your first Pull Request submission to the Terraform AWS Provider! If you haven’t already done so please make sure you have checked out our CONTRIBUTING guide and FAQ to make sure your contribution is adhering to best practice and has all the necessary elements in place for a successful approval.

Also take a look at our FAQ which details how we prioritize Pull Requests for inclusion.

Thanks again, and welcome to the community! 😃

@ghost ghost added size/XXL Managed by automation to categorize the size of a PR. and removed size/XL Managed by automation to categorize the size of a PR. labels May 12, 2021
@damogallagher
Copy link

I was wondering if this functionality will be available in terraform anytime soon?

@breathingdust breathingdust added new-resource Introduces a new resource. and removed needs-triage Waiting for first response or review from a maintainer. labels Sep 4, 2021
@zhelding
Copy link
Contributor

Pull request #21306 has significantly refactored the AWS Provider codebase. As a result, most PRs opened prior to the refactor now have merge conflicts that must be resolved before proceeding.

Specifically, PR #21306 relocated the code for all AWS resources and data sources from a single aws directory to a large number of separate directories in internal/service, each corresponding to a particular AWS service. This separation of code has also allowed for us to simplify the names of underlying functions -- while still avoiding namespace collisions.

We recognize that many pull requests have been open for some time without yet being addressed by our maintainers. Therefore, we want to make it clear that resolving these conflicts in no way affects the prioritization of a particular pull request. Once a pull request has been prioritized for review, the necessary changes will be made by a maintainer -- either directly or in collaboration with the pull request author.

For a more complete description of this refactor, including examples of how old filepaths and function names correspond to their new counterparts: please refer to issue #20000.

For a quick guide on how to amend your pull request to resolve the merge conflicts resulting from this refactor and bring it in line with our new code patterns: please refer to our Service Package Refactor Pull Request Guide.

@breathingdust
Copy link
Member

Hi all 👋 Just letting you know that this is issue is featured on this quarters roadmap. If a PR exists to close the issue a maintainer will review and either make changes directly, or work with the original author to get the contribution merged. If you have written a PR to resolve the issue please ensure the "Allow edits from maintainers" box is checked. Thanks for your patience and we are looking forward to getting this merged soon!

@breathingdust breathingdust added this to the Roadmap milestone Nov 10, 2021
@gijzelaerr
Copy link
Contributor Author

this is great news! I ran out of time for working on this, and it was a bit of a deep dive for me since I never worked with go before. I didn't get far, so it could be even better to just start over. Please do whatever is required to complete this PR. I'm also happy to test the PR at some point.

@ewbankkit ewbankkit self-assigned this Nov 14, 2021
gijzelaerr and others added 10 commits November 14, 2021 16:28
@gijzelaerr @ewbankkit
first work
948e4dd
@gijzelaerr @ewbankkit
progress
eede8dd
@gijzelaerr @ewbankkit
small steps
f557d86
@ewbankkit
Rename resource and associated acceptance test files.
b630c47
@ewbankkit
r/aws_s3control_object_lambda_access_point: First compiling version.
50834fa
@ewbankkit
r/aws_s3control_object_lambda_access_point: First compiling acceptanc…
b63516a 
…e tests.
@ewbankkit
r/aws_s3control_object_lambda_access_point: Sweeper.
b718065 
Acceptance test output:

% make sweep SWEEPARGS=-sweep-run=aws_s3control_object_lambda_access_point SWEEP=us-west-2,us-west-1,us-east-2,us-east-1
WARNING: This will destroy infrastructure. Use only in development accounts.
go test ./internal/sweep -v -tags=sweep -sweep=us-west-2,us-west-1,us-east-2,us-east-1 -sweep-run=aws_s3control_object_lambda_access_point -timeout 60m
2021/11/14 17:30:10 [DEBUG] Running Sweepers for region (us-west-2):
2021/11/14 17:30:10 [DEBUG] Running Sweeper (aws_s3control_object_lambda_access_point) in region (us-west-2)
2021/11/14 17:30:10 [INFO] AWS Auth provider used: "EnvProvider"
2021/11/14 17:30:10 [DEBUG] Trying to get account information via sts:GetCallerIdentity
2021/11/14 17:30:10 [DEBUG] Trying to get account information via sts:GetCallerIdentity
2021/11/14 17:30:11 [DEBUG] Completed Sweeper (aws_s3control_object_lambda_access_point) in region (us-west-2) in 1.195820054s
2021/11/14 17:30:11 Completed Sweepers for region (us-west-2) in 1.196017929s
2021/11/14 17:30:11 Sweeper Tests for region (us-west-2) ran successfully:
	- aws_s3control_object_lambda_access_point
2021/11/14 17:30:11 [DEBUG] Running Sweepers for region (us-west-1):
2021/11/14 17:30:11 [DEBUG] Running Sweeper (aws_s3control_object_lambda_access_point) in region (us-west-1)
2021/11/14 17:30:11 [INFO] AWS Auth provider used: "EnvProvider"
2021/11/14 17:30:11 [DEBUG] Trying to get account information via sts:GetCallerIdentity
2021/11/14 17:30:11 [DEBUG] Trying to get account information via sts:GetCallerIdentity
2021/11/14 17:30:12 [DEBUG] Completed Sweeper (aws_s3control_object_lambda_access_point) in region (us-west-1) in 1.131984915s
2021/11/14 17:30:12 Completed Sweepers for region (us-west-1) in 1.132046741s
2021/11/14 17:30:12 Sweeper Tests for region (us-west-1) ran successfully:
	- aws_s3control_object_lambda_access_point
2021/11/14 17:30:12 [DEBUG] Running Sweepers for region (us-east-2):
2021/11/14 17:30:12 [DEBUG] Running Sweeper (aws_s3control_object_lambda_access_point) in region (us-east-2)
2021/11/14 17:30:12 [INFO] AWS Auth provider used: "EnvProvider"
2021/11/14 17:30:12 [DEBUG] Trying to get account information via sts:GetCallerIdentity
2021/11/14 17:30:12 [DEBUG] Trying to get account information via sts:GetCallerIdentity
2021/11/14 17:30:14 [DEBUG] Completed Sweeper (aws_s3control_object_lambda_access_point) in region (us-east-2) in 1.594099203s
2021/11/14 17:30:14 Completed Sweepers for region (us-east-2) in 1.594175673s
2021/11/14 17:30:14 Sweeper Tests for region (us-east-2) ran successfully:
	- aws_s3control_object_lambda_access_point
2021/11/14 17:30:14 [DEBUG] Running Sweepers for region (us-east-1):
2021/11/14 17:30:14 [DEBUG] Running Sweeper (aws_s3control_object_lambda_access_point) in region (us-east-1)
2021/11/14 17:30:14 [INFO] AWS Auth provider used: "EnvProvider"
2021/11/14 17:30:14 [DEBUG] Trying to get account information via sts:GetCallerIdentity
2021/11/14 17:30:14 [DEBUG] Trying to get account information via sts:GetCallerIdentity
2021/11/14 17:30:14 [DEBUG] Completed Sweeper (aws_s3control_object_lambda_access_point) in region (us-east-1) in 644.086847ms
2021/11/14 17:30:14 Completed Sweepers for region (us-east-1) in 644.253217ms
2021/11/14 17:30:14 Sweeper Tests for region (us-east-1) ran successfully:
	- aws_s3control_object_lambda_access_point
ok  	github.com/hashicorp/terraform-provider-aws/internal/sweep	7.843s
@ewbankkit
Add CHANGELOG entry.
9ee6369
@ewbankkit
Add documentation.
518054d
@ewbankkit
Add 'arn' attribute.
d0065a2
@ewbankkit
r/aws_s3control_object_lambda_access_point: Add 'TestAccS3ControlObje…
e37bd09 
…ctLambdaAccessPoint_update'.

Acceptance test output:

% make testacc PKG_NAME=internal/service/s3control TESTARGS='-run=TestAccS3ControlObjectLambdaAccessPoint_update'
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/s3control/... -v -count 1 -parallel 20 -run=TestAccS3ControlObjectLambdaAccessPoint_update -timeout 180m
=== RUN   TestAccS3ControlObjectLambdaAccessPoint_update
=== PAUSE TestAccS3ControlObjectLambdaAccessPoint_update
=== CONT  TestAccS3ControlObjectLambdaAccessPoint_update
--- PASS: TestAccS3ControlObjectLambdaAccessPoint_update (74.66s)
PASS
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/s3control	80.519s
@ewbankkit
r/aws_s3control_object_lambda_access_point_policy: New resource.
b0ca9fb 
Acceptance test output:

% make testacc PKG_NAME=internal/service/s3control TESTARGS='-run=TestAccS3ControlObjectLambdaAccessPointPolicy_basic'
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/s3control/... -v -count 1 -parallel 20 -run=TestAccS3ControlObjectLambdaAccessPointPolicy_basic -timeout 180m
=== RUN   TestAccS3ControlObjectLambdaAccessPointPolicy_basic
=== PAUSE TestAccS3ControlObjectLambdaAccessPointPolicy_basic
=== CONT  TestAccS3ControlObjectLambdaAccessPointPolicy_basic
--- PASS: TestAccS3ControlObjectLambdaAccessPointPolicy_basic (45.52s)
PASS
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/s3control	49.227s
@ewbankkit
r/aws_s3control_object_lambda_access_point_policy: Add documentation.
8097361
@ewbankkit
r/aws_s3control_object_lambda_access_point_policy: Passing acceptance…
97e5f2b 
… tests.

Acceptance test output:

% make testacc PKG_NAME=internal/service/s3control TESTARGS='-run=TestAccS3ControlObjectLambdaAccessPointPolicy_'
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/s3control/... -v -count 1 -parallel 20 -run=TestAccS3ControlObjectLambdaAccessPointPolicy_ -timeout 180m
=== RUN   TestAccS3ControlObjectLambdaAccessPointPolicy_basic
=== PAUSE TestAccS3ControlObjectLambdaAccessPointPolicy_basic
=== RUN   TestAccS3ControlObjectLambdaAccessPointPolicy_disappears
=== PAUSE TestAccS3ControlObjectLambdaAccessPointPolicy_disappears
=== RUN   TestAccS3ControlObjectLambdaAccessPointPolicy_disappears_AccessPoint
=== PAUSE TestAccS3ControlObjectLambdaAccessPointPolicy_disappears_AccessPoint
=== RUN   TestAccS3ControlObjectLambdaAccessPointPolicy_update
=== PAUSE TestAccS3ControlObjectLambdaAccessPointPolicy_update
=== CONT  TestAccS3ControlObjectLambdaAccessPointPolicy_basic
=== CONT  TestAccS3ControlObjectLambdaAccessPointPolicy_disappears_AccessPoint
=== CONT  TestAccS3ControlObjectLambdaAccessPointPolicy_disappears
=== CONT  TestAccS3ControlObjectLambdaAccessPointPolicy_update
--- PASS: TestAccS3ControlObjectLambdaAccessPointPolicy_disappears_AccessPoint (51.24s)
--- PASS: TestAccS3ControlObjectLambdaAccessPointPolicy_basic (56.99s)
--- PASS: TestAccS3ControlObjectLambdaAccessPointPolicy_disappears (69.55s)
--- PASS: TestAccS3ControlObjectLambdaAccessPointPolicy_update (94.41s)
PASS
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/s3control	102.627s
@github-actions github-actions bot added service/s3 Issues and PRs that pertain to the s3 service. and removed service/s3 Issues and PRs that pertain to the s3 service. labels Nov 15, 2021
@ewbankkit
Fix golangci-lint error: 'directive ... unused for linter "deadcode" …
4bad1e9 
…(nolintlint)'.
@ewbankkit
r/aws_s3control_access_point_policy: New resource.
d26b359 
Acceptance test output:

% make testacc PKG_NAME=internal/service/s3control TESTARGS='-run=TestAccS3ControlAccessPointPolicy_'
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/s3control/... -v -count 1 -parallel 20 -run=TestAccS3ControlAccessPointPolicy_ -timeout 180m
=== RUN   TestAccS3ControlAccessPointPolicy_basic
=== PAUSE TestAccS3ControlAccessPointPolicy_basic
=== RUN   TestAccS3ControlAccessPointPolicy_disappears
=== PAUSE TestAccS3ControlAccessPointPolicy_disappears
=== RUN   TestAccS3ControlAccessPointPolicy_disappears_AccessPoint
=== PAUSE TestAccS3ControlAccessPointPolicy_disappears_AccessPoint
=== RUN   TestAccS3ControlAccessPointPolicy_update
=== PAUSE TestAccS3ControlAccessPointPolicy_update
=== CONT  TestAccS3ControlAccessPointPolicy_basic
=== CONT  TestAccS3ControlAccessPointPolicy_update
=== CONT  TestAccS3ControlAccessPointPolicy_disappears_AccessPoint
=== CONT  TestAccS3ControlAccessPointPolicy_disappears
--- PASS: TestAccS3ControlAccessPointPolicy_disappears_AccessPoint (29.92s)
--- PASS: TestAccS3ControlAccessPointPolicy_disappears (30.91s)
--- PASS: TestAccS3ControlAccessPointPolicy_basic (34.21s)
--- PASS: TestAccS3ControlAccessPointPolicy_update (59.52s)
PASS
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/s3control	63.190s
% make testacc PKG_NAME=internal/service/s3control TESTARGS='-run=TestAccS3ControlAccessPoint_'
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/s3control/... -v -count 1 -parallel 20 -run=TestAccS3ControlAccessPoint_ -timeout 180m
=== RUN   TestAccS3ControlAccessPoint_basic
=== PAUSE TestAccS3ControlAccessPoint_basic
=== RUN   TestAccS3ControlAccessPoint_disappears
=== PAUSE TestAccS3ControlAccessPoint_disappears
=== RUN   TestAccS3ControlAccessPoint_Bucket_arn
=== PAUSE TestAccS3ControlAccessPoint_Bucket_arn
=== RUN   TestAccS3ControlAccessPoint_policy
=== PAUSE TestAccS3ControlAccessPoint_policy
=== RUN   TestAccS3ControlAccessPoint_publicAccessBlock
=== PAUSE TestAccS3ControlAccessPoint_publicAccessBlock
=== RUN   TestAccS3ControlAccessPoint_vpc
=== PAUSE TestAccS3ControlAccessPoint_vpc
=== CONT  TestAccS3ControlAccessPoint_basic
=== CONT  TestAccS3ControlAccessPoint_publicAccessBlock
=== CONT  TestAccS3ControlAccessPoint_policy
=== CONT  TestAccS3ControlAccessPoint_Bucket_arn
=== CONT  TestAccS3ControlAccessPoint_vpc
=== CONT  TestAccS3ControlAccessPoint_disappears
=== CONT  TestAccS3ControlAccessPoint_Bucket_arn
    acctest.go:1250: skipping since no Outposts found
--- SKIP: TestAccS3ControlAccessPoint_Bucket_arn (1.58s)
--- PASS: TestAccS3ControlAccessPoint_disappears (26.09s)
--- PASS: TestAccS3ControlAccessPoint_vpc (31.94s)
--- PASS: TestAccS3ControlAccessPoint_publicAccessBlock (32.23s)
--- PASS: TestAccS3ControlAccessPoint_basic (32.28s)
--- PASS: TestAccS3ControlAccessPoint_policy (56.70s)
PASS
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/s3control	60.246s
@ewbankkit ewbankkit marked this pull request as ready for review November 15, 2021 22:12
@github-actions github-actions bot added service/s3 Issues and PRs that pertain to the s3 service. and removed service/s3 Issues and PRs that pertain to the s3 service. labels Nov 15, 2021
@ewbankkit ewbankkit removed the size/XL Managed by automation to categorize the size of a PR. label Nov 15, 2021
@ewbankkit
r/aws_s3_access_point: 'policy' can not (yet) be Computed as that's a…
63e88c7 
… breaking change (no ability to delete a policy).

Acceptance test output:

% make testacc PKG_NAME=internal/service/s3control TESTARGS='-run=TestAccS3ControlAccessPoint_'
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/s3control/... -v -count 1 -parallel 20 -run=TestAccS3ControlAccessPoint_ -timeout 180m
=== RUN   TestAccS3ControlAccessPoint_basic
=== PAUSE TestAccS3ControlAccessPoint_basic
=== RUN   TestAccS3ControlAccessPoint_disappears
=== PAUSE TestAccS3ControlAccessPoint_disappears
=== RUN   TestAccS3ControlAccessPoint_Bucket_arn
=== PAUSE TestAccS3ControlAccessPoint_Bucket_arn
=== RUN   TestAccS3ControlAccessPoint_policy
=== PAUSE TestAccS3ControlAccessPoint_policy
=== RUN   TestAccS3ControlAccessPoint_publicAccessBlock
=== PAUSE TestAccS3ControlAccessPoint_publicAccessBlock
=== RUN   TestAccS3ControlAccessPoint_vpc
=== PAUSE TestAccS3ControlAccessPoint_vpc
=== CONT  TestAccS3ControlAccessPoint_basic
=== CONT  TestAccS3ControlAccessPoint_publicAccessBlock
=== CONT  TestAccS3ControlAccessPoint_policy
=== CONT  TestAccS3ControlAccessPoint_vpc
=== CONT  TestAccS3ControlAccessPoint_Bucket_arn
=== CONT  TestAccS3ControlAccessPoint_disappears
=== CONT  TestAccS3ControlAccessPoint_Bucket_arn
    acctest.go:1250: skipping since no Outposts found
--- SKIP: TestAccS3ControlAccessPoint_Bucket_arn (1.47s)
--- PASS: TestAccS3ControlAccessPoint_disappears (28.54s)
--- PASS: TestAccS3ControlAccessPoint_publicAccessBlock (32.46s)
--- PASS: TestAccS3ControlAccessPoint_basic (32.61s)
--- PASS: TestAccS3ControlAccessPoint_vpc (33.23s)
--- PASS: TestAccS3ControlAccessPoint_policy (79.79s)
PASS
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/s3control	83.207s
% make testacc PKG_NAME=internal/service/s3control TESTARGS='-run=TestAccS3ControlAccessPointPolicy_'
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/s3control/... -v -count 1 -parallel 20 -run=TestAccS3ControlAccessPointPolicy_ -timeout 180m
=== RUN   TestAccS3ControlAccessPointPolicy_basic
=== PAUSE TestAccS3ControlAccessPointPolicy_basic
=== RUN   TestAccS3ControlAccessPointPolicy_disappears
=== PAUSE TestAccS3ControlAccessPointPolicy_disappears
=== RUN   TestAccS3ControlAccessPointPolicy_disappears_AccessPoint
=== PAUSE TestAccS3ControlAccessPointPolicy_disappears_AccessPoint
=== RUN   TestAccS3ControlAccessPointPolicy_update
=== PAUSE TestAccS3ControlAccessPointPolicy_update
=== CONT  TestAccS3ControlAccessPointPolicy_basic
=== CONT  TestAccS3ControlAccessPointPolicy_update
=== CONT  TestAccS3ControlAccessPointPolicy_disappears_AccessPoint
=== CONT  TestAccS3ControlAccessPointPolicy_disappears
--- PASS: TestAccS3ControlAccessPointPolicy_disappears_AccessPoint (30.56s)
--- PASS: TestAccS3ControlAccessPointPolicy_disappears (31.74s)
--- PASS: TestAccS3ControlAccessPointPolicy_basic (36.51s)
--- PASS: TestAccS3ControlAccessPointPolicy_update (60.98s)
PASS
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/s3control	64.567s
@github-actions github-actions bot added size/XL Managed by automation to categorize the size of a PR. service/s3 Issues and PRs that pertain to the s3 service. labels Nov 16, 2021
@ewbankkit
r/aws_s3_access_point: Add 'FindAccessPointByAccountIDAndName'.
5f6cafd 
Acceptance test output:

% make testacc PKG_NAME=internal/service/s3control TESTARGS='-run=TestAccS3ControlAccessPoint_'
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/s3control/... -v -count 1 -parallel 20 -run=TestAccS3ControlAccessPoint_ -timeout 180m
=== RUN   TestAccS3ControlAccessPoint_basic
=== PAUSE TestAccS3ControlAccessPoint_basic
=== RUN   TestAccS3ControlAccessPoint_disappears
=== PAUSE TestAccS3ControlAccessPoint_disappears
=== RUN   TestAccS3ControlAccessPoint_Bucket_arn
=== PAUSE TestAccS3ControlAccessPoint_Bucket_arn
=== RUN   TestAccS3ControlAccessPoint_policy
=== PAUSE TestAccS3ControlAccessPoint_policy
=== RUN   TestAccS3ControlAccessPoint_publicAccessBlock
=== PAUSE TestAccS3ControlAccessPoint_publicAccessBlock
=== RUN   TestAccS3ControlAccessPoint_vpc
=== PAUSE TestAccS3ControlAccessPoint_vpc
=== CONT  TestAccS3ControlAccessPoint_basic
=== CONT  TestAccS3ControlAccessPoint_publicAccessBlock
=== CONT  TestAccS3ControlAccessPoint_disappears
=== CONT  TestAccS3ControlAccessPoint_vpc
=== CONT  TestAccS3ControlAccessPoint_policy
=== CONT  TestAccS3ControlAccessPoint_Bucket_arn
    acctest.go:1250: skipping since no Outposts found
--- SKIP: TestAccS3ControlAccessPoint_Bucket_arn (1.40s)
--- PASS: TestAccS3ControlAccessPoint_disappears (28.06s)
--- PASS: TestAccS3ControlAccessPoint_basic (30.38s)
--- PASS: TestAccS3ControlAccessPoint_publicAccessBlock (30.51s)
--- PASS: TestAccS3ControlAccessPoint_vpc (30.55s)
--- PASS: TestAccS3ControlAccessPoint_policy (78.29s)
PASS
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/s3control	81.874s
@ewbankkit
r/aws_s3_access_point: Use 'AccessPointCreateResourceID'.
17cd03e 
Acceptance test output:

% make testacc PKG_NAME=internal/service/s3control TESTARGS='-run=TestAccS3ControlAccessPoint_'
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/s3control/... -v -count 1 -parallel 20 -run=TestAccS3ControlAccessPoint_ -timeout 180m
=== RUN   TestAccS3ControlAccessPoint_basic
=== PAUSE TestAccS3ControlAccessPoint_basic
=== RUN   TestAccS3ControlAccessPoint_disappears
=== PAUSE TestAccS3ControlAccessPoint_disappears
=== RUN   TestAccS3ControlAccessPoint_Bucket_arn
=== PAUSE TestAccS3ControlAccessPoint_Bucket_arn
=== RUN   TestAccS3ControlAccessPoint_policy
=== PAUSE TestAccS3ControlAccessPoint_policy
=== RUN   TestAccS3ControlAccessPoint_publicAccessBlock
=== PAUSE TestAccS3ControlAccessPoint_publicAccessBlock
=== RUN   TestAccS3ControlAccessPoint_vpc
=== PAUSE TestAccS3ControlAccessPoint_vpc
=== CONT  TestAccS3ControlAccessPoint_basic
=== CONT  TestAccS3ControlAccessPoint_publicAccessBlock
=== CONT  TestAccS3ControlAccessPoint_Bucket_arn
=== CONT  TestAccS3ControlAccessPoint_disappears
=== CONT  TestAccS3ControlAccessPoint_vpc
=== CONT  TestAccS3ControlAccessPoint_policy
=== CONT  TestAccS3ControlAccessPoint_Bucket_arn
    acctest.go:1250: skipping since no Outposts found
--- SKIP: TestAccS3ControlAccessPoint_Bucket_arn (1.52s)
--- PASS: TestAccS3ControlAccessPoint_disappears (28.41s)
--- PASS: TestAccS3ControlAccessPoint_basic (32.08s)
--- PASS: TestAccS3ControlAccessPoint_publicAccessBlock (32.11s)
--- PASS: TestAccS3ControlAccessPoint_vpc (32.46s)
--- PASS: TestAccS3ControlAccessPoint_policy (81.88s)
PASS
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/s3control	85.830s
@ewbankkit
r/aws_s3_access_point: 'vpc_configuration.vpc_id' is ForceNew.
7baaa93
@ewbankkit
r/aws_s3_access_point: Add 'alias' attribute.
68d9efc 
Acceptance test output:

% make testacc PKG_NAME=internal/service/s3control TESTARGS='-run=TestAccS3ControlAccessPoint_basic'
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/s3control/... -v -count 1 -parallel 20 -run=TestAccS3ControlAccessPoint_basic -timeout 180m
=== RUN   TestAccS3ControlAccessPoint_basic
=== PAUSE TestAccS3ControlAccessPoint_basic
=== CONT  TestAccS3ControlAccessPoint_basic
--- PASS: TestAccS3ControlAccessPoint_basic (28.71s)
PASS
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/s3control	32.316s
@ewbankkit
r/aws_s3_access_point: Add 'endpoints' attribute.
8080e13 
Acceptance test output:

% make testacc PKG_NAME=internal/service/s3control TESTARGS='-run=TestAccS3ControlAccessPoint_basic'
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/s3control/... -v -count 1 -parallel 20 -run=TestAccS3ControlAccessPoint_basic -timeout 180m
=== RUN   TestAccS3ControlAccessPoint_basic
=== PAUSE TestAccS3ControlAccessPoint_basic
=== CONT  TestAccS3ControlAccessPoint_basic
--- PASS: TestAccS3ControlAccessPoint_basic (27.17s)
PASS
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/s3control	30.729s
@ewbankkit
r/aws_s3_access_point: Tidy 'testAccCheckAccessPointPolicyExists'.
332f720 
Acceptance test output:

 % make testacc PKG_NAME=internal/service/s3control TESTARGS='-run=TestAccS3ControlAccessPoint_policy'
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/s3control/... -v -count 1 -parallel 20 -run=TestAccS3ControlAccessPoint_policy -timeout 180m
=== RUN   TestAccS3ControlAccessPoint_policy
=== PAUSE TestAccS3ControlAccessPoint_policy
=== CONT  TestAccS3ControlAccessPoint_policy
--- PASS: TestAccS3ControlAccessPoint_policy (78.00s)
PASS
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/s3control	81.501s
ewbankkit
ewbankkit approved these changes Nov 16, 2021
View reviewed changes
Copy link
Contributor

@ewbankkit ewbankkit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀.

Commercial
% make testacc PKG_NAME=internal/service/s3control TESTARGS='-run=TestAccS3ControlObjectLambdaAccessPointPolicy_\|TestAccS3ControlObjectLambdaAccessPoint_\|TestAccS3ControlAccessPoint_\|TestAccS3ControlAccessPointPolicy_'
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/s3control/... -v -count 1 -parallel 20 -run=TestAccS3ControlObjectLambdaAccessPointPolicy_\|TestAccS3ControlObjectLambdaAccessPoint_\|TestAccS3ControlAccessPoint_\|TestAccS3ControlAccessPointPolicy_ -timeout 180m
=== RUN   TestAccS3ControlAccessPointPolicy_basic
=== PAUSE TestAccS3ControlAccessPointPolicy_basic
=== RUN   TestAccS3ControlAccessPointPolicy_disappears
=== PAUSE TestAccS3ControlAccessPointPolicy_disappears
=== RUN   TestAccS3ControlAccessPointPolicy_disappears_AccessPoint
=== PAUSE TestAccS3ControlAccessPointPolicy_disappears_AccessPoint
=== RUN   TestAccS3ControlAccessPointPolicy_update
=== PAUSE TestAccS3ControlAccessPointPolicy_update
=== RUN   TestAccS3ControlAccessPoint_basic
=== PAUSE TestAccS3ControlAccessPoint_basic
=== RUN   TestAccS3ControlAccessPoint_disappears
=== PAUSE TestAccS3ControlAccessPoint_disappears
=== RUN   TestAccS3ControlAccessPoint_Bucket_arn
=== PAUSE TestAccS3ControlAccessPoint_Bucket_arn
=== RUN   TestAccS3ControlAccessPoint_policy
=== PAUSE TestAccS3ControlAccessPoint_policy
=== RUN   TestAccS3ControlAccessPoint_publicAccessBlock
=== PAUSE TestAccS3ControlAccessPoint_publicAccessBlock
=== RUN   TestAccS3ControlAccessPoint_vpc
=== PAUSE TestAccS3ControlAccessPoint_vpc
=== RUN   TestAccS3ControlObjectLambdaAccessPointPolicy_basic
=== PAUSE TestAccS3ControlObjectLambdaAccessPointPolicy_basic
=== RUN   TestAccS3ControlObjectLambdaAccessPointPolicy_disappears
=== PAUSE TestAccS3ControlObjectLambdaAccessPointPolicy_disappears
=== RUN   TestAccS3ControlObjectLambdaAccessPointPolicy_disappears_AccessPoint
=== PAUSE TestAccS3ControlObjectLambdaAccessPointPolicy_disappears_AccessPoint
=== RUN   TestAccS3ControlObjectLambdaAccessPointPolicy_update
=== PAUSE TestAccS3ControlObjectLambdaAccessPointPolicy_update
=== RUN   TestAccS3ControlObjectLambdaAccessPoint_basic
=== PAUSE TestAccS3ControlObjectLambdaAccessPoint_basic
=== RUN   TestAccS3ControlObjectLambdaAccessPoint_disappears
=== PAUSE TestAccS3ControlObjectLambdaAccessPoint_disappears
=== RUN   TestAccS3ControlObjectLambdaAccessPoint_update
=== PAUSE TestAccS3ControlObjectLambdaAccessPoint_update
=== CONT  TestAccS3ControlAccessPointPolicy_basic
=== CONT  TestAccS3ControlObjectLambdaAccessPointPolicy_basic
=== CONT  TestAccS3ControlObjectLambdaAccessPoint_disappears
=== CONT  TestAccS3ControlObjectLambdaAccessPoint_basic
=== CONT  TestAccS3ControlObjectLambdaAccessPointPolicy_disappears_AccessPoint
=== CONT  TestAccS3ControlAccessPoint_policy
=== CONT  TestAccS3ControlObjectLambdaAccessPointPolicy_update
=== CONT  TestAccS3ControlAccessPointPolicy_update
=== CONT  TestAccS3ControlAccessPointPolicy_disappears_AccessPoint
=== CONT  TestAccS3ControlAccessPoint_disappears
=== CONT  TestAccS3ControlObjectLambdaAccessPoint_update
=== CONT  TestAccS3ControlAccessPoint_publicAccessBlock
=== CONT  TestAccS3ControlObjectLambdaAccessPointPolicy_disappears
=== CONT  TestAccS3ControlAccessPoint_Bucket_arn
=== CONT  TestAccS3ControlAccessPointPolicy_disappears
=== CONT  TestAccS3ControlAccessPoint_basic
=== CONT  TestAccS3ControlAccessPoint_vpc
=== CONT  TestAccS3ControlAccessPoint_Bucket_arn
    acctest.go:1250: skipping since no Outposts found
--- SKIP: TestAccS3ControlAccessPoint_Bucket_arn (1.58s)
--- PASS: TestAccS3ControlAccessPoint_disappears (51.99s)
--- PASS: TestAccS3ControlAccessPoint_publicAccessBlock (57.89s)
--- PASS: TestAccS3ControlAccessPoint_vpc (58.08s)
--- PASS: TestAccS3ControlAccessPoint_basic (58.28s)
--- PASS: TestAccS3ControlAccessPointPolicy_disappears_AccessPoint (59.89s)
--- PASS: TestAccS3ControlAccessPointPolicy_disappears (60.64s)
--- PASS: TestAccS3ControlAccessPointPolicy_basic (65.05s)
--- PASS: TestAccS3ControlObjectLambdaAccessPoint_basic (82.57s)
--- PASS: TestAccS3ControlObjectLambdaAccessPoint_disappears (87.94s)
--- PASS: TestAccS3ControlAccessPointPolicy_update (95.94s)
--- PASS: TestAccS3ControlObjectLambdaAccessPointPolicy_basic (99.01s)
--- PASS: TestAccS3ControlObjectLambdaAccessPointPolicy_disappears (102.15s)
--- PASS: TestAccS3ControlObjectLambdaAccessPoint_update (103.06s)
--- PASS: TestAccS3ControlObjectLambdaAccessPointPolicy_update (107.04s)
--- PASS: TestAccS3ControlObjectLambdaAccessPointPolicy_disappears_AccessPoint (109.53s)
--- PASS: TestAccS3ControlAccessPoint_policy (117.86s)
PASS
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/s3control	121.246s
GovCloud
% make testacc PKG_NAME=internal/service/s3control TESTARGS='-run=TestAccS3ControlObjectLambdaAccessPointPolicy_\|TestAccS3ControlObjectLambdaAccessPoint_\|TestAccS3ControlAccessPoint_\|TestAccS3ControlAccessPointPolicy_'
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/s3control/... -v -count 1 -parallel 20 -run=TestAccS3ControlObjectLambdaAccessPointPolicy_\|TestAccS3ControlObjectLambdaAccessPoint_\|TestAccS3ControlAccessPoint_\|TestAccS3ControlAccessPointPolicy_ -timeout 180m
=== RUN   TestAccS3ControlAccessPointPolicy_basic
=== PAUSE TestAccS3ControlAccessPointPolicy_basic
=== RUN   TestAccS3ControlAccessPointPolicy_disappears
=== PAUSE TestAccS3ControlAccessPointPolicy_disappears
=== RUN   TestAccS3ControlAccessPointPolicy_disappears_AccessPoint
=== PAUSE TestAccS3ControlAccessPointPolicy_disappears_AccessPoint
=== RUN   TestAccS3ControlAccessPointPolicy_update
=== PAUSE TestAccS3ControlAccessPointPolicy_update
=== RUN   TestAccS3ControlAccessPoint_basic
=== PAUSE TestAccS3ControlAccessPoint_basic
=== RUN   TestAccS3ControlAccessPoint_disappears
=== PAUSE TestAccS3ControlAccessPoint_disappears
=== RUN   TestAccS3ControlAccessPoint_Bucket_arn
=== PAUSE TestAccS3ControlAccessPoint_Bucket_arn
=== RUN   TestAccS3ControlAccessPoint_policy
=== PAUSE TestAccS3ControlAccessPoint_policy
=== RUN   TestAccS3ControlAccessPoint_publicAccessBlock
=== PAUSE TestAccS3ControlAccessPoint_publicAccessBlock
=== RUN   TestAccS3ControlAccessPoint_vpc
=== PAUSE TestAccS3ControlAccessPoint_vpc
=== RUN   TestAccS3ControlObjectLambdaAccessPointPolicy_basic
=== PAUSE TestAccS3ControlObjectLambdaAccessPointPolicy_basic
=== RUN   TestAccS3ControlObjectLambdaAccessPointPolicy_disappears
=== PAUSE TestAccS3ControlObjectLambdaAccessPointPolicy_disappears
=== RUN   TestAccS3ControlObjectLambdaAccessPointPolicy_disappears_AccessPoint
=== PAUSE TestAccS3ControlObjectLambdaAccessPointPolicy_disappears_AccessPoint
=== RUN   TestAccS3ControlObjectLambdaAccessPointPolicy_update
=== PAUSE TestAccS3ControlObjectLambdaAccessPointPolicy_update
=== RUN   TestAccS3ControlObjectLambdaAccessPoint_basic
=== PAUSE TestAccS3ControlObjectLambdaAccessPoint_basic
=== RUN   TestAccS3ControlObjectLambdaAccessPoint_disappears
=== PAUSE TestAccS3ControlObjectLambdaAccessPoint_disappears
=== RUN   TestAccS3ControlObjectLambdaAccessPoint_update
=== PAUSE TestAccS3ControlObjectLambdaAccessPoint_update
=== CONT  TestAccS3ControlAccessPointPolicy_basic
=== CONT  TestAccS3ControlAccessPoint_vpc
=== CONT  TestAccS3ControlObjectLambdaAccessPointPolicy_disappears_AccessPoint
=== CONT  TestAccS3ControlObjectLambdaAccessPoint_basic
=== CONT  TestAccS3ControlObjectLambdaAccessPoint_update
=== CONT  TestAccS3ControlObjectLambdaAccessPoint_disappears
=== CONT  TestAccS3ControlAccessPoint_policy
=== CONT  TestAccS3ControlObjectLambdaAccessPointPolicy_disappears
=== CONT  TestAccS3ControlAccessPoint_publicAccessBlock
=== CONT  TestAccS3ControlAccessPointPolicy_update
=== CONT  TestAccS3ControlAccessPoint_basic
=== CONT  TestAccS3ControlObjectLambdaAccessPointPolicy_basic
=== CONT  TestAccS3ControlAccessPoint_disappears
=== CONT  TestAccS3ControlAccessPointPolicy_disappears
=== CONT  TestAccS3ControlObjectLambdaAccessPointPolicy_update
=== CONT  TestAccS3ControlAccessPoint_Bucket_arn
=== CONT  TestAccS3ControlAccessPointPolicy_disappears_AccessPoint
=== CONT  TestAccS3ControlAccessPoint_Bucket_arn
    acctest.go:1250: skipping since no Outposts found
--- SKIP: TestAccS3ControlAccessPoint_Bucket_arn (2.46s)
--- PASS: TestAccS3ControlAccessPointPolicy_disappears_AccessPoint (58.70s)
--- PASS: TestAccS3ControlAccessPoint_disappears (58.78s)
--- PASS: TestAccS3ControlAccessPointPolicy_disappears (61.42s)
--- PASS: TestAccS3ControlAccessPoint_basic (62.08s)
--- PASS: TestAccS3ControlAccessPoint_vpc (63.58s)
--- PASS: TestAccS3ControlAccessPoint_publicAccessBlock (64.03s)
--- PASS: TestAccS3ControlAccessPointPolicy_basic (65.63s)
--- PASS: TestAccS3ControlObjectLambdaAccessPointPolicy_basic (72.16s)
--- PASS: TestAccS3ControlObjectLambdaAccessPoint_disappears (73.60s)
--- PASS: TestAccS3ControlObjectLambdaAccessPoint_basic (83.52s)
--- PASS: TestAccS3ControlObjectLambdaAccessPointPolicy_disappears (87.14s)
--- PASS: TestAccS3ControlObjectLambdaAccessPointPolicy_disappears_AccessPoint (92.20s)
--- PASS: TestAccS3ControlAccessPointPolicy_update (98.65s)
--- PASS: TestAccS3ControlAccessPoint_policy (124.01s)
--- PASS: TestAccS3ControlObjectLambdaAccessPoint_update (131.49s)
--- PASS: TestAccS3ControlObjectLambdaAccessPointPolicy_update (131.65s)
PASS
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/s3control	140.152s

@ewbankkit ewbankkit removed their assignment Nov 16, 2021
@ewbankkit
Copy link
Contributor

@gijzelaerr Thanks for the contribution 🎉 👏.

@ewbankkit ewbankkit merged commit 98a2575 into hashicorp:main Nov 16, 2021
@github-actions github-actions bot modified the milestones: Roadmap, v3.66.0 Nov 16, 2021
@github-actions
Copy link

This functionality has been released in v3.66.0 of the Terraform AWS Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

@github-actions
Copy link

github-actions bot commented Jun 8, 2022

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jun 8, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@github-actions github-actions[bot] github-actions[bot] left review comments

@ewbankkit ewbankkit ewbankkit approved these changes

Assignees
No one assigned
Labels
documentation Introduces or discusses updates to documentation. new-resource Introduces a new resource. provider Pertains to the provider itself, rather than any interaction with AWS. service/s3control Issues and PRs that pertain to the s3control service. service/s3 Issues and PRs that pertain to the s3 service. size/XL Managed by automation to categorize the size of a PR. size/XXL Managed by automation to categorize the size of a PR. sweeper Pertains to changes to or issues with the sweeper. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure.
Projects
None yet
Milestone
v3.66.0
5 participants
@gijzelaerr @damogallagher @zhelding @breathingdust @ewbankkit