Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement object lambda access points for S3 #19294

Merged
merged 28 commits into from
Nov 16, 2021
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
28 commits
Select commit Hold shift + click to select a range
948e4dd
first work
gijzelaerr May 10, 2021
eede8dd
progress
gijzelaerr May 12, 2021
f557d86
small steps
gijzelaerr May 25, 2021
b630c47
Rename resource and associated acceptance test files.
ewbankkit Nov 14, 2021
50834fa
r/aws_s3control_object_lambda_access_point: First compiling version.
ewbankkit Nov 14, 2021
b63516a
r/aws_s3control_object_lambda_access_point: First compiling acceptanc…
ewbankkit Nov 14, 2021
b718065
r/aws_s3control_object_lambda_access_point: Sweeper.
ewbankkit Nov 14, 2021
9ee6369
Add CHANGELOG entry.
ewbankkit Nov 14, 2021
518054d
Add documentation.
ewbankkit Nov 14, 2021
d0065a2
Add 'arn' attribute.
ewbankkit Nov 14, 2021
dc7ae21
Add and use 'FindObjectLambdaAccessPointByAccountIDAndName'.
ewbankkit Nov 14, 2021
d99e984
'S3ControlConn' -> 'S3ControlConnForMRAP'.
ewbankkit Nov 14, 2021
5cc4414
r/aws_s3control_object_lambda_access_point: Add flatteners.
ewbankkit Nov 15, 2021
fb7ad6b
r/aws_s3control_object_lambda_access_point: First passing acceptance …
ewbankkit Nov 15, 2021
bf0a696
r/aws_s3control_object_lambda_access_point: Acceptance tests passing.
ewbankkit Nov 15, 2021
e37bd09
r/aws_s3control_object_lambda_access_point: Add 'TestAccS3ControlObje…
ewbankkit Nov 15, 2021
b0ca9fb
r/aws_s3control_object_lambda_access_point_policy: New resource.
ewbankkit Nov 15, 2021
8097361
r/aws_s3control_object_lambda_access_point_policy: Add documentation.
ewbankkit Nov 15, 2021
97e5f2b
r/aws_s3control_object_lambda_access_point_policy: Passing acceptance…
ewbankkit Nov 15, 2021
4bad1e9
Fix golangci-lint error: 'directive ... unused for linter "deadcode" …
ewbankkit Nov 15, 2021
d26b359
r/aws_s3control_access_point_policy: New resource.
ewbankkit Nov 15, 2021
63e88c7
r/aws_s3_access_point: 'policy' can not (yet) be Computed as that's a…
ewbankkit Nov 16, 2021
5f6cafd
r/aws_s3_access_point: Add 'FindAccessPointByAccountIDAndName'.
ewbankkit Nov 16, 2021
17cd03e
r/aws_s3_access_point: Use 'AccessPointCreateResourceID'.
ewbankkit Nov 16, 2021
7baaa93
r/aws_s3_access_point: 'vpc_configuration.vpc_id' is ForceNew.
ewbankkit Nov 16, 2021
68d9efc
r/aws_s3_access_point: Add 'alias' attribute.
ewbankkit Nov 16, 2021
8080e13
r/aws_s3_access_point: Add 'endpoints' attribute.
ewbankkit Nov 16, 2021
332f720
r/aws_s3_access_point: Tidy 'testAccCheckAccessPointPolicyExists'.
ewbankkit Nov 16, 2021
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
23 changes: 23 additions & 0 deletions .changelog/19294.txt
Original file line number Diff line number Diff line change
@@ -0,0 +1,23 @@
```release-note:new-resource
aws_s3control_object_lambda_access_point
```

```release-note:new-resource
aws_s3control_object_lambda_access_point_policy
```

```release-note:new-resource
aws_s3control_access_point_policy
```

```release-note:bug
aws_s3_access_point: `vpc_configuration.vpc_id` is _ForceNew_
```

```release-note:enhancement
aws_s3_access_point: Add `alias` attribute
```

```release-note:enhancement
aws_s3_access_point: Add `endpoints` attribute
```
17 changes: 10 additions & 7 deletions internal/provider/provider.go
Original file line number Diff line number Diff line change
Expand Up @@ -1478,13 +1478,16 @@ func Provider() *schema.Provider {
"aws_s3_bucket_public_access_block": s3.ResourceBucketPublicAccessBlock(),
"aws_s3_object_copy": s3.ResourceObjectCopy(),

"aws_s3_access_point": s3control.ResourceAccessPoint(),
"aws_s3_account_public_access_block": s3control.ResourceAccountPublicAccessBlock(),
"aws_s3control_bucket": s3control.ResourceBucket(),
"aws_s3control_bucket_lifecycle_configuration": s3control.ResourceBucketLifecycleConfiguration(),
"aws_s3control_bucket_policy": s3control.ResourceBucketPolicy(),
"aws_s3control_multi_region_access_point": s3control.ResourceMultiRegionAccessPoint(),
"aws_s3control_multi_region_access_point_policy": s3control.ResourceMultiRegionAccessPointPolicy(),
"aws_s3_access_point": s3control.ResourceAccessPoint(),
"aws_s3control_access_point_policy": s3control.ResourceAccessPointPolicy(),
"aws_s3_account_public_access_block": s3control.ResourceAccountPublicAccessBlock(),
"aws_s3control_bucket": s3control.ResourceBucket(),
"aws_s3control_bucket_lifecycle_configuration": s3control.ResourceBucketLifecycleConfiguration(),
"aws_s3control_bucket_policy": s3control.ResourceBucketPolicy(),
"aws_s3control_multi_region_access_point": s3control.ResourceMultiRegionAccessPoint(),
"aws_s3control_multi_region_access_point_policy": s3control.ResourceMultiRegionAccessPointPolicy(),
"aws_s3control_object_lambda_access_point": s3control.ResourceObjectLambdaAccessPoint(),
"aws_s3control_object_lambda_access_point_policy": s3control.ResourceObjectLambdaAccessPointPolicy(),

"aws_s3outposts_endpoint": s3outposts.ResourceEndpoint(),

Expand Down
1 change: 1 addition & 0 deletions internal/service/s3/sweep.go
Original file line number Diff line number Diff line change
Expand Up @@ -33,6 +33,7 @@ func init() {
Dependencies: []string{
"aws_s3_access_point",
"aws_s3_bucket_object",
"aws_s3control_multi_region_access_point",
},
})
}
Expand Down
Loading