-
Notifications
You must be signed in to change notification settings - Fork 9.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
r/servicecatalog_provisioning_artifact: New resource #19316
Conversation
e402bdd
to
478be9f
Compare
website/docs/r/servicecatalog_provisioning_artifact.html.markdown
Outdated
Show resolved
Hide resolved
website/docs/r/servicecatalog_provisioning_artifact.html.markdown
Outdated
Show resolved
Hide resolved
website/docs/r/servicecatalog_provisioning_artifact.html.markdown
Outdated
Show resolved
Hide resolved
Overall LGTM, just some small edits needed in the documentation and comments above for consideration Output of acceptance tests (commercial):
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great (hehe almost.. 👀 merge conficts pending)! 🚀 🚀 🚀
Output of acceptance tests (commercial):
--- PASS: TestAccAWSServiceCatalogProduct_disappears (41.54s)
--- PASS: TestAccAWSServiceCatalogConstraint_basic (41.91s)
--- PASS: TestAccAWSServiceCatalogConstraint_disappears (42.26s)
--- PASS: TestAccAWSServiceCatalogProvisioningArtifact_disappears (44.23s)
--- PASS: TestAccAWSServiceCatalogProduct_basic (45.38s)
--- PASS: TestAccAWSServiceCatalogProvisioningArtifact_basic (46.71s)
--- PASS: TestAccAWSServiceCatalogProduct_update (63.07s)
--- PASS: TestAccAWSServiceCatalogConstraint_update (63.29s)
--- PASS: TestAccAWSServiceCatalogProduct_updateTags (63.78s)
--- PASS: TestAccAWSServiceCatalogProvisioningArtifact_update (65.96s)
--- PASS: TestAccAWSServiceCatalogProductPortfolioAssociation_disappears (85.42s)
--- PASS: TestAccAWSServiceCatalogProduct_physicalID (89.47s)
--- PASS: TestAccAWSServiceCatalogProductPortfolioAssociation_basic (89.76s)
--- PASS: TestAccAWSServiceCatalogProvisioningArtifact_physicalID (90.36s)
Output of acceptance tests (gov cloud):
--- PASS: TestAccAWSServiceCatalogProvisioningArtifact_basic (35.61s)
--- PASS: TestAccAWSServiceCatalogProvisioningArtifact_update (984.79s)
--- PASS: TestAccAWSServiceCatalogProvisioningArtifact_physicalID (1085.61s)
--- PASS: TestAccAWSServiceCatalogProvisioningArtifact_disappears (1151.87s)
517061b
to
9d153a0
Compare
This has been released in version 3.43.0 of the Terraform AWS provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading. For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template for triage. Thanks! |
I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. |
Community Note
Relates #15369
Relates #18074
Relates #19122
Output from acceptance testing (
us-west-2
):Output from acceptance testing (GovCloud):