Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

r/servicecatalog_provisioning_artifact: New resource #19316

Merged
merged 21 commits into from
May 20, 2021

Conversation

YakDriver
Copy link
Member

@YakDriver YakDriver commented May 11, 2021

Community Note

  • Please vote on this pull request by adding a 👍 reaction to the original pull request comment to help the community and maintainers prioritize this request
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for pull request followers and do not help prioritize the request

Relates #15369
Relates #18074
Relates #19122

Output from acceptance testing (us-west-2):

--- PASS: TestAccAWSServiceCatalogConstraint_basic (38.59s)
--- PASS: TestAccAWSServiceCatalogConstraint_disappears (36.14s)
--- PASS: TestAccAWSServiceCatalogConstraint_update (57.15s)

--- PASS: TestAccAWSServiceCatalogProduct_basic (35.98s)
--- PASS: TestAccAWSServiceCatalogProduct_disappears (34.19s)
--- PASS: TestAccAWSServiceCatalogProduct_physicalID (74.97s)
--- PASS: TestAccAWSServiceCatalogProduct_update (53.49s)
--- PASS: TestAccAWSServiceCatalogProduct_updateTags (51.04s)

--- PASS: TestAccAWSServiceCatalogProductPortfolioAssociation_basic (76.22s)
--- PASS: TestAccAWSServiceCatalogProductPortfolioAssociation_disappears (74.70s)

--- PASS: TestAccAWSServiceCatalogProvisioningArtifact_basic (37.53s)
--- PASS: TestAccAWSServiceCatalogProvisioningArtifact_disappears (35.13s)
--- PASS: TestAccAWSServiceCatalogProvisioningArtifact_physicalID (76.61s)
--- PASS: TestAccAWSServiceCatalogProvisioningArtifact_update (58.26s)

Output from acceptance testing (GovCloud):

--- PASS: TestAccAWSServiceCatalogConstraint_basic (39.99s)
--- PASS: TestAccAWSServiceCatalogConstraint_disappears (38.20s)
--- PASS: TestAccAWSServiceCatalogConstraint_update (61.19s)

--- PASS: TestAccAWSServiceCatalogProduct_basic (37.55s)
--- PASS: TestAccAWSServiceCatalogProduct_disappears (34.19s)
--- PASS: TestAccAWSServiceCatalogProduct_physicalID (78.46s)
--- PASS: TestAccAWSServiceCatalogProduct_update (58.29s)
--- PASS: TestAccAWSServiceCatalogProduct_updateTags (58.19s)

--- PASS: TestAccAWSServiceCatalogProductPortfolioAssociation_basic (79.64s)
--- PASS: TestAccAWSServiceCatalogProductPortfolioAssociation_disappears (77.50s)

--- PASS: TestAccAWSServiceCatalogProvisioningArtifact_basic (43.20s)
--- PASS: TestAccAWSServiceCatalogProvisioningArtifact_disappears (36.54s)
--- PASS: TestAccAWSServiceCatalogProvisioningArtifact_physicalID (79.18s)
--- PASS: TestAccAWSServiceCatalogProvisioningArtifact_update (59.69s)

@YakDriver YakDriver requested a review from a team as a code owner May 11, 2021 16:51
@ghost ghost added size/XL Managed by automation to categorize the size of a PR. documentation Introduces or discusses updates to documentation. provider Pertains to the provider itself, rather than any interaction with AWS. service/servicecatalog Issues and PRs that pertain to the servicecatalog service. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure. labels May 11, 2021
@YakDriver YakDriver changed the title [WIP]r/servicecatalog_provisioning_artifact: New resource [WIP] r/servicecatalog_provisioning_artifact: New resource May 14, 2021
@YakDriver YakDriver force-pushed the f-servicecat-provisioning-artifact branch 3 times, most recently from e402bdd to 478be9f Compare May 19, 2021 14:47
@YakDriver YakDriver changed the title [WIP] r/servicecatalog_provisioning_artifact: New resource r/servicecatalog_provisioning_artifact: New resource May 19, 2021
@ghost ghost added size/XXL Managed by automation to categorize the size of a PR. and removed size/XL Managed by automation to categorize the size of a PR. labels May 19, 2021
@anGie44 anGie44 self-assigned this May 19, 2021
@anGie44
Copy link
Contributor

anGie44 commented May 20, 2021

Overall LGTM, just some small edits needed in the documentation and comments above for consideration

Output of acceptance tests (commercial):

--- PASS: TestAccAWSServiceCatalogProduct_disappears (41.07s)
--- PASS: TestAccAWSServiceCatalogProvisioningArtifact_disappears (44.86s)
--- PASS: TestAccAWSServiceCatalogConstraint_disappears (45.01s)
--- PASS: TestAccAWSServiceCatalogProduct_basic (45.44s)
--- PASS: TestAccAWSServiceCatalogConstraint_basic (47.51s)
--- PASS: TestAccAWSServiceCatalogProvisioningArtifact_basic (48.75s)
--- PASS: TestAccAWSServiceCatalogProduct_update (59.38s)
--- PASS: TestAccAWSServiceCatalogProduct_updateTags (60.75s)
--- PASS: TestAccAWSServiceCatalogConstraint_update (63.30s)
--- PASS: TestAccAWSServiceCatalogProvisioningArtifact_update (64.66s)
--- PASS: TestAccAWSServiceCatalogProductPortfolioAssociation_disappears (87.00s)
--- PASS: TestAccAWSServiceCatalogProvisioningArtifact_physicalID (87.88s)
--- PASS: TestAccAWSServiceCatalogProductPortfolioAssociation_basic (89.83s)
--- PASS: TestAccAWSServiceCatalogProduct_physicalID (89.83s)

@YakDriver YakDriver requested a review from anGie44 May 20, 2021 14:42
Copy link
Contributor

@anGie44 anGie44 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great (hehe almost.. 👀 merge conficts pending)! 🚀 🚀 🚀

Output of acceptance tests (commercial):

--- PASS: TestAccAWSServiceCatalogProduct_disappears (41.54s)
--- PASS: TestAccAWSServiceCatalogConstraint_basic (41.91s)
--- PASS: TestAccAWSServiceCatalogConstraint_disappears (42.26s)
--- PASS: TestAccAWSServiceCatalogProvisioningArtifact_disappears (44.23s)
--- PASS: TestAccAWSServiceCatalogProduct_basic (45.38s)
--- PASS: TestAccAWSServiceCatalogProvisioningArtifact_basic (46.71s)
--- PASS: TestAccAWSServiceCatalogProduct_update (63.07s)
--- PASS: TestAccAWSServiceCatalogConstraint_update (63.29s)
--- PASS: TestAccAWSServiceCatalogProduct_updateTags (63.78s)
--- PASS: TestAccAWSServiceCatalogProvisioningArtifact_update (65.96s)
--- PASS: TestAccAWSServiceCatalogProductPortfolioAssociation_disappears (85.42s)
--- PASS: TestAccAWSServiceCatalogProduct_physicalID (89.47s)
--- PASS: TestAccAWSServiceCatalogProductPortfolioAssociation_basic (89.76s)
--- PASS: TestAccAWSServiceCatalogProvisioningArtifact_physicalID (90.36s)

Output of acceptance tests (gov cloud):

--- PASS: TestAccAWSServiceCatalogProvisioningArtifact_basic (35.61s)
--- PASS: TestAccAWSServiceCatalogProvisioningArtifact_update (984.79s)
--- PASS: TestAccAWSServiceCatalogProvisioningArtifact_physicalID (1085.61s)
--- PASS: TestAccAWSServiceCatalogProvisioningArtifact_disappears (1151.87s)

@YakDriver YakDriver force-pushed the f-servicecat-provisioning-artifact branch from 517061b to 9d153a0 Compare May 20, 2021 18:40
@YakDriver YakDriver added this to the v3.43.0 milestone May 20, 2021
@YakDriver YakDriver merged commit 6c604df into main May 20, 2021
@YakDriver YakDriver deleted the f-servicecat-provisioning-artifact branch May 20, 2021 20:29
github-actions bot pushed a commit that referenced this pull request May 20, 2021
@ghost
Copy link

ghost commented Jun 1, 2021

This has been released in version 3.43.0 of the Terraform AWS provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template for triage. Thanks!

@github-actions
Copy link

github-actions bot commented Jul 2, 2021

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jul 2, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
documentation Introduces or discusses updates to documentation. provider Pertains to the provider itself, rather than any interaction with AWS. service/servicecatalog Issues and PRs that pertain to the servicecatalog service. size/XXL Managed by automation to categorize the size of a PR. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants