Lambda Function: "package_type" variable is redundant

[andrewsavino1]

Community Note

• Please vote on this issue by adding a 👍 reaction to the original issue to help the community and maintainers prioritize this request
• Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for issue followers and do not help prioritize the request
• If you are interested in working on this issue or have submitted a pull request, please leave a comment

Description

The var "package_type" has two options - "Image" and "Zip". The correct value of this variable is known by whether the user specified an image_uri (Image), or s3_bucket/filename (Zip). package_type currently defaults to Zip, which can create confusing error messages if the user is trying to create a Docker Image Lambda.

New or Affected Resource(s)

• aws_lambda_function

Potential Terraform Configuration

(as-is, omitting the package_type input)

References

It may also be helpful to add additional validations, as proposed in #16515.

• #0000

[ewbankkit]

@andrewsavino1 Thanks for raising this issue.
Yes, a plan-time validation (via CustomizeDiff) would be the way to go here.

[andrewsavino1]

Makes sense, I can make a PR to add that plan-time validation. #19514

[github-actions]

Marking this issue as stale due to inactivity. This helps our maintainers find and focus on the active issues. If this issue receives no comments in the next 30 days it will automatically be closed. Maintainers can also remove the stale label.

If this issue was automatically closed and you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. Thank you!

[github-actions]

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems similar to this, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.