Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

aws lambda: Add Plan-time validation checks for Image Type #19514

Closed

Conversation

andrewsavino1
Copy link

@andrewsavino1 andrewsavino1 commented May 25, 2021

The package_type variable is optional and defaults to Zip. This can
cause confusion when a user is trying to create an Image type lambda, as
they may not know that the package type variable is needed.

Community Note

  • Please vote on this pull request by adding a 👍 reaction to the original pull request comment to help the community and maintainers prioritize this request
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for pull request followers and do not help prioritize the request

Closes #19508

Output from acceptance testing (ran them separately):

-->

$  make testacc TESTARGS='-run=TestAccAWSLambdaFunction_expectImagePackageTypeSpecified'
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./aws -v -count 1 -parallel 20 -run=TestAccAWSLambdaFunction_expectImagePackageTypeSpecified -timeout 120m
=== RUN   TestAccAWSLambdaFunction_expectImagePackageTypeSpecified
=== PAUSE TestAccAWSLambdaFunction_expectImagePackageTypeSpecified
=== CONT  TestAccAWSLambdaFunction_expectImagePackageTypeSpecified
--- PASS: TestAccAWSLambdaFunction_expectImagePackageTypeSpecified (2.00s)
PASS
ok      github.com/terraform-providers/terraform-provider-aws/aws       4.794s

$ make testacc TESTARGS='-run=TestAccAWSLambdaFunction_expectImageUriGivenWithImagePackage'
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./aws -v -count 1 -parallel 20 -run=TestAccAWSLambdaFunction_expectImageUriGivenWithImagePackage -timeout 120m
=== RUN   TestAccAWSLambdaFunction_expectImageUriGivenWithImagePackage
=== PAUSE TestAccAWSLambdaFunction_expectImageUriGivenWithImagePackage
=== CONT  TestAccAWSLambdaFunction_expectImageUriGivenWithImagePackage
--- PASS: TestAccAWSLambdaFunction_expectImageUriGivenWithImagePackage (2.40s)
PASS
ok github.com/terraform-providers/terraform-provider-aws/aws       5.225s

The `package_type` variable is optional an defaults to Zip.  This can
cause confusion when a user is trying to create an Image type lambda, as
they may not know that the package type variable is needed.
@andrewsavino1 andrewsavino1 requested a review from a team as a code owner May 25, 2021 13:49
@ghost ghost added the size/M Managed by automation to categorize the size of a PR. label May 25, 2021
@github-actions github-actions bot added needs-triage Waiting for first response or review from a maintainer. service/lambda Issues and PRs that pertain to the lambda service. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure. labels May 25, 2021
Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Welcome @andrewsavino1 👋

It looks like this is your first Pull Request submission to the Terraform AWS Provider! If you haven’t already done so please make sure you have checked out our CONTRIBUTING guide and FAQ to make sure your contribution is adhering to best practice and has all the necessary elements in place for a successful approval.

Also take a look at our FAQ which details how we prioritize Pull Requests for inclusion.

Thanks again, and welcome to the community! 😃

@breathingdust breathingdust added enhancement Requests to existing resources that expand the functionality or scope. and removed needs-triage Waiting for first response or review from a maintainer. labels Sep 3, 2021
@zhelding
Copy link
Contributor

Pull request #21306 has significantly refactored the AWS Provider codebase. As a result, most PRs opened prior to the refactor now have merge conflicts that must be resolved before proceeding.

Specifically, PR #21306 relocated the code for all AWS resources and data sources from a single aws directory to a large number of separate directories in internal/service, each corresponding to a particular AWS service. This separation of code has also allowed for us to simplify the names of underlying functions -- while still avoiding namespace collisions.

We recognize that many pull requests have been open for some time without yet being addressed by our maintainers. Therefore, we want to make it clear that resolving these conflicts in no way affects the prioritization of a particular pull request. Once a pull request has been prioritized for review, the necessary changes will be made by a maintainer -- either directly or in collaboration with the pull request author.

For a more complete description of this refactor, including examples of how old filepaths and function names correspond to their new counterparts: please refer to issue #20000.

For a quick guide on how to amend your pull request to resolve the merge conflicts resulting from this refactor and bring it in line with our new code patterns: please refer to our Service Package Refactor Pull Request Guide.

tomerghelber added a commit to tomerghelber/terraform-provider-aws that referenced this pull request Dec 13, 2021
Runtime option can exist only with a "zip-package", and image config only with an "image-package".
I think it should be checked in a checker here too:
hashicorp#19514
@github-actions
Copy link

Marking this pull request as stale due to inactivity. This helps our maintainers find and focus on the active pull requests. If this pull request receives no comments in the next 30 days it will automatically be closed. Maintainers can also remove the stale label.

If this pull request was automatically closed and you feel this pull request should be reopened, we encourage creating a new pull request linking back to this one for added context. Thank you!

@github-actions github-actions bot added the stale Old or inactive issues managed by automation, if no further action taken these will get closed. label Oct 15, 2023
@github-actions github-actions bot closed this Nov 15, 2023
Copy link

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Dec 16, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
enhancement Requests to existing resources that expand the functionality or scope. service/lambda Issues and PRs that pertain to the lambda service. size/M Managed by automation to categorize the size of a PR. stale Old or inactive issues managed by automation, if no further action taken these will get closed. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Lambda Function: "package_type" variable is redundant
3 participants