Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

r/aws_datasync_location_s3: Correctly parse S3 on Outposts location URI #19859

Merged
merged 3 commits into from
Jul 9, 2021
Merged

r/aws_datasync_location_s3: Correctly parse S3 on Outposts location URI #19859

merged 3 commits into from
Jul 9, 2021

Conversation

ewbankkit
Copy link
Contributor

@ewbankkit ewbankkit commented Jun 17, 2021 •
edited
Loading

Community Note

  • Please vote on this pull request by adding a 👍 reaction to the original pull request comment to help the community and maintainers prioritize this request
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for pull request followers and do not help prioritize the request

Closes #19799.

Output from acceptance testing:

Commercial

--- PASS: TestAccAWSDataSyncLocationS3_storageclass (45.40s)
--- PASS: TestAccAWSDataSyncLocationS3_disappears (52.50s)
--- PASS: TestAccAWSDataSyncLocationS3_basic (54.25s)
--- PASS: TestAccAWSDataSyncLocationS3_Tags (78.89s)
--- PASS: TestAccAWSDataSyncLocationEfs_basic (150.26s)
--- PASS: TestAccAWSDataSyncLocationEfs_disappears (152.82s)
--- PASS: TestAccAWSDataSyncLocationEfs_Subdirectory (160.60s)
--- PASS: TestAccAWSDataSyncLocationSmb_basic (190.45s)
--- PASS: TestAccAWSDataSyncLocationSmb_Tags (176.97s)
--- PASS: TestAccAWSDataSyncLocationEfs_Tags (225.82s)
--- PASS: TestAccAWSDataSyncLocationNfs_disappears (229.26s)
--- PASS: TestAccAWSDataSyncLocationSmb_disappears (229.29s)
--- PASS: TestAccAWSDataSyncLocationNfs_basic (238.78s)
--- PASS: TestAccAWSDataSyncLocationNfs_mountOptions (269.72s)
--- PASS: TestAccAWSDataSyncLocationNfs_Tags (272.11s)
--- PASS: TestAccAWSDataSyncLocationNfs_AgentARNs_Multple (279.25s)
--- PASS: TestAccAWSDataSyncLocationNfs_Subdirectory (280.93s)
--- PASS: TestAccAWSDataSyncLocationFsxWindows_basic (3255.56s)
--- PASS: TestAccAWSDataSyncLocationFsxWindows_tags (3279.60s)
--- PASS: TestAccAWSDataSyncLocationFsxWindows_subdirectory (3320.85s)
--- PASS: TestAccAWSDataSyncLocationFsxWindows_disappears (3404.15s)

@github-actions github-actions bot added service/datasync Issues and PRs that pertain to the datasync service. service/fsx Issues and PRs that pertain to the fsx service. service/location Issues and PRs that pertain to the location service. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure. size/L Managed by automation to categorize the size of a PR. labels Jun 17, 2021
@ewbankkit ewbankkit added bug Addresses a defect in current functionality. and removed service/fsx Issues and PRs that pertain to the fsx service. labels Jun 23, 2021
@YakDriver YakDriver modified the milestone: v3.50.0 Jul 8, 2021
@YakDriver YakDriver self-assigned this Jul 8, 2021
@ewbankkit @YakDriver
Add 'SubdirectoryFromLocationURI'.
45e79f7 
Test output:

% go test -v ./aws/internal/service/datasync
=== RUN   TestSubdirectoryFromLocationURI
=== RUN   TestSubdirectoryFromLocationURI/empty_URI
=== RUN   TestSubdirectoryFromLocationURI/invalid_URI_scheme
=== RUN   TestSubdirectoryFromLocationURI/S3_bucket_URI_no_bucket_name_(1)
=== RUN   TestSubdirectoryFromLocationURI/S3_bucket_URI_no_bucket_name_(2)
=== RUN   TestSubdirectoryFromLocationURI/S3_bucket_URI_top_level
=== RUN   TestSubdirectoryFromLocationURI/S3_bucket_URI_one_level
=== RUN   TestSubdirectoryFromLocationURI/S3_bucket_URI_two_levels
=== RUN   TestSubdirectoryFromLocationURI/S3_Outposts_ARN_URI_top_level
=== RUN   TestSubdirectoryFromLocationURI/S3_Outposts_ARN_URI_one_level
=== RUN   TestSubdirectoryFromLocationURI/S3_Outposts_ARN_URI_two_levels
=== RUN   TestSubdirectoryFromLocationURI/EFS_URI_top_level
=== RUN   TestSubdirectoryFromLocationURI/EFS_URI_one_level
=== RUN   TestSubdirectoryFromLocationURI/EFS_URI_two_levels
=== RUN   TestSubdirectoryFromLocationURI/NFS_URI_top_level
=== RUN   TestSubdirectoryFromLocationURI/NFS_URI_one_level
=== RUN   TestSubdirectoryFromLocationURI/NFS_URI_two_levels
=== RUN   TestSubdirectoryFromLocationURI/SMB_URI_top_level
=== RUN   TestSubdirectoryFromLocationURI/SMB_URI_one_level
=== RUN   TestSubdirectoryFromLocationURI/SMB_URI_two_levels
=== RUN   TestSubdirectoryFromLocationURI/FSx_Windows_URI_top_level
=== RUN   TestSubdirectoryFromLocationURI/FSx_Windows_URI_one_level
=== RUN   TestSubdirectoryFromLocationURI/FSx_Windows_URI_two_levels
--- PASS: TestSubdirectoryFromLocationURI (0.00s)
    --- PASS: TestSubdirectoryFromLocationURI/empty_URI (0.00s)
    --- PASS: TestSubdirectoryFromLocationURI/invalid_URI_scheme (0.00s)
    --- PASS: TestSubdirectoryFromLocationURI/S3_bucket_URI_no_bucket_name_(1) (0.00s)
    --- PASS: TestSubdirectoryFromLocationURI/S3_bucket_URI_no_bucket_name_(2) (0.00s)
    --- PASS: TestSubdirectoryFromLocationURI/S3_bucket_URI_top_level (0.00s)
    --- PASS: TestSubdirectoryFromLocationURI/S3_bucket_URI_one_level (0.00s)
    --- PASS: TestSubdirectoryFromLocationURI/S3_bucket_URI_two_levels (0.00s)
    --- PASS: TestSubdirectoryFromLocationURI/S3_Outposts_ARN_URI_top_level (0.00s)
    --- PASS: TestSubdirectoryFromLocationURI/S3_Outposts_ARN_URI_one_level (0.00s)
    --- PASS: TestSubdirectoryFromLocationURI/S3_Outposts_ARN_URI_two_levels (0.00s)
    --- PASS: TestSubdirectoryFromLocationURI/EFS_URI_top_level (0.00s)
    --- PASS: TestSubdirectoryFromLocationURI/EFS_URI_one_level (0.00s)
    --- PASS: TestSubdirectoryFromLocationURI/EFS_URI_two_levels (0.00s)
    --- PASS: TestSubdirectoryFromLocationURI/NFS_URI_top_level (0.00s)
    --- PASS: TestSubdirectoryFromLocationURI/NFS_URI_one_level (0.00s)
    --- PASS: TestSubdirectoryFromLocationURI/NFS_URI_two_levels (0.00s)
    --- PASS: TestSubdirectoryFromLocationURI/SMB_URI_top_level (0.00s)
    --- PASS: TestSubdirectoryFromLocationURI/SMB_URI_one_level (0.00s)
    --- PASS: TestSubdirectoryFromLocationURI/SMB_URI_two_levels (0.00s)
    --- PASS: TestSubdirectoryFromLocationURI/FSx_Windows_URI_top_level (0.00s)
    --- PASS: TestSubdirectoryFromLocationURI/FSx_Windows_URI_one_level (0.00s)
    --- PASS: TestSubdirectoryFromLocationURI/FSx_Windows_URI_two_levels (0.00s)
PASS
ok  	github.com/terraform-providers/terraform-provider-aws/aws/internal/service/datasync	3.695s
@ewbankkit @YakDriver
Replace 'dataSyncParseLocationURI' with 'SubdirectoryFromLocationURI'.
5882630
@ewbankkit @YakDriver
Add CHANGELOG entry.
8cc7cd9
@YakDriver YakDriver force-pushed the b-aws_datasync_location_s3-outposts-location-arn branch from caae7e0 to 8cc7cd9 Compare July 8, 2021 22:11
@github-actions github-actions bot added the service/fsx Issues and PRs that pertain to the fsx service. label Jul 8, 2021
YakDriver
YakDriver approved these changes Jul 9, 2021
View reviewed changes
Copy link
Member

@YakDriver YakDriver left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! 🎉

You might want to create an issue for the FSx eventual consistency problems.

--- PASS: TestAccAWSDataSyncLocationS3_storageclass (37.24s)
--- PASS: TestAccAWSDataSyncLocationS3_disappears (42.67s)
--- PASS: TestAccAWSDataSyncLocationS3_basic (44.75s)
--- PASS: TestAccAWSDataSyncLocationS3_Tags (87.47s)
--- PASS: TestAccAWSDataSyncLocationEfs_disappears (144.71s)
--- PASS: TestAccAWSDataSyncLocationEfs_Subdirectory (148.01s)
--- PASS: TestAccAWSDataSyncLocationEfs_basic (148.56s)
--- PASS: TestAccAWSDataSyncLocationSmb_disappears (166.34s)
--- PASS: TestAccAWSDataSyncLocationSmb_basic (179.39s)
--- PASS: TestAccAWSDataSyncLocationEfs_Tags (190.91s)
--- PASS: TestAccAWSDataSyncLocationNfs_disappears (199.39s)
--- PASS: TestAccAWSDataSyncLocationNfs_Subdirectory (213.77s)
--- PASS: TestAccAWSDataSyncLocationNfs_AgentARNs_Multple (217.43s)
--- PASS: TestAccAWSDataSyncLocationNfs_mountOptions (223.59s)
--- PASS: TestAccAWSDataSyncLocationNfs_basic (236.90s)
--- PASS: TestAccAWSDataSyncLocationSmb_Tags (250.79s)
--- PASS: TestAccAWSDataSyncLocationNfs_Tags (264.60s)
--- PASS: TestAccAWSDataSyncLocationFsxWindows_subdirectory (1977.78s)
--- PASS: TestAccAWSDataSyncLocationFsxWindows_basic (1977.89s)
--- PASS: TestAccAWSDataSyncLocationFsxWindows_disappears (2089.00s)

@ewbankkit ewbankkit merged commit 69619c0 into main Jul 9, 2021
@ewbankkit ewbankkit deleted the b-aws_datasync_location_s3-outposts-location-arn branch July 9, 2021 21:29
@github-actions github-actions bot added this to the v3.50.0 milestone Jul 9, 2021
github-actions bot pushed a commit that referenced this pull request Jul 9, 2021
Update CHANGELOG.md for #19859
39f0e5a
@github-actions
Copy link

This functionality has been released in v3.50.0 of the Terraform AWS Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

@github-actions
Copy link

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Aug 15, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@YakDriver YakDriver YakDriver approved these changes

Assignees

@YakDriver YakDriver

Labels
bug Addresses a defect in current functionality. service/datasync Issues and PRs that pertain to the datasync service. service/fsx Issues and PRs that pertain to the fsx service. service/location Issues and PRs that pertain to the location service. size/L Managed by automation to categorize the size of a PR. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure.
Projects
None yet
Milestone
v3.50.0
Development

Successfully merging this pull request may close these issues.

resource/aws_datasync_location_s3 error parsing Outpost location S3
2 participants
@ewbankkit @YakDriver