Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

r/aws_datasync_location_s3: Correctly parse S3 on Outposts location URI #19859

Merged
merged 3 commits into from
Jul 9, 2021
Merged

r/aws_datasync_location_s3: Correctly parse S3 on Outposts location URI #19859

merged 3 commits into from
Jul 9, 2021

Commits on Jul 8, 2021

  1. Add 'SubdirectoryFromLocationURI'. 

    Test output:

% go test -v ./aws/internal/service/datasync
=== RUN   TestSubdirectoryFromLocationURI
=== RUN   TestSubdirectoryFromLocationURI/empty_URI
=== RUN   TestSubdirectoryFromLocationURI/invalid_URI_scheme
=== RUN   TestSubdirectoryFromLocationURI/S3_bucket_URI_no_bucket_name_(1)
=== RUN   TestSubdirectoryFromLocationURI/S3_bucket_URI_no_bucket_name_(2)
=== RUN   TestSubdirectoryFromLocationURI/S3_bucket_URI_top_level
=== RUN   TestSubdirectoryFromLocationURI/S3_bucket_URI_one_level
=== RUN   TestSubdirectoryFromLocationURI/S3_bucket_URI_two_levels
=== RUN   TestSubdirectoryFromLocationURI/S3_Outposts_ARN_URI_top_level
=== RUN   TestSubdirectoryFromLocationURI/S3_Outposts_ARN_URI_one_level
=== RUN   TestSubdirectoryFromLocationURI/S3_Outposts_ARN_URI_two_levels
=== RUN   TestSubdirectoryFromLocationURI/EFS_URI_top_level
=== RUN   TestSubdirectoryFromLocationURI/EFS_URI_one_level
=== RUN   TestSubdirectoryFromLocationURI/EFS_URI_two_levels
=== RUN   TestSubdirectoryFromLocationURI/NFS_URI_top_level
=== RUN   TestSubdirectoryFromLocationURI/NFS_URI_one_level
=== RUN   TestSubdirectoryFromLocationURI/NFS_URI_two_levels
=== RUN   TestSubdirectoryFromLocationURI/SMB_URI_top_level
=== RUN   TestSubdirectoryFromLocationURI/SMB_URI_one_level
=== RUN   TestSubdirectoryFromLocationURI/SMB_URI_two_levels
=== RUN   TestSubdirectoryFromLocationURI/FSx_Windows_URI_top_level
=== RUN   TestSubdirectoryFromLocationURI/FSx_Windows_URI_one_level
=== RUN   TestSubdirectoryFromLocationURI/FSx_Windows_URI_two_levels
--- PASS: TestSubdirectoryFromLocationURI (0.00s)
    --- PASS: TestSubdirectoryFromLocationURI/empty_URI (0.00s)
    --- PASS: TestSubdirectoryFromLocationURI/invalid_URI_scheme (0.00s)
    --- PASS: TestSubdirectoryFromLocationURI/S3_bucket_URI_no_bucket_name_(1) (0.00s)
    --- PASS: TestSubdirectoryFromLocationURI/S3_bucket_URI_no_bucket_name_(2) (0.00s)
    --- PASS: TestSubdirectoryFromLocationURI/S3_bucket_URI_top_level (0.00s)
    --- PASS: TestSubdirectoryFromLocationURI/S3_bucket_URI_one_level (0.00s)
    --- PASS: TestSubdirectoryFromLocationURI/S3_bucket_URI_two_levels (0.00s)
    --- PASS: TestSubdirectoryFromLocationURI/S3_Outposts_ARN_URI_top_level (0.00s)
    --- PASS: TestSubdirectoryFromLocationURI/S3_Outposts_ARN_URI_one_level (0.00s)
    --- PASS: TestSubdirectoryFromLocationURI/S3_Outposts_ARN_URI_two_levels (0.00s)
    --- PASS: TestSubdirectoryFromLocationURI/EFS_URI_top_level (0.00s)
    --- PASS: TestSubdirectoryFromLocationURI/EFS_URI_one_level (0.00s)
    --- PASS: TestSubdirectoryFromLocationURI/EFS_URI_two_levels (0.00s)
    --- PASS: TestSubdirectoryFromLocationURI/NFS_URI_top_level (0.00s)
    --- PASS: TestSubdirectoryFromLocationURI/NFS_URI_one_level (0.00s)
    --- PASS: TestSubdirectoryFromLocationURI/NFS_URI_two_levels (0.00s)
    --- PASS: TestSubdirectoryFromLocationURI/SMB_URI_top_level (0.00s)
    --- PASS: TestSubdirectoryFromLocationURI/SMB_URI_one_level (0.00s)
    --- PASS: TestSubdirectoryFromLocationURI/SMB_URI_two_levels (0.00s)
    --- PASS: TestSubdirectoryFromLocationURI/FSx_Windows_URI_top_level (0.00s)
    --- PASS: TestSubdirectoryFromLocationURI/FSx_Windows_URI_one_level (0.00s)
    --- PASS: TestSubdirectoryFromLocationURI/FSx_Windows_URI_two_levels (0.00s)
PASS
ok  	github.com/terraform-providers/terraform-provider-aws/aws/internal/service/datasync	3.695s
    @ewbankkit @YakDriver
    ewbankkit authored and YakDriver committed Jul 8, 2021
    Configuration menu
    Copy the full SHA
    45e79f7 View commit details
    Browse the repository at this point in the history

  2. Replace 'dataSyncParseLocationURI' with 'SubdirectoryFromLocationURI'.

    @ewbankkit @YakDriver
    ewbankkit authored and YakDriver committed Jul 8, 2021
    Configuration menu
    Copy the full SHA
    5882630 View commit details
    Browse the repository at this point in the history

  3. Add CHANGELOG entry.

    @ewbankkit @YakDriver
    ewbankkit authored and YakDriver committed Jul 8, 2021
    Configuration menu
    Copy the full SHA
    8cc7cd9 View commit details
    Browse the repository at this point in the history