-
Notifications
You must be signed in to change notification settings - Fork 9.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
r/aws_shield_protection_group: New resource #20491
r/aws_shield_protection_group: New resource #20491
Conversation
8bf53bd
to
db789a6
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 🚀.
Commercial
% make testacc TESTARGS='-run=TestAccAWSShieldProtectionGroup_'
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./aws -v -count 1 -parallel 20 -run=TestAccAWSShieldProtectionGroup_ -timeout 180m
=== RUN TestAccAWSShieldProtectionGroup_basic
=== PAUSE TestAccAWSShieldProtectionGroup_basic
=== RUN TestAccAWSShieldProtectionGroup_disappears
=== PAUSE TestAccAWSShieldProtectionGroup_disappears
=== RUN TestAccAWSShieldProtectionGroup_aggregation
=== PAUSE TestAccAWSShieldProtectionGroup_aggregation
=== RUN TestAccAWSShieldProtectionGroup_members
=== PAUSE TestAccAWSShieldProtectionGroup_members
=== RUN TestAccAWSShieldProtectionGroup_protectionGroupId
=== PAUSE TestAccAWSShieldProtectionGroup_protectionGroupId
=== RUN TestAccAWSShieldProtectionGroup_resourceType
=== PAUSE TestAccAWSShieldProtectionGroup_resourceType
=== CONT TestAccAWSShieldProtectionGroup_basic
=== CONT TestAccAWSShieldProtectionGroup_protectionGroupId
=== CONT TestAccAWSShieldProtectionGroup_aggregation
=== CONT TestAccAWSShieldProtectionGroup_members
=== CONT TestAccAWSShieldProtectionGroup_resourceType
=== CONT TestAccAWSShieldProtectionGroup_disappears
--- PASS: TestAccAWSShieldProtectionGroup_disappears (13.74s)
--- PASS: TestAccAWSShieldProtectionGroup_basic (18.07s)
--- PASS: TestAccAWSShieldProtectionGroup_members (21.52s)
--- PASS: TestAccAWSShieldProtectionGroup_protectionGroupId (27.87s)
--- PASS: TestAccAWSShieldProtectionGroup_aggregation (28.10s)
--- PASS: TestAccAWSShieldProtectionGroup_resourceType (28.14s)
PASS
ok github.com/terraform-providers/terraform-provider-aws/aws 31.659s
GovCloud
% make testacc TESTARGS='-run=TestAccAWSShieldProtectionGroup_'
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./aws -v -count 1 -parallel 20 -run=TestAccAWSShieldProtectionGroup_ -timeout 180m
=== RUN TestAccAWSShieldProtectionGroup_basic
=== PAUSE TestAccAWSShieldProtectionGroup_basic
=== RUN TestAccAWSShieldProtectionGroup_disappears
=== PAUSE TestAccAWSShieldProtectionGroup_disappears
=== RUN TestAccAWSShieldProtectionGroup_aggregation
=== PAUSE TestAccAWSShieldProtectionGroup_aggregation
=== RUN TestAccAWSShieldProtectionGroup_members
=== PAUSE TestAccAWSShieldProtectionGroup_members
=== RUN TestAccAWSShieldProtectionGroup_protectionGroupId
=== PAUSE TestAccAWSShieldProtectionGroup_protectionGroupId
=== RUN TestAccAWSShieldProtectionGroup_resourceType
=== PAUSE TestAccAWSShieldProtectionGroup_resourceType
=== CONT TestAccAWSShieldProtectionGroup_basic
=== CONT TestAccAWSShieldProtectionGroup_protectionGroupId
=== CONT TestAccAWSShieldProtectionGroup_resourceType
=== CONT TestAccAWSShieldProtectionGroup_aggregation
=== CONT TestAccAWSShieldProtectionGroup_members
=== CONT TestAccAWSShieldProtectionGroup_disappears
=== CONT TestAccAWSShieldProtectionGroup_basic
provider_test.go:735: skipping tests; partition aws-us-gov does not support shield service
=== CONT TestAccAWSShieldProtectionGroup_aggregation
provider_test.go:735: skipping tests; partition aws-us-gov does not support shield service
=== CONT TestAccAWSShieldProtectionGroup_members
provider_test.go:735: skipping tests; partition aws-us-gov does not support shield service
--- SKIP: TestAccAWSShieldProtectionGroup_basic (1.31s)
--- SKIP: TestAccAWSShieldProtectionGroup_aggregation (1.31s)
=== CONT TestAccAWSShieldProtectionGroup_protectionGroupId
provider_test.go:735: skipping tests; partition aws-us-gov does not support shield service
--- SKIP: TestAccAWSShieldProtectionGroup_members (1.31s)
--- SKIP: TestAccAWSShieldProtectionGroup_protectionGroupId (1.31s)
=== CONT TestAccAWSShieldProtectionGroup_disappears
provider_test.go:735: skipping tests; partition aws-us-gov does not support shield service
--- SKIP: TestAccAWSShieldProtectionGroup_disappears (1.31s)
=== CONT TestAccAWSShieldProtectionGroup_resourceType
provider_test.go:735: skipping tests; partition aws-us-gov does not support shield service
--- SKIP: TestAccAWSShieldProtectionGroup_resourceType (1.31s)
PASS
ok github.com/terraform-providers/terraform-provider-aws/aws 4.433s
@farhanangullia Thanks for the contribution 🎉 👏. |
This functionality has been released in v3.54.0 of the Terraform AWS Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading. For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you! |
I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. |
Community Note
Closes #16754
Release note for CHANGELOG:
Output from acceptance testing: