Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

r/aws_shield_protection_group: New resource #20491

Merged
merged 7 commits into from
Aug 11, 2021
Merged

r/aws_shield_protection_group: New resource #20491

merged 7 commits into from
Aug 11, 2021

Conversation

farhanangullia
Copy link
Contributor

Community Note

  • Please vote on this pull request by adding a 👍 reaction to the original pull request comment to help the community and maintainers prioritize this request
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for pull request followers and do not help prioritize the request

Closes #16754

Release note for CHANGELOG:

aws_shield_protection_group

Output from acceptance testing:

$ make testacc TESTARGS='-run=TestAccAWSShieldProtectionGroup'
==> Fixing source code with gofmt...
gofmt -s -w ./aws ./awsproviderlint/helper ./awsproviderlint/main.go ./awsproviderlint/passes
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./aws -v -count 1 -parallel 20 -run=TestAccAWSShieldProtectionGroup -timeout 180m
=== RUN   TestAccAWSShieldProtectionGroup_basic
=== PAUSE TestAccAWSShieldProtectionGroup_basic
=== RUN   TestAccAWSShieldProtectionGroup_disappears
=== PAUSE TestAccAWSShieldProtectionGroup_disappears
=== RUN   TestAccAWSShieldProtectionGroup_aggregation
=== PAUSE TestAccAWSShieldProtectionGroup_aggregation
=== RUN   TestAccAWSShieldProtectionGroup_members
=== PAUSE TestAccAWSShieldProtectionGroup_members
=== RUN   TestAccAWSShieldProtectionGroup_protectionGroupId
=== PAUSE TestAccAWSShieldProtectionGroup_protectionGroupId
=== RUN   TestAccAWSShieldProtectionGroup_resourceType
=== PAUSE TestAccAWSShieldProtectionGroup_resourceType
=== CONT  TestAccAWSShieldProtectionGroup_basic
=== CONT  TestAccAWSShieldProtectionGroup_protectionGroupId
=== CONT  TestAccAWSShieldProtectionGroup_resourceType
=== CONT  TestAccAWSShieldProtectionGroup_aggregation
=== CONT  TestAccAWSShieldProtectionGroup_members
=== CONT  TestAccAWSShieldProtectionGroup_disappears
--- PASS: TestAccAWSShieldProtectionGroup_disappears (92.81s)
--- PASS: TestAccAWSShieldProtectionGroup_basic (116.84s)
--- PASS: TestAccAWSShieldProtectionGroup_members (133.37s)
--- PASS: TestAccAWSShieldProtectionGroup_protectionGroupId (179.45s)
--- PASS: TestAccAWSShieldProtectionGroup_aggregation (185.22s)
--- PASS: TestAccAWSShieldProtectionGroup_resourceType (185.22s)
PASS
ok      github.com/terraform-providers/terraform-provider-aws/aws       186.818s
...

@github-actions github-actions bot added needs-triage Waiting for first response or review from a maintainer. documentation Introduces or discusses updates to documentation. provider Pertains to the provider itself, rather than any interaction with AWS. service/shield Issues and PRs that pertain to the shield service. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure. size/XL Managed by automation to categorize the size of a PR. labels Aug 9, 2021
@farhanangullia farhanangullia force-pushed the f-aws_shield_protection_group branch from 8bf53bd to db789a6 Compare August 9, 2021 12:11
@ewbankkit ewbankkit added new-resource Introduces a new resource. and removed needs-triage Waiting for first response or review from a maintainer. labels Aug 11, 2021
ewbankkit
ewbankkit approved these changes Aug 11, 2021
View reviewed changes
Copy link
Contributor

@ewbankkit ewbankkit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀.

Commercial
% make testacc TESTARGS='-run=TestAccAWSShieldProtectionGroup_'
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./aws -v -count 1 -parallel 20 -run=TestAccAWSShieldProtectionGroup_ -timeout 180m
=== RUN   TestAccAWSShieldProtectionGroup_basic
=== PAUSE TestAccAWSShieldProtectionGroup_basic
=== RUN   TestAccAWSShieldProtectionGroup_disappears
=== PAUSE TestAccAWSShieldProtectionGroup_disappears
=== RUN   TestAccAWSShieldProtectionGroup_aggregation
=== PAUSE TestAccAWSShieldProtectionGroup_aggregation
=== RUN   TestAccAWSShieldProtectionGroup_members
=== PAUSE TestAccAWSShieldProtectionGroup_members
=== RUN   TestAccAWSShieldProtectionGroup_protectionGroupId
=== PAUSE TestAccAWSShieldProtectionGroup_protectionGroupId
=== RUN   TestAccAWSShieldProtectionGroup_resourceType
=== PAUSE TestAccAWSShieldProtectionGroup_resourceType
=== CONT  TestAccAWSShieldProtectionGroup_basic
=== CONT  TestAccAWSShieldProtectionGroup_protectionGroupId
=== CONT  TestAccAWSShieldProtectionGroup_aggregation
=== CONT  TestAccAWSShieldProtectionGroup_members
=== CONT  TestAccAWSShieldProtectionGroup_resourceType
=== CONT  TestAccAWSShieldProtectionGroup_disappears
--- PASS: TestAccAWSShieldProtectionGroup_disappears (13.74s)
--- PASS: TestAccAWSShieldProtectionGroup_basic (18.07s)
--- PASS: TestAccAWSShieldProtectionGroup_members (21.52s)
--- PASS: TestAccAWSShieldProtectionGroup_protectionGroupId (27.87s)
--- PASS: TestAccAWSShieldProtectionGroup_aggregation (28.10s)
--- PASS: TestAccAWSShieldProtectionGroup_resourceType (28.14s)
PASS
ok      github.com/terraform-providers/terraform-provider-aws/aws       31.659s
GovCloud
% make testacc TESTARGS='-run=TestAccAWSShieldProtectionGroup_'
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./aws -v -count 1 -parallel 20 -run=TestAccAWSShieldProtectionGroup_ -timeout 180m
=== RUN   TestAccAWSShieldProtectionGroup_basic
=== PAUSE TestAccAWSShieldProtectionGroup_basic
=== RUN   TestAccAWSShieldProtectionGroup_disappears
=== PAUSE TestAccAWSShieldProtectionGroup_disappears
=== RUN   TestAccAWSShieldProtectionGroup_aggregation
=== PAUSE TestAccAWSShieldProtectionGroup_aggregation
=== RUN   TestAccAWSShieldProtectionGroup_members
=== PAUSE TestAccAWSShieldProtectionGroup_members
=== RUN   TestAccAWSShieldProtectionGroup_protectionGroupId
=== PAUSE TestAccAWSShieldProtectionGroup_protectionGroupId
=== RUN   TestAccAWSShieldProtectionGroup_resourceType
=== PAUSE TestAccAWSShieldProtectionGroup_resourceType
=== CONT  TestAccAWSShieldProtectionGroup_basic
=== CONT  TestAccAWSShieldProtectionGroup_protectionGroupId
=== CONT  TestAccAWSShieldProtectionGroup_resourceType
=== CONT  TestAccAWSShieldProtectionGroup_aggregation
=== CONT  TestAccAWSShieldProtectionGroup_members
=== CONT  TestAccAWSShieldProtectionGroup_disappears
=== CONT  TestAccAWSShieldProtectionGroup_basic
    provider_test.go:735: skipping tests; partition aws-us-gov does not support shield service
=== CONT  TestAccAWSShieldProtectionGroup_aggregation
    provider_test.go:735: skipping tests; partition aws-us-gov does not support shield service
=== CONT  TestAccAWSShieldProtectionGroup_members
    provider_test.go:735: skipping tests; partition aws-us-gov does not support shield service
--- SKIP: TestAccAWSShieldProtectionGroup_basic (1.31s)
--- SKIP: TestAccAWSShieldProtectionGroup_aggregation (1.31s)
=== CONT  TestAccAWSShieldProtectionGroup_protectionGroupId
    provider_test.go:735: skipping tests; partition aws-us-gov does not support shield service
--- SKIP: TestAccAWSShieldProtectionGroup_members (1.31s)
--- SKIP: TestAccAWSShieldProtectionGroup_protectionGroupId (1.31s)
=== CONT  TestAccAWSShieldProtectionGroup_disappears
    provider_test.go:735: skipping tests; partition aws-us-gov does not support shield service
--- SKIP: TestAccAWSShieldProtectionGroup_disappears (1.31s)
=== CONT  TestAccAWSShieldProtectionGroup_resourceType
    provider_test.go:735: skipping tests; partition aws-us-gov does not support shield service
--- SKIP: TestAccAWSShieldProtectionGroup_resourceType (1.31s)
PASS
ok  	github.com/terraform-providers/terraform-provider-aws/aws	4.433s

@ewbankkit
Copy link
Contributor

@farhanangullia Thanks for the contribution 🎉 👏.

@ewbankkit ewbankkit merged commit 358950e into hashicorp:main Aug 11, 2021
@github-actions github-actions bot added this to the v3.54.0 milestone Aug 11, 2021
@github-actions
Copy link

This functionality has been released in v3.54.0 of the Terraform AWS Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

@github-actions
Copy link

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Sep 12, 2021
@justinretzolk justinretzolk added the partner Contribution from a partner. label May 16, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@ewbankkit ewbankkit ewbankkit approved these changes

Assignees
No one assigned
Labels
documentation Introduces or discusses updates to documentation. new-resource Introduces a new resource. partner Contribution from a partner. provider Pertains to the provider itself, rather than any interaction with AWS. service/shield Issues and PRs that pertain to the shield service. size/XL Managed by automation to categorize the size of a PR. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure.
Projects
None yet
Milestone
v3.54.0
Development

Successfully merging this pull request may close these issues.

New Resource: aws_shield_protection_group
3 participants
@farhanangullia @ewbankkit @justinretzolk