sweeper/aws_directory_service_directory: Failing with "ClientException: Cannot delete the directory because it still has authorized applications"

[ewbankkit]

We see the aws_directory_service_directory sweeper failing with

ClientException: Cannot delete the directory because it still has authorized applications.

Investigate whether we have dependencies correctly defined.

[ewbankkit]

From the AWS Console, these are the AWS apps & services that can depend on a directory:

Currently we specify these sweeper dependencies:

terraform-provider-aws/aws/resource_aws_directory_service_directory_test.go

Lines 19 to 28 in 915f5f5

	resource.AddTestSweepers("aws_directory_service_directory", &resource.Sweeper{
	Name: "aws_directory_service_directory",
	F: testSweepDirectoryServiceDirectories,
	Dependencies: []string{
	"aws_db_instance",
	"aws_ec2_client_vpn_endpoint",
	"aws_fsx_windows_file_system",
	"aws_workspaces_directory",
	},
	})

[gdavison]

There's also a potential eventual consistency error that sometimes shows up in acceptance tests when an application is deleted right before the directory is deleted. We should add a Retry loop to the delete operation.

[zhelding]

#22027 appears to have fully resolved this issue. Running on the latest main (b0924ce), sweeper is passing:

$ SWEEPARGS=-sweep-run=aws_directory_service_directory make sweep
WARNING: This will destroy infrastructure. Use only in development accounts.
go test ./internal/sweep -v -tags=sweep -sweep=us-west-2,us-east-1,us-east-2 -sweep-run=aws_directory_service_directory -timeout 60m
2022/04/08 13:06:51 [DEBUG] Running Sweepers for region (us-west-2):
2022/04/08 13:06:51 [DEBUG] Running Sweeper (aws_ec2_client_vpn_network_association) in region (us-west-2)
2022/04/08 13:01:23 Completed Sweepers for region (us-east-2) in 8.319516773s
2022/04/08 13:01:23 Sweeper Tests for region (us-east-2) ran successfully:
        - aws_opsworks_rds_db_instance
        - aws_db_instance
        - aws_fsx_ontap_storage_virtual_machine
        - aws_ec2_client_vpn_network_association
        - aws_directory_service_directory
        - aws_appstream_directory_config
        - aws_fsx_ontap_volume
        - aws_workspaces_workspace
        - aws_workspaces_ip_group
        - aws_connect_instance
        - aws_transfer_server
        - aws_workspaces_directory
        - aws_fsx_windows_file_system
        - aws_ec2_client_vpn_endpoint
ok      github.com/hashicorp/terraform-provider-aws/internal/sweep      383.282s

[github-actions]

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems similar to this, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.