resource/aws_directory_service_directory: Adds retry when directory still has authorized applications

[gdavison]

There is a propagation delay for unregistering applications from the Directory Service directory. This PR adds a retry when aws_directory_service_directory still has authorized applications.

Relates #20556

Before the change

$ make testacc TESTS='TestAccConnectInstance_serial/directory' PKG=connect TEST_COUNT=3

=== RUN   TestAccConnectInstance_serial
=== RUN   TestAccConnectInstance_serial/directory
--- PASS: TestAccConnectInstance_serial (913.19s)
    --- PASS: TestAccConnectInstance_serial/directory (913.19s)
=== RUN   TestAccConnectInstance_serial
=== RUN   TestAccConnectInstance_serial/directory
    testing_new.go:70: Error running post-test destroy, there may be dangling resources: exit status 1
        
        Error: error deleting Directory Service Directory (d-9267770990): ClientException: Cannot delete the directory because it still has authorized applications. : RequestId: 382f7159-d266-4fc7-9555-40a2fc9fdf14
        {
          RespMetadata: {
            StatusCode: 400,
            RequestID: "382f7159-d266-4fc7-9555-40a2fc9fdf14"
          },
          Message_: "Cannot delete the directory because it still has authorized applications. : RequestId: 382f7159-d266-4fc7-9555-40a2fc9fdf14",
          RequestId: "382f7159-d266-4fc7-9555-40a2fc9fdf14"
        }
        
--- FAIL: TestAccConnectInstance_serial (467.35s)
    --- FAIL: TestAccConnectInstance_serial/directory (467.35s)
=== RUN   TestAccConnectInstance_serial
=== RUN   TestAccConnectInstance_serial/directory
    testing_new.go:70: Error running post-test destroy, there may be dangling resources: exit status 1
        
        Error: error deleting Directory Service Directory (d-92677709e2): ClientException: Cannot delete the directory because it still has authorized applications. : RequestId: 21f190be-008d-45cc-b08d-d3e0b1e341dc
        {
          RespMetadata: {
            StatusCode: 400,
            RequestID: "21f190be-008d-45cc-b08d-d3e0b1e341dc"
          },
          Message_: "Cannot delete the directory because it still has authorized applications. : RequestId: 21f190be-008d-45cc-b08d-d3e0b1e341dc",
          RequestId: "21f190be-008d-45cc-b08d-d3e0b1e341dc"
        }
        
--- FAIL: TestAccConnectInstance_serial (454.25s)
    --- FAIL: TestAccConnectInstance_serial/directory (454.25s)
FAIL
FAIL	github.com/hashicorp/terraform-provider-aws/internal/service/connect	1836.891s
FAIL

After change

$ make testacc TESTS=TestAccConnectInstance_serial/directory PKG=connect TEST_COUNT=3

=== RUN   TestAccConnectInstance_serial
=== RUN   TestAccConnectInstance_serial/directory
--- PASS: TestAccConnectInstance_serial (850.52s)
    --- PASS: TestAccConnectInstance_serial/directory (850.51s)
=== RUN   TestAccConnectInstance_serial
=== RUN   TestAccConnectInstance_serial/directory
--- PASS: TestAccConnectInstance_serial (858.79s)
    --- PASS: TestAccConnectInstance_serial/directory (858.79s)
=== RUN   TestAccConnectInstance_serial
=== RUN   TestAccConnectInstance_serial/directory
--- PASS: TestAccConnectInstance_serial (1001.44s)
    --- PASS: TestAccConnectInstance_serial/directory (1001.44s)
PASS

[ewbankkit]

LGTM 🚀.

[github-actions]

This functionality has been released in v3.69.0 of the Terraform AWS Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

[github-actions]

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.